openstack/cinder
Code Issues Proposed changes

Fix grammatical mistake, Changed character from "a" to "an"

Browse Source 
Change-Id: I3d1126f8243f80d6f15cc79813d9001fe7dd7853
This commit is contained in:
yanghuichan 2017-07-14 14:47:47 +08:00
parent 48b58580b6
commit 4c2584c813
13 changed files with 17 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cinder/api/v3/attachments.py
View File

@ -149,7 +149,7 @@ class AttachmentsController(wsgi.Controller):
}
NOTE all that's required for a reserve is volume_uuid
and a instance_uuid.
and an instance_uuid.
returns: A summary view of the attachment object
"""

2
cinder/objects/volume_attachment.py
View File

@ -66,7 +66,7 @@ class VolumeAttachment(base.CinderPersistentObject, base.CinderObject,
return ['volume']
def obj_make_compatible(self, primitive, target_version):
"""Make a object representation compatible with target version."""
"""Make an object representation compatible with target version."""
super(VolumeAttachment, self).obj_make_compatible(primitive,
target_version)
target_version = versionutils.convert_version_to_tuple(target_version)

2
cinder/tests/unit/api/contrib/test_volume_image_metadata.py
View File

@ -149,7 +149,7 @@ class VolumeImageMetadataTest(test.TestCase):
db.volume_glance_metadata_create(ctxt, fake.VOLUME_ID, 'ramdisk_id',
'someramdisk')
# create a unbootable volume
# create an unbootable volume
db.volume_create(ctxt, {'id': fake.VOLUME2_ID, 'status': 'available',
'host': 'test', 'provider_location': '',
'size': 1})

2
cinder/tests/unit/api/test_common.py
View File

@ -57,7 +57,7 @@ class LimiterTest(test.TestCase):
This test includes next test cases:
1) Offset key works with a blank offset;
2) Offset key works with a offset out of range;
2) Offset key works with an offset out of range;
3) Offset key works with a BAD offset;
4) Offset value is negative;
5) Limit value is bad;

6
cinder/tests/unit/volume/drivers/ibm/test_storwize_svc.py
View File

@ -2435,7 +2435,7 @@ class StorwizeSVCISCSIDriverTestCase(test.TestCase):
'_do_initialize_connection')
def test_storwize_do_terminate_iscsi_connection(self, init_conn,
term_conn):
# create a iSCSI volume
# create an iSCSI volume
volume_iSCSI = self._create_volume()
extra_spec = {'capabilities:storage_protocol': '<in> iSCSI'}
vol_type_iSCSI = volume_types.create(self.ctxt, 'iSCSI', extra_spec)
@ -2454,7 +2454,7 @@ class StorwizeSVCISCSIDriverTestCase(test.TestCase):
@mock.patch.object(storwize_svc_iscsi.StorwizeSVCISCSIDriver,
'_do_terminate_connection')
def test_storwize_initialize_iscsi_connection_failure(self, term_conn):
# create a iSCSI volume
# create an iSCSI volume
volume_iSCSI = self._create_volume()
extra_spec = {'capabilities:storage_protocol': '<in> iSCSI'}
vol_type_iSCSI = volume_types.create(self.ctxt, 'iSCSI', extra_spec)
@ -2472,7 +2472,7 @@ class StorwizeSVCISCSIDriverTestCase(test.TestCase):
term_conn.assert_called_once_with(volume_iSCSI, connector)
def test_storwize_terminate_iscsi_connection_multi_attach(self):
# create a iSCSI volume
# create an iSCSI volume
volume_iSCSI = self._create_volume()
extra_spec = {'capabilities:storage_protocol': '<in> iSCSI'}
vol_type_iSCSI = volume_types.create(self.ctxt, 'iSCSI', extra_spec)

2
cinder/volume/drivers/infortrend/raidcmd_cli/common_cli.py
View File

@ -468,7 +468,7 @@ class InfortrendCommon(object):
self._check_tiers_setup()
def create_volume(self, volume):
"""Create a Infortrend partition."""
"""Create an Infortrend partition."""
volume_id = volume['id'].replace('-', '')
self._create_partition_by_default(volume)

2
cinder/volume/drivers/kaminario/kaminario_common.py
View File

@ -619,7 +619,7 @@ class KaminarioCinderDriver(cinder.volume.driver.ISCSIDriver):
src_map = self.client.search("mappings", volume=src_vol)
src_attach_info = dest_attach_info = None
if src_map.total != 0:
msg = _("K2 driver does not support clone of a attached volume. "
msg = _("K2 driver does not support clone of an attached volume. "
"To get this done, create a snapshot from the attached "
"volume and then create a volume from the snapshot.")
LOG.error(msg)

4
cinder/volume/drivers/netapp/eseries/library.py
View File

@ -403,7 +403,7 @@ class NetAppESeriesLibrary(object):
raise exception.NotFound(msg % snapshot['pitGroupRef'])
def _get_snapshot_legacy(self, snapshot):
"""Find a E-Series snapshot by the name of the snapshot group.
"""Find an E-Series snapshot by the name of the snapshot group.
Snapshots were previously identified by the unique name of the
snapshot group. A snapshot volume is now utilized to uniquely
@ -431,7 +431,7 @@ class NetAppESeriesLibrary(object):
'found.') % snapshot['id'])
def _get_snapshot(self, snapshot):
"""Find a E-Series snapshot by its Cinder identifier
"""Find an E-Series snapshot by its Cinder identifier
An E-Series snapshot image does not have a configuration name/label,
so we define a snapshot volume underneath of it that will help us to

2
cinder/volume/drivers/pure.py
View File

@ -832,7 +832,7 @@ class PureBaseVolumeDriver(san.SanDriver):
ctxt.reraise = False
# If volume information was unable to be retrieved we need
# to throw a Invalid Reference exception.
# to throw an Invalid Reference exception.
raise exception.ManageExistingInvalidReference(
existing_ref=existing_ref,
reason=_("Unable to find Purity ref with name=%s") % ref_vol_name)

2
cinder/volume/drivers/zte/zte_ks.py
View File

@ -529,7 +529,7 @@ class ZTEVolumeDriver(driver.VolumeDriver):
pass
def ensure_export(self, context, volume):
"""Driver entry point to get the export info for a existing volume."""
"""Driver entry point to get the export info for an existing volume."""
pass
def remove_export(self, context, volume_id):

4
cinder/volume/flows/manager/create_volume.py
View File

@ -1004,8 +1004,8 @@ def get_flow(context, manager, db, driver, scheduler_rpcapi, host, volume,
4. Extracts a volume specification from the provided inputs.
5. Notifies that the volume has started to be created.
6. Creates a volume from the extracted volume specification.
7. Attaches a on-success *only* task that notifies that the volume creation
has ended and performs further database status updates.
7. Attaches an on-success *only* task that notifies that the volume
creation has ended and performs further database status updates.
"""
flow_name = ACTION.replace(":", "_") + "_manager"

2
cinder/zonemanager/drivers/cisco/cisco_fc_zone_driver.py
View File

@ -211,7 +211,7 @@ class CiscoFCZoneDriver(fc_zone_driver.FCZoneDriver):
self.configuration.cisco_zone_name_prefix,
SUPPORTED_CHARS))
# If zone exists, then perform a update_zone and add
# If zone exists, then perform an update_zone and add
# new members into existing zone.
if zone_name and (zone_name in zone_names):
zone_members = filter(

2
doc/source/upgrade.rst
View File

@ -29,7 +29,7 @@ old orphaned records in that table.
Graceful service shutdown
'''''''''''''''''''''''''
Many cinder services are python processes listening for messages on a AMQP
Many cinder services are python processes listening for messages on an AMQP
queue. When the operator sends SIGTERM signal to the process, it stops getting
new work from its queue, completes any outstanding work and then terminates.
During this process, messages can be left on the queue for when the python