openstack/cinder
Code Issues Proposed changes

Fix 401 from auth_token middleware

Browse Source 
The openssl popen call to verify the token returns an error code
of 2 when a file doesn't exist. Normally this is caught and the
relevant file is downloaded, but monkeypatching os causes this
error code to be eaten and cinder to return a 401. Note that this
is likely a race condition that depends on exactly when greenthreads
are switching that is causing the return code from Popen to get
overwritten.

It is possible that this is exposing an underlying bug in eventlet
but the workaround is simply to make sure that we don't monkeypatch
os.

Fixes bug 1075838

Change-Id: I69ba75136e32e95c6fdf108f0c4fe21a5e3bdbe6
This commit is contained in:
Vishvananda Ishaya 2012-11-06 20:12:00 -08:00
parent 5aa1e72911
commit 4e619fbef8
4 changed files with 4 additions and 4 deletions

2
bin/cinder-all

@ -28,7 +28,7 @@ continue attempting to launch the rest of the services.
"""
import eventlet
eventlet.monkey_patch()
eventlet.monkey_patch(os=False)
import os
import sys

2
bin/cinder-api

@ -20,7 +20,7 @@
"""Starter script for Cinder OS API."""
import eventlet
eventlet.monkey_patch()
eventlet.monkey_patch(os=False)
import os
import sys

2
bin/cinder-scheduler

@ -20,7 +20,7 @@
"""Starter script for Cinder Scheduler."""
import eventlet
eventlet.monkey_patch()
eventlet.monkey_patch(os=False)
import gettext
import os

2
bin/cinder-volume

@ -20,7 +20,7 @@
"""Starter script for Cinder Volume."""
import eventlet
eventlet.monkey_patch()
eventlet.monkey_patch(os=False)
import os
import sys