openstack/cinder
Code Issues Proposed changes

Merge "Remove unecessary pass"

Browse Source
This commit is contained in:
Zuul 2018-09-26 16:58:47 +00:00 committed by Gerrit Code Review
commit 7c2086cb40
8 changed files with 0 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.pylintrc
View File

@ -112,7 +112,6 @@ disable=
signature-differs, signature-differs,
star-args, star-args,
super-init-not-called, super-init-not-called,
unnecessary-pass,
unpacking-non-sequence, unpacking-non-sequence,
unused-argument, unused-argument,
unused-import, unused-import,

2
cinder/group/api.py
View File

@ -291,7 +291,6 @@ class API(base.Base):
"Do not need to create again.", "Do not need to create again.",
{'grp': group.id, {'grp': group.id,
'vol_type': volume_type_id}) 'vol_type': volume_type_id})
pass
# Since group snapshot is passed in, the following call will # Since group snapshot is passed in, the following call will
# create a db entry for the volume, but will not call the # create a db entry for the volume, but will not call the
@ -374,7 +373,6 @@ class API(base.Base):
"Do not need to create again.", "Do not need to create again.",
{'grp': group.id, {'grp': group.id,
'vol_type': volume_type_id}) 'vol_type': volume_type_id})
pass
# Since source_group is passed in, the following call will # Since source_group is passed in, the following call will
# create a db entry for the volume, but will not call the # create a db entry for the volume, but will not call the

2
cinder/volume/api.py
View File

@ -1238,8 +1238,6 @@ class API(base.Base):
def get_snapshot_metadata_value(self, snapshot, key): def get_snapshot_metadata_value(self, snapshot, key):
LOG.info("Get snapshot metadata value not implemented.", LOG.info("Get snapshot metadata value not implemented.",
resource=snapshot) resource=snapshot)
# FIXME(jdg): Huh? Pass?
pass
def get_volumes_image_metadata(self, context): def get_volumes_image_metadata(self, context):
context.authorize(vol_meta_policy.GET_POLICY) context.authorize(vol_meta_policy.GET_POLICY)

2
cinder/volume/drivers/fujitsu/eternus_dx_fc.py
View File

@ -51,8 +51,6 @@ class FJDXFCDriver(driver.FibreChannelDriver):
LOG.error('pywbem could not be imported! ' LOG.error('pywbem could not be imported! '
'pywbem is necessary for this volume driver.') 'pywbem is necessary for this volume driver.')
pass
def create_volume(self, volume): def create_volume(self, volume):
"""Create volume.""" """Create volume."""
LOG.debug('create_volume, ' LOG.debug('create_volume, '

1
cinder/volume/drivers/hpe/hpe_3par_base.py
View File

@ -89,7 +89,6 @@ class HPE3PARDriverBase(driver.ManageableVD,
"time. Since replication is enabled, " "time. Since replication is enabled, "
"listing replication targets and failing over " "listing replication targets and failing over "
"a volume can still be performed.") "a volume can still be performed.")
pass
else: else:
raise raise
return common return common

3
cinder/volume/drivers/hpe/hpe_3par_common.py
View File

@ -1726,7 +1726,6 @@ class HPE3PARCommon(object):
vluns = self.client.getHostVLUNs(hostname) vluns = self.client.getHostVLUNs(hostname)
except hpeexceptions.HTTPNotFound: except hpeexceptions.HTTPNotFound:
LOG.debug("All VLUNs removed from host %s", hostname) LOG.debug("All VLUNs removed from host %s", hostname)
pass
if wwn is not None and not isinstance(wwn, list): if wwn is not None and not isinstance(wwn, list):
wwn = [wwn] wwn = [wwn]
@ -3415,7 +3414,6 @@ class HPE3PARCommon(object):
"combination: %(host)s, %(vol)s", "combination: %(host)s, %(vol)s",
{'host': host['name'], {'host': host['name'],
'vol': vol_name}) 'vol': vol_name})
pass
return existing_vlun return existing_vlun
def find_existing_vluns(self, volume, host): def find_existing_vluns(self, volume, host):
@ -3433,7 +3431,6 @@ class HPE3PARCommon(object):
"combination: %(host)s, %(vol)s", "combination: %(host)s, %(vol)s",
{'host': host['name'], {'host': host['name'],
'vol': vol_name}) 'vol': vol_name})
pass
return existing_vluns return existing_vluns
# v2 replication methods # v2 replication methods

1
cinder/volume/drivers/ibm/flashsystem_common.py
View File

@ -1218,4 +1218,3 @@ class FlashSystemDriver(san.SanDriver,
"""Removes the specified volume from Cinder management.""" """Removes the specified volume from Cinder management."""
LOG.debug('unmanage: volume %(vol)s is no longer managed by cinder.', LOG.debug('unmanage: volume %(vol)s is no longer managed by cinder.',
{'vol': volume}) {'vol': volume})
pass

1
cinder/volume/drivers/qnap.py
View File

@ -535,7 +535,6 @@ class QnapISCSIDriver(san.SanISCSIDriver):
self.api_executor.delete_snapshot_api(snapshot_id) self.api_executor.delete_snapshot_api(snapshot_id)
elif 'ES' in internal_model_name.upper(): elif 'ES' in internal_model_name.upper():
LOG.debug('in ES FW: do nothing') LOG.debug('in ES FW: do nothing')
pass
_metadata = self._get_volume_metadata(volume) _metadata = self._get_volume_metadata(volume)
_metadata['LUNIndex'] = lun_index _metadata['LUNIndex'] = lun_index
_metadata['LUNNAA'] = lun_naa _metadata['LUNNAA'] = lun_naa