openstack/cinder
Code Issues Proposed changes

Fix thin provisioning flags in NetApp drivers

Browse Source 
The Cinder scheduler expects thin provisioning support to be
reported by drivers as 'thin_provisioning_support' and
'thick_provisioning_support'. The NetApp Data ONTAP drivers
for iSCSI/FC incorrectly report those flags as
'thin_provisioned_support' and 'thick_provisioned_support'.
It's a trivial change to fix that.

Closes-Bug: #1532285
Change-Id: I84eb867b753e18825e619e16b4121b34230c06ee
This commit is contained in:
Clinton Knight 2016-01-08 13:17:08 -05:00
parent bf31b0c253
commit 7c789079a3
5 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
cinder/tests/unit/volume/drivers/netapp/dataontap/fakes.py
View File

@ -232,8 +232,8 @@ FAKE_CMODE_POOLS = [
'pool_name': 'open123',
'reserved_percentage': 0,
'total_capacity_gb': 4.65,
'thin_provisioned_support': True,
'thick_provisioned_support': False,
'thin_provisioning_support': True,
'thick_provisioning_support': False,
'provisioned_capacity_gb': 0.93,
'max_over_subscription_ratio': 20.0,
}
@ -335,8 +335,8 @@ FAKE_7MODE_POOLS = [
'total_capacity_gb': 0.0,
'free_capacity_gb': 0.0,
'max_over_subscription_ratio': 20.0,
'thin_provisioned_support': False,
'thick_provisioned_support': True,
'thin_provisioning_support': False,
'thick_provisioning_support': True,
'provisioned_capacity_gb': 0.0,
}
]

4
cinder/tests/unit/volume/drivers/netapp/dataontap/test_block_7mode.py
View File

@ -498,8 +498,8 @@ class NetAppBlockStorage7modeLibraryTestCase(test.TestCase):
expected = [{
'pool_name': 'vol1',
'QoS_support': False,
'thin_provisioned_support': not thick,
'thick_provisioned_support': thick,
'thin_provisioning_support': not thick,
'thick_provisioning_support': thick,
'provisioned_capacity_gb': 2.94,
'free_capacity_gb': 1339.27,
'total_capacity_gb': 1342.21,

4
cinder/tests/unit/volume/drivers/netapp/dataontap/test_block_cmode.py
View File

@ -337,8 +337,8 @@ class NetAppBlockStorageCmodeLibraryTestCase(test.TestCase):
expected = [{'pool_name': 'vola',
'netapp_unmirrored': 'true',
'QoS_support': True,
'thin_provisioned_support': not thick,
'thick_provisioned_support': thick,
'thin_provisioning_support': not thick,
'thick_provisioning_support': thick,
'provisioned_capacity_gb': 8.0,
'netapp_thick_provisioned': netapp_thick,
'netapp_nocompression': 'true',

4
cinder/volume/drivers/netapp/dataontap/block_7mode.py
View File

@ -305,8 +305,8 @@ class NetAppBlockStorage7modeLibrary(block_base.NetAppBlockStorageLibrary):
thick = (
self.configuration.netapp_lun_space_reservation == 'enabled')
pool['thick_provisioned_support'] = thick
pool['thin_provisioned_support'] = not thick
pool['thick_provisioning_support'] = thick
pool['thin_provisioning_support'] = not thick
pools.append(pool)

4
cinder/volume/drivers/netapp/dataontap/block_cmode.py
View File

@ -246,8 +246,8 @@ class NetAppBlockStorageCmodeLibrary(block_base.NetAppBlockStorageLibrary):
thick = (not thin and
self.configuration.netapp_lun_space_reservation
== 'enabled')
pool['thick_provisioned_support'] = thick
pool['thin_provisioned_support'] = not thick
pool['thick_provisioning_support'] = thick
pool['thin_provisioning_support'] = not thick
pools.append(pool)