openstack/cinder
Code Issues Proposed changes

Pass with mypy 1.11.0

Browse Source 
Include some temporary skips to pass with the
newly-released mypy 1.11.0.

Actual fixes to follow.

Change-Id: Id3990df4fbe5914cc3b5e10ccf90aa9e5c1210a5
This commit is contained in:
Eric Harney 2024-07-22 09:52:59 -04:00
parent 8a6ffb36c9
commit 834d933fa9
3 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cinder/backup/manager.py
View File

@ -33,6 +33,7 @@ Volume backups can be created, restored, deleted and listed.
import contextlib import contextlib
import os import os
import typing
from castellan import key_manager from castellan import key_manager
from eventlet import tpool from eventlet import tpool
@ -139,6 +140,7 @@ class BackupManager(manager.SchedulerDependentManager):
self.service = importutils.import_class(self.driver_name) self.service = importutils.import_class(self.driver_name)
self.message_api = message_api.API() self.message_api = message_api.API()
@typing.no_type_check
def init_host(self, **kwargs): def init_host(self, **kwargs):
"""Run initialization needed for a standalone service.""" """Run initialization needed for a standalone service."""
ctxt = context.get_admin_context() ctxt = context.get_admin_context()

1
cinder/scheduler/host_manager.py
View File

@ -445,6 +445,7 @@ class PoolState(BackendState):
self.filter_function = capability.get('filter_function', None) self.filter_function = capability.get('filter_function', None)
self.goodness_function = capability.get('goodness_function', 0) self.goodness_function = capability.get('goodness_function', 0)
@typing.no_type_check
def update_pools(self, capability): def update_pools(self, capability):
# Do nothing, since we don't have pools within pool, yet # Do nothing, since we don't have pools within pool, yet
pass pass

1
cinder/volume/flows/manager/create_volume.py
View File

@ -1292,6 +1292,7 @@ class CreateVolumeOnFinishTask(NotifyVolumeActionTask):
'migration_target_creating': 'migration_target', 'migration_target_creating': 'migration_target',
} }
@typing.no_type_check
def execute(self, context, volume, volume_spec): def execute(self, context, volume, volume_spec):
need_update_volume = volume_spec.pop('need_update_volume', True) need_update_volume = volume_spec.pop('need_update_volume', True)
if not need_update_volume: if not need_update_volume: