openstack/cinder
Code Issues Proposed changes

Modify variable's usage in Log Messages

Browse Source 
String interpolation should be delayed to be handled by the logging code,
rather than being done at the point of the logging call.
Ref:http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages
For example:
LOG.info(_LI('some message: variable=%s') % variable)
LOG.info(_LI('some message: variable=%s'), variable)

Change-Id: I6b3d5572ddd00b8d73a255e4b8a2ff191baad58a
This commit is contained in:
chenaidong1 2016-12-09 13:53:03 +08:00
parent 3ae516620c
commit 863486f7a4
1 changed files with 1 additions and 1 deletions

2
cinder/volume/drivers/netapp/dataontap/client/client_7mode.py

@ -67,7 +67,7 @@ class Client(client_base.Client):
node_client.send_request('ems-autosupport-log', message_dict)
LOG.debug('EMS executed successfully.')
except netapp_api.NaApiError as e:
LOG.warning(_LW('Failed to invoke EMS. %s') % e)
LOG.warning(_LW('Failed to invoke EMS. %s'), e)
def get_iscsi_target_details(self):
"""Gets the iSCSI target portal details."""