openstack/cinder
Code Issues Proposed changes

VMware: Fix create vol from streamOptimized image

Browse Source 
Change I247bf2a072e195c3918f222a9770f8018690db16 renamed a keyword
argument in get_create_spec. The _fetch_stream_optimized_image
method which creates a volume from streamOptimized image uses this
method, but it was not updated to use the new keyword argument. The
VMware CI couldn't catch this because we use preallocated image for
tempest tests. This patch updates the keyword argument to fix the
issue.

Change-Id: I20cbc8f137fe31302770cc0b2f5dde1f23339191
Closes-bug: #1596907
This commit is contained in:
Vipin Balachandran 2016-06-28 16:11:03 +05:30
parent 9af8e7125b
commit 98939fcc35
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cinder/tests/unit/test_vmware_vmdk.py
View File

@ -787,7 +787,7 @@ class VMwareVcVmdkDriverTestCase(test.TestCase):
select_ds_for_volume.assert_called_once_with(volume)
vops.get_create_spec.assert_called_once_with(
volume['name'], 0, disk_type, summary.name, profileId=profile_id,
volume['name'], 0, disk_type, summary.name, profile_id=profile_id,
adapter_type=adapter_type, extra_config=extra_config)
self.assertEqual(vm_create_spec, import_spec.configSpec)
download_image.assert_called_with(

2
cinder/volume/drivers/vmware/vmdk.py
View File

@ -1020,7 +1020,7 @@ class VMwareVcVmdkDriver(driver.VolumeDriver):
dummy_disk_size,
disk_type,
summary.name,
profileId=profile_id,
profile_id=profile_id,
adapter_type=adapter_type,
extra_config=extra_config)
# convert vm_create_spec to vm_import_spec