openstack/cinder
Code Issues Proposed changes

Move bandit requirements to tox.ini

Browse Source 
This makes bandit requirements work like our
pylint requirements.  (Neither are handled
in the typical way by openstack/requirements.)

This prevents needless installation of bandit
for each unit test job run.

Change-Id: I513de53520a4531067cea4e7a225fb1ad2e9ba06
This commit is contained in:
Eric Harney 2022-06-27 10:51:48 -04:00
parent 031f10ce95
commit befa5b5be8
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
test-requirements.txt
View File

@ -17,9 +17,6 @@ psycopg2>=2.8.5 # LGPL/ZPL
SQLAlchemy-Utils>=0.37.8 # BSD License SQLAlchemy-Utils>=0.37.8 # BSD License
testtools>=2.4.0 # MIT testtools>=2.4.0 # MIT
# bandit is not included in upper-constraints,
# so we need to pin it here to a known working version
bandit==1.6.0 # Apache-2.0
doc8>=0.8.1 # Apache-2.0 doc8>=0.8.1 # Apache-2.0
mypy>=0.942 # MIT mypy>=0.942 # MIT
moto>=1.3.15 # Apache-2.0 moto>=1.3.15 # Apache-2.0

2
tox.ini
View File

@ -144,9 +144,11 @@ commands = python {toxinidir}/tools/generate_driver_list.py
[testenv:bandit] [testenv:bandit]
deps = -r{toxinidir}/test-requirements.txt deps = -r{toxinidir}/test-requirements.txt
bandit==1.6.0
commands = bandit -r cinder -n5 -x cinder/tests/* -ll commands = bandit -r cinder -n5 -x cinder/tests/* -ll
[testenv:bandit-baseline] [testenv:bandit-baseline]
deps = bandit==1.6.0
envdir = {toxworkdir}/bandit envdir = {toxworkdir}/bandit
commands = bandit-baseline -r cinder -n5 -x cinder/tests/* -ii -ll commands = bandit-baseline -r cinder -n5 -x cinder/tests/* -ii -ll