openstack/cinder
Code Issues Proposed changes

nit: Add FIXME to image volume cache

Browse Source 
The image volume cache now has logic to clone across pools based on
the value reported by the driver.
There is a case that was missed which is added as a FIXME in this
patch.

Change-Id: I34d7b6788290669d687f9c47f54db084442a7ee3
This commit is contained in:
Rajat Dhasmana 2024-09-25 20:17:58 +05:30
parent c76680a684
commit e57c350d0b
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
cinder/image/cache.py
View File

@ -62,6 +62,11 @@ class ImageVolumeCache(object):
return {'cluster_name': volume_ref.cluster_name} return {'cluster_name': volume_ref.cluster_name}
if not self.clone_across_pools: if not self.clone_across_pools:
return {'host': volume_ref.host} return {'host': volume_ref.host}
# FIXME(whoami-rajat): If we have two cinder backends pointing to
# two different storage arrays, this logic will allow the operation
# to proceed to clone across two storage arrays which will fail
# eventually. We should at least filter with the hostname in the
# given host value hostname@backend#pool.
return {} return {}
def get_entry(self, def get_entry(self,