As a work-around to deal with bug 1075838, we modified
monkey_patch in the Cinder binaries. The root cause of the
issue is/was actually a bug in eventlet but this was a quick
work-around.
Since the change Change-Id: I69ba75136e32e95c6fdf108f0c4fe21a5e3bdbe6
to do this landed, the problem has also been addressed in Keystone.
So, let's revert this patch to get back the greenthread performance
that we may have lost with this change. For now, everything should
be addressed as long as we don't implement multi api worker in Cinder,
if we do and the evenlet fix hasn't been released we'll need to turn
the modification back on for bin/cinder-api.
Change-Id: Ie845bade85dbceacd91f15e082325602d9a79c74
The openssl popen call to verify the token returns an error code
of 2 when a file doesn't exist. Normally this is caught and the
relevant file is downloaded, but monkeypatching os causes this
error code to be eaten and cinder to return a 401. Note that this
is likely a race condition that depends on exactly when greenthreads
are switching that is causing the return code from Popen to get
overwritten.
It is possible that this is exposing an underlying bug in eventlet
but the workaround is simply to make sure that we don't monkeypatch
os.
Fixes bug 1075838
Change-Id: I69ba75136e32e95c6fdf108f0c4fe21a5e3bdbe6
- We are not using openstack.common.notifier just yet so handedit
openstack.common.log to use cinder.notifier now.
Change-Id: I9d912904c53a8ef5d90b4ab5792f5577701b6817
Cherry picks 00786bc from Nova.
Implements blueprint cfg-global-object
Replace cinder.flags.FLAGS with openstack.common.cfg.CONF.
In future, we can do a s/FLAGS/CONF/ across the codebase.
Change-Id: If213a4a5da1faf96aac82f34b18d1e0b061495c0