cinder/brocade_rest_client-202cfd474c96d3fe.yaml at 09ad89b7eecd6ea654a17690996c2ec4a63dd31e - cinder - OpenDev: Free Software Needs Free Tools

openstack/cinder

Gorka Eguileor 6dbd08b491 Brocade: Fix AttributeError when raising exception

When we moved Brocade exceptions from cinder.exception to
cinder.zonemanager.drivers.broade.exception we missed one file,
brcd_rest_fc_zone_client, so when we use that file (setting
`fc_southbound_protocol = REST_HTTP`) if it tries to raise an exception
we end up seeing:

  AttributeError: module 'cinder.exception' has no attribute
  'BrocadeZoningRestException'

The CI didn't catch it because there are no unit tests for the
brcd_rest_fc_zone_client.py file.

This patch fixes the issue by changing the import so it gets the
exceptions from the Brocade file and it also adds some tests for the
first half (211 lines) of the code in the brcd_rest_fc_zone_client.py
file.

TrivialFix
Closes-Bug: #1866860
Change-Id: Idfdb8796d5f4b650aa762e54a189c9ab48f93d1a

2020-07-29 10:14:12 +02:00

7 lines

212 B

YAML

Raw Blame History

 ---
 fixes:
   - |
     Fix `AttributeError` on the Brocade ZM driver when using setting REST_HTTP
     or REST_HTTPS as the fc_southbound_protocol option and an exception is
     raised by the client (Bug #1866860).