51418bdd5b
Along with moving to pep8 1.3.3, we also want to standardize on what we ignore. This patch get's us most of the way there by setting the ignore list to: N4,E125, E126, E711,E712. Almost all changes made here are white-space/indentation changes. The removal of Hacking N4 errors from the ignore list will be handled in a seperate patch. Change-Id: If45f156600485d23769449018590f60b4f69b0c5
183 lines
5.7 KiB
Bash
Executable File
183 lines
5.7 KiB
Bash
Executable File
#!/bin/bash
|
|
|
|
set -eu
|
|
|
|
function usage {
|
|
echo "Usage: $0 [OPTION]..."
|
|
echo "Run Cinder's test suite(s)"
|
|
echo ""
|
|
echo " -V, --virtual-env Always use virtualenv. Install automatically if not present"
|
|
echo " -N, --no-virtual-env Don't use virtualenv. Run tests in local environment"
|
|
echo " -s, --no-site-packages Isolate the virtualenv from the global Python environment"
|
|
echo " -r, --recreate-db Recreate the test database (deprecated, as this is now the default)."
|
|
echo " -n, --no-recreate-db Don't recreate the test database."
|
|
echo " -x, --stop Stop running tests after the first error or failure."
|
|
echo " -f, --force Force a clean re-build of the virtual environment. Useful when dependencies have been added."
|
|
echo " -p, --pep8 Just run PEP8 and HACKING compliance check"
|
|
echo " -P, --no-pep8 Don't run static code checks"
|
|
echo " -c, --coverage Generate coverage report"
|
|
echo " -X, --coverage-xml Generate XML coverage report."
|
|
echo " -h, --help Print this usage message"
|
|
echo " --hide-elapsed Don't print the elapsed time for each test along with slow test list"
|
|
echo ""
|
|
echo "Note: with no options specified, the script will try to run the tests in a virtual environment,"
|
|
echo " If no virtualenv is found, the script will ask if you would like to create one. If you "
|
|
echo " prefer to run tests NOT in a virtual environment, simply pass the -N option."
|
|
exit
|
|
}
|
|
|
|
function process_option {
|
|
case "$1" in
|
|
-h|--help) usage;;
|
|
-V|--virtual-env) always_venv=1; never_venv=0;;
|
|
-N|--no-virtual-env) always_venv=0; never_venv=1;;
|
|
-s|--no-site-packages) no_site_packages=1;;
|
|
-r|--recreate-db) recreate_db=1;;
|
|
-n|--no-recreate-db) recreate_db=0;;
|
|
-m|--patch-migrate) patch_migrate=1;;
|
|
-w|--no-patch-migrate) patch_migrate=0;;
|
|
-f|--force) force=1;;
|
|
-p|--pep8) just_pep8=1;;
|
|
-P|--no-pep8) no_pep8=1;;
|
|
-c|--coverage) coverage=1;;
|
|
-X|--coverage-xml) coverage_xml=1;;
|
|
-*) noseopts="$noseopts $1";;
|
|
*) noseargs="$noseargs $1"
|
|
esac
|
|
}
|
|
|
|
venv=.venv
|
|
with_venv=tools/with_venv.sh
|
|
always_venv=0
|
|
never_venv=0
|
|
force=0
|
|
no_site_packages=0
|
|
installvenvopts=
|
|
noseargs=
|
|
noseopts=
|
|
wrapper=""
|
|
just_pep8=0
|
|
no_pep8=0
|
|
coverage=0
|
|
coverage_xml=0
|
|
recreate_db=1
|
|
patch_migrate=1
|
|
|
|
for arg in "$@"; do
|
|
process_option $arg
|
|
done
|
|
|
|
# If enabled, tell nose to collect coverage data
|
|
if [ $coverage -eq 1 ]; then
|
|
noseopts="$noseopts --with-coverage --cover-package=cinder"
|
|
fi
|
|
if [ $coverage_xml -eq 1 ]; then
|
|
noseopts="$noseopts --with-xcoverage --cover-package=cinder --xcoverage-file=`pwd`/coverage.xml"
|
|
fi
|
|
|
|
if [ $no_site_packages -eq 1 ]; then
|
|
installvenvopts="--no-site-packages"
|
|
fi
|
|
|
|
function run_tests {
|
|
# Cleanup *pyc
|
|
${wrapper} find . -type f -name "*.pyc" -delete
|
|
# Just run the test suites in current environment
|
|
${wrapper} $NOSETESTS 2> run_tests.log
|
|
# If we get some short import error right away, print the error log directly
|
|
RESULT=$?
|
|
if [ "$RESULT" -ne "0" ];
|
|
then
|
|
ERRSIZE=`wc -l run_tests.log | awk '{print \$1}'`
|
|
if [ "$ERRSIZE" -lt "40" ];
|
|
then
|
|
cat run_tests.log
|
|
fi
|
|
fi
|
|
return $RESULT
|
|
}
|
|
|
|
# Files of interest
|
|
# NOTE(lzyeval): Avoid selecting cinder-api-paste.ini and cinder.conf in cinder/bin
|
|
# when running on devstack.
|
|
# NOTE(lzyeval): Avoid selecting *.pyc files to reduce pep8 check-up time
|
|
# when running on devstack.
|
|
# NOTE(dprince): Exclude xenapi plugins. They are Python 2.4 code and as such
|
|
# cannot be expected to work with tools/hacking checks.
|
|
xen_net_path="plugins/xenserver/networking/etc/xensource/scripts"
|
|
srcfiles=`find cinder -type f -name "*.py" ! -path "cinder/openstack/common/*"`
|
|
srcfiles+=" `find bin -type f ! -name "cinder.conf*" ! -name "*api-paste.ini*"`"
|
|
srcfiles+=" `find tools -type f -name "*.py"`"
|
|
srcfiles+=" setup.py"
|
|
|
|
function run_pep8 {
|
|
echo "Running PEP8 and HACKING compliance check..."
|
|
# Just run PEP8 in current environment
|
|
#
|
|
|
|
# Until all these issues get fixed, ignore.
|
|
ignore='--ignore=N4,E125,E126,E711,E712'
|
|
${wrapper} python tools/hacking.py ${ignore} ${srcfiles}
|
|
}
|
|
|
|
|
|
NOSETESTS="python cinder/testing/runner.py $noseopts $noseargs"
|
|
|
|
if [ $never_venv -eq 0 ]
|
|
then
|
|
# Remove the virtual environment if --force used
|
|
if [ $force -eq 1 ]; then
|
|
echo "Cleaning virtualenv..."
|
|
rm -rf ${venv}
|
|
fi
|
|
if [ -e ${venv} ]; then
|
|
wrapper="${with_venv}"
|
|
else
|
|
if [ $always_venv -eq 1 ]; then
|
|
# Automatically install the virtualenv
|
|
python tools/install_venv.py $installvenvopts
|
|
wrapper="${with_venv}"
|
|
else
|
|
echo -e "No virtual environment found...create one? (Y/n) \c"
|
|
read use_ve
|
|
if [ "x$use_ve" = "xY" -o "x$use_ve" = "x" -o "x$use_ve" = "xy" ]; then
|
|
# Install the virtualenv and run the test suite in it
|
|
python tools/install_venv.py $installvenvopts
|
|
wrapper=${with_venv}
|
|
fi
|
|
fi
|
|
fi
|
|
fi
|
|
|
|
# Delete old coverage data from previous runs
|
|
if [ $coverage -eq 1 ]; then
|
|
${wrapper} coverage erase
|
|
fi
|
|
|
|
if [ $just_pep8 -eq 1 ]; then
|
|
run_pep8
|
|
exit
|
|
fi
|
|
|
|
if [ $recreate_db -eq 1 ]; then
|
|
rm -f tests.sqlite
|
|
fi
|
|
|
|
run_tests
|
|
|
|
# NOTE(sirp): we only want to run pep8 when we're running the full-test suite,
|
|
# not when we're running tests individually. To handle this, we need to
|
|
# distinguish between options (noseopts), which begin with a '-', and
|
|
# arguments (noseargs).
|
|
if [ -z "$noseargs" ]; then
|
|
if [ $no_pep8 -eq 0 ]; then
|
|
run_pep8
|
|
fi
|
|
fi
|
|
|
|
if [ $coverage -eq 1 ]; then
|
|
echo "Generating coverage report in covhtml/"
|
|
# Don't compute coverage for common code, which is tested elsewhere
|
|
${wrapper} coverage html --include='cinder/*' --omit='cinder/openstack/common/*' -d covhtml -i
|
|
fi
|