openstack/glance
Code Issues Proposed changes

Add LOG.warning to Disallowed minor changes

Browse Source 
Adds move to LOG.warning to disallowed minor changes page with
explanation.

Change-Id: Ib4ac1175005c8f41e65b56770e14d1a7817df7f0
This commit is contained in:
Erno Kuvaja 2016-07-19 00:32:57 +02:00
parent 5dfaf42077
commit c8ecd9321b
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
doc/source/contributing/minor-code-changes.rst
View File

@ -31,3 +31,13 @@ like weakening changes.
We're not saying that such changes can never be made, we're just saying that We're not saying that such changes can never be made, we're just saying that
each change must be accompanied by an explanation of why the weaker test is each change must be accompanied by an explanation of why the weaker test is
adequate for what's being tested. adequate for what's being tested.
LOG.warn to LOG.warning
-----------------------
Consistently there are proposed changes that will change all {LOG,logging}.
warn to {LOG,logging}.warning across the codebase due to the deprecation in
Python 3. While the deprecation is real, Glance uses oslo_log that provides
alias warn and solves the issue in single place for all projects using it.
These changes are not accepted due to the huge amount of refactoring they
cause for no reason.