Default behavior in tox is to bail when there's a failure in a set
of commands in a testenv. Now that the functional tests run multiple
commands, this behavior isn't desirable. Add the ignore_errors
configuration to the two functional testenvs so all functional tests
will be run.
Change-Id: I8525d0988c6df4d3339e2ac68dc9b6effe07231f
The current scrubber functional tests seem to be confusing the subunit parser.
This patch modifies the functional test definition in tox.ini to run serial
tests separately from the "regular" functional tests and moves the current
scrubber tests to the 'serial' directory
Change-Id: I041c90aa8854bca30f9ea7b0c9d81e41f79cb81e
Partial-bug: #1768077
Replace strategy of time.sleep(s_value) waiting for an image to
reach 'active' with a time-bounded wait-for-status loop function.
That way we can have a more generous s_value, which seems to
sometimes be needed in the gates, without having to use that much
time on every run.
I picked the initial s_value as 4x what was in the current code,
though given that some of the other gate tests run >1 hour, we could
easily make it 600 sec without lengthening the current minimum
time-to-verification of a patch.
Closes-bug: #1767142
Change-Id: Ib771079348d22212c7b6d90fa89e7fd4161422d3
Move the list of useful image properties from the glanceclient
docs to the Glance Admin Guide. It makes more sense in the Glance
docs as the only connection they have with the glanceclient is that
you can use the client CLI to set these properties
The table of property keys/values is unchanged; the introductory
section is new.
Change-Id: I0c307a067490c06728b5adf70c91586254e337da
Needed-by: https://review.openstack.org/565782
"List images" had been taken by the v1 API, but now that its
api reference has been removed, that's no longer a problem.
Can also remove the superfluous "an"s that were used in the
v2 titles to prevent sphinx conflicts.
Co-authored-by: Ha Van Tu <tuhv@vn.fujitsu.com>
Co-authored-by: Brian Rosmaita <rosmaita.fossdev@gmail.com>
Change-Id: I2c1ce3f5c1279a93a08855c554e156c4fc115f61
Closes-Bug: #1615899
Follow docs[1] and update the sphinx theme configuration,
Also updated bug_tag values for api-ref and documentation.
[1] https://docs.openstack.org/openstackdocstheme/latest/
Co-authored-by: wanghui <wang_hui@inspur.com>
Closes-bug: #1768365
Change-Id: I76308497122f4522fe307b3c29b696780e073027
Adds .htaccess containing redirects so old URLs can retrieve
the correct document from the docs reorganization introduced
with commit 1c7f556d4f77d2dd7f282f2b41bdfb2abb6e5740.
Change-Id: I9678eedd5634ac04482f3f8b5ee0e4177cf985e3
Needed-by: https://review.openstack.org/564344
Partial-bug: #1766257
Now there is no way to revert the pending-delete images. Once the
admin operators want to revert the delete action, Glance should
give them this kind of ability.
This patch will enhance the glance-scrubber tool to support restoring
the image from pending-delete to active.
Change-Id: I11fe58403e3af102b63d15b3cc702e567e526bad
blueprint: pending-delete-rollback
While creating an image, image data stays in backend if image
signature verification fails.
After raising SignatureVerificationError exception, image status is
being set to 'killed' in DB but the image data remains as it is in
the backend.
Adding delete_from_backend() call to cleanup the data from backend when
Singature Verification fails.
Closes-Bug: #1736336
Change-Id: I2a1a7addd33050cc8845aec24479aa4d1bc26ca0
Because the Image API is removed in Rocky, its API Reference has
been deleted. Add information about why it's gone and how to build
it to the current API Reference.
Closes-bug: #1762387
Change-Id: Ic215e7367b49df1ac837a4a1fa56effa7d9f7a61
Requirement for package eventlet has an exclusion not found in
the global list: set(['<0.21.0', '!=0.20.1', '!=0.18.3'])
vs. set(['!=0.20.1', '!=0.18.3'])
Change-Id: Ieb6f40efde78fc0df42c395f0ed650df5b2d0f77
A lot of keystoneclient has been long deprecated and is slated
for removal. This change removes two usages of keystoneclient
and replaces them with similar functionality in keystoneauth.
Change-Id: I0128a7bb42b0d691600fdd03aac287633c8b2451
This follows changes in Nova and Cinder to add a logging fixture that
allows the log level to be raised to limit the amount of junk output
in the unit test logs, while still processing debug level logs to
catch formatting error issues.
Change-Id: If740108db5291ff3fe0963127f9a3efadf3346c3
Option auth_uri from group keystone_authtoken is deprecated[1].
Use option www_authenticate_uri from group keystone_authtoken.
[1]https://review.openstack.org/#/c/508522/
Change-Id: I1de0272fb7c20b8efa710d984ff8196c41b30b6b
The Glance install guide suggests using 'default' as the
user_domain_name and project_domain_name, whereas the Keystone
install guide, which people would be consulting earlier, instructs
the installer to use 'Default'. Since the name is case-sensitive,
this is causing problems for first-time installers of OpenStack.
Change-Id: Iade47bcd69b7a2a99b990885a0270c962de282a1
Closes-bug: #1747181
Updates the schemas/image(s) responses and the api-ref. (The dev
docs are correct.) Adds a test so this won't happen again.
Closes-bug: #1762031
Change-Id: Ifb0a07fcdb1c8d91f1ad700329a208200222a2a6
Added new functional tests for glance-direct and web-download
import methods of new Image Import API.
Closes-Bug: #1761544
Change-Id: I2687d2524221c6ad0f6c233ac949bc2383c0fd7a
Beginning with the Queens release, the keystone install guide
recommends running all interfaces on the same port. This patch
updates the glance install guide to reflect that change.
Closes-bug: #1754104
Change-Id: I6134097f4ec78bf34a03f3ce6d8564bd324eb1b3
Create a tox environment for running the unit tests against the lower
bounds of the dependencies.
Create a lower-constraints.txt to be used to enforce the lower bounds
in those tests.
Add openstack-tox-lower-constraints job to the zuul configuration.
See http://lists.openstack.org/pipermail/openstack-dev/2018-March/128352.html
for more details.
Change-Id: Ibd41a407f8f5f4eb2de1a44904fb7df5ab81e30c
Depends-On: https://review.openstack.org/555034
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
Web-download import method fails to import image to backend if
'node_staging_uri' is not set in glance-api.conf (or when the value
ends with a '/', as the default setting does) due to "local variable
'separator' referenced before assignment" error.
Co-authored-by: Abhishek Kekane <akekane@redhat.com>
Co-authored-by: Brian Rosmaita <rosmaita.fossdev@gmail.com>
Change-Id: I056fb7a1f7a7ef6bc14ea54133cf083b2b9d9920
Closes-Bug: #1753964
The Glance unit and functional tests were split out by change
I93d7216340bef70fc18fc9943da5c740ba3d4761. (Previously Glance had
only 'py27' and 'py35' tox testenvs that handled both unit and
functional tests.) That change made it easier to run the faster
unit tests separately during development, but made it so that simply
running 'tox' locally no longer ran all relevant tests. This change
modifies tox.ini so that running tox with the defaults will run all
unit and functional tests. The tests continue to be run separately
in gate/check jobs.
Change-Id: I6745ebfc0ca7e8b59dc4abf63b3d6dad1fde76fd
Per [1], eventlet monkey patching should happen as early as
possible to avoid mismatches where a module was imported both before
and after it was monkey patched. This is an exception to the import
order rules that should maybe be more explicitly called out.
In addition, partial monkey patching can be a problem, as shown in
the discussion of the thread module from the same document. This
seems to be contributing to the doc build problems that are
occurring with the latest version of openstackdocstheme, so the
partial monkey patching is also removed in favor of full patching.
Change-Id: I0d2d9fb9f0b9d747ad1d955420f6ad129ebbfbcf
1: http://specs.openstack.org/openstack/openstack-specs/specs/eventlet-best-practices.html#monkey-patching
Closes-Bug: 1759935
Newly added image import api fails for python 3.5 as it
raises Unicode error as it fails to open file in binary mode.
Added 'rb' mode while opening the file which will open the provided
file in binary mode.
Change-Id: I297a415d6fa8700c6a131e0931d11bda65265c73
Closes-Bug: #1759510