tl;dr : without this Ocata and Pike have the same version causing
packaging issues.
https://docs.openstack.org/developer/pbr/#version
Because projects don't push a tag before milestone 1 (pike-1 here),
downstream packages are still building packages by using the version
from Ocata and it causes problems to distros because they can't test
the upgrades from Ocata to Pike.
Bumping the semver will allow us to test packages upgrades.
Note: When your version is X.Y.Z, api-break will bump X, and feature
will bump Y. In this patch, we bump X because this is the way you
bump tags over releases.
Change-Id: I406a50cd8605985ed261df2885fb6d52e4b393b1
Sem-Ver: api-break
Previously, ResourceGroup._needs_update() would raise UpdateReplace
when the ResourceGroup was in CHECK_FAILED status, resulting in
delete/replacement of every resource in the group. Now, it will
return True so that only resources in the CHECK_FAILED status.
Change-Id: I800c4f58feec7c1aaa4897c2ba056e5a74200e5d
Closes-Bug: #1671592
In ced6f78aa065c1a7e6400c3be9ec3322e1e87416 we stopped doing validations of
nested stacks at stack creation time, on the assumption that they had been
validated when the parent stack was created. This assumption was incorrect;
for children of the stack being created, the strict_validate global is
always set during validation, so property values of resources will not be
validated until it comes time to create the resource.
Instead, prevent only redundant non-strict validations of stacks at nested
depth 2 and greater. This means that every stack other than the root will
be validated exactly twice - once without validating property values when
the root is created, and again including property validation when the
nested stack itself is created.
Most of the performance benefits should remain; in the case of a large
ResourceGroup using index substitution, we will now have to validate a lot
of nearly-identical resource properties, however we still will not load
into memory and validate a nested stack for each one as we originally did.
Since that happens synchronously, it was likely the main contributor to RPC
timeouts when dealing with large scaling groups. (During the validation at
the creation of the root stack, only a single member of a ResourceGroup is
validated even when index substitution is used. For scaling groups with
identical members, only one member is validated since
3aebdabf2e78ac9e920b9dd8c748c4fad0d723c3.)
This change reverts commit ced6f78aa065c1a7e6400c3be9ec3322e1e87416.
Change-Id: I97cf789cee75931edef58b78c88f02da204d2a08
Closes-Bug: #1675589
Related-Bug: #1645336
Make sure only to delete internal ports when user
wants to detach them, and just do detach for
external ports.
Change-Id: I09e686d4e1603c6a8b388772eee900f06b1e775d
Closes-Bug: #1676821
pydoc is part of the standard library and is much more robust at formatting
docstings than any trivial hand-rolled munger could be. For example, it
correctly preserves indentation within the docstring. Use it when
generating descriptions from docstrings for the API.
Change-Id: Ib565a64d990a45c652a9475255c37805f86070b4
The delete_stack() RPC call in the client can be sent using either call()
or cast(), with cast() the default. This is never what you want, because
the call could raise an exception and you want to hear about that.
We're now passing cast=False explicitly everywhere. We always were in
heat-cfn-api and heat-api, but failing to do so in StackResource caused bug
1499669, which was corrected by I039eb8f6c6a262653c1e9edc8173e5680d81e31b.
Changing the default to call() will prevent anyone making that same mistake
again.
Change-Id: Idd6a27988dadbf1cd8376de24b19f2226f6ae5b7
Related-Bug: #1499669
When deleting a software deployment, remove the deployment from the server
first (by deleting the derived config) and only *then* delete the user
credentials that the server might use to signal back to Heat. This reduces
the chance of something failing that leaves things at a point where revoked
credentials on an old deployment are blocking os-collect-config.
Change-Id: If5fe38033a8a402b07266b1c2d4b627efff85d6b