This issue was due to Nova changes it's volume attach workflow
(https://review.openstack.org/#/c/330285) which allows `reserved`
status.
Closes-Bug: #1737343
Change-Id: I13f1906f53a89586bb51c0b70fa768a9500dfa26
When we consolidated resource locking with resource state transitions in
a7376f7494b310e9367ebe5dcb43b432a4053023, prepare_update_replace() moved
outside of the locked section, so that other update operations could
potentially conflict with it. This change ensures that we call it while the
lock is still held (if we have transitioned the resource to
UPDATE_IN_PROGRESS, and thus acquired the lock), or that we acquire the
lock before calling it (if UpdateReplace is raised before attempting to
update the resource).
To avoid unnecessary locking and unlocking, we only take the lock if the
Resource plugin has overridden the default handler method (either
restore_prev_rsrc() or prepare_for_replace()), since the defaults do
nothing.
Change-Id: Ie32836ed643e440143bde8b83aeb4d6159acd034
Closes-Bug: #1727127
The hostname of the build machine leaks in heat.conf in the host
directive, making the whole heat package not reproducible. If you don't
know about reproducibility, please read here:
https://wiki.debian.org/ReproducibleBuilds/About
This patch therefore sets sample_default to avoid this problem.
Change-Id: Ibfe81f89df75417eab7437817aabd69bfb2985cd
Closes-Bug: #1736761
Fix reset_stack_status on legacy, by using a different session for each
stack reset, and handling lock duplicate errors.
Closes-Bug: #1735755
Change-Id: I6bcd7448052e86ec3e4eb4c49ef3139c20d4f919
Now mitaka and newton already mark as EOL, so we should remove any
branch limit that relative to those branches.
Also since we have dependent zuul jobs for each branch, we remove
ocata branch limit from master.
Change-Id: Ide2ddbe4d50faa0356992b55d99c1b1af8a44a35
Allow use policy in code to resource type's rule.
Also add test for override the in-code resource type rule in json
file.
Partially-Implements: bp policy-in-code
Change-Id: Id6c21732e66de6c421427ded98de52f5da0a4db2
Allow use policy in code to stacks's rule.
Also convert check_is_admin to use new mechanism.
Partially-Implements: bp policy-in-code
Change-Id: I398ed162790294d0d4453f7f12c77b38e95a5580
When listing resources with nested depth, we get all resources
for the root stack and cache them in the context. By the time
we iterate through the resources for a nested stack, if the
current_template_id of resources do not match the stack template,
we try to load the template. However, it's possible that the
template does not exist anymore. It would be good to ignore
those resources.
Change-Id: I838320539838ed74f490bca8601cde96eaf7c7ee
Closes-Bug: #1734815
Change [1] removed SSLMiddleware from code but
missed removal of oslo-config namespace, this
patch cleans it up.
[1] https://review.openstack.org/#/c/506900/
Change-Id: Ibeeece25a13706e3ce0b58dbb9746090d881b909
Note: We still have to change grenade jobs to use
the plugin, before removing the plugin from tree.
Change-Id: Ie63f25e724ed3fbd42adcf5bb2d625c2fec67df1
Zuul now supports including the file extension on the playbook path
and omitting the extension is now deprecrated. Add `.yaml` back for
playbook path.
Change-Id: I4a2ae5f28740e41f5b77c05954e7ea4562016be9
Include the server ID in existing logs, and add additional logs that will
let us know when updates to software deployments have happened and whether
they have succeeded or not. This should save considerable time
investigating in the future if there's ever any question of whether a
deployment has gone missing in Heat itself or somewhere on the target
server.
Change-Id: I33d7aee5974d03b7e41beab9fef4ad643cb0c469