openstack/horizon
Code Issues Proposed changes

Merge "Add Validation msg in Create Extra Spec Form under Volume Type Panel"

Browse Source
This commit is contained in:
Zuul
2019-03-20 15:18:38 +00:00
committed by Gerrit Code Review
parent 8ecef3ba90 a85687cb7e
commit 002e9f19b7
2 changed files with 16 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
openstack_dashboard/dashboards/admin/volume_types/extras/forms.py
View File

@@ -34,6 +34,20 @@ class CreateExtraSpec(forms.SelfHandlingForm):
error_messages=KEY_ERROR_MESSAGES)
value = forms.CharField(max_length=255, label=_("Value"))
def clean(self):
data = super(CreateExtraSpec, self).clean()
type_id = self.initial['type_id']
extra_list = api.cinder.volume_type_extra_get(self.request,
type_id)
for extra in extra_list:
if extra.key.lower() == data['key'].lower():
error_msg = _('Key with name "%s" already exists. Use Edit to '
'update the value, else create key with '
'different name.') % data['key']
raise forms.ValidationError(error_msg)
return data
def handle(self, request, data):
type_id = self.initial['type_id']
try:

3
openstack_dashboard/dashboards/admin/volume_types/extras/tests.py
View File

@@ -54,7 +54,8 @@ class VolTypeExtrasTests(test.BaseAdminViewTests):
self.mock_volume_type_extra_get.assert_called_once_with(
test.IsHttpRequest(), vol_type.id)
@test.create_mocks({api.cinder: ('volume_type_extra_set', )})
@test.create_mocks({api.cinder: ('volume_type_extra_set',
'volume_type_extra_get')})
def test_extra_create_post(self):
vol_type = self.cinder_volume_types.first()
create_url = reverse(