openstack/horizon
Code Issues Proposed changes

Merge "fix(swift): allow object creation"

Browse Source
This commit is contained in:
Zuul
2023-03-23 22:53:38 +00:00
committed by Gerrit Code Review
parent c88583e33a a327842a25
commit 76650bbfa7
2 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
openstack_dashboard/static/app/core/openstack-service-api/swift.service.js
View File

@@ -296,8 +296,7 @@
service.getObjectURL(container, objectName, 'metadata')
);
if (ignoreError) {
// provide a noop error handler so the error is ignored
return promise.catch(angular.noop);
return promise;
}
return promise.catch(function onError() {
toastService.add('error', gettext('Unable to get details of the object.'));

1
openstack_dashboard/static/app/core/openstack-service-api/swift.service.spec.js
View File

@@ -256,7 +256,6 @@
spyOn(promise, 'catch');
spyOn(toastService, 'add');
service.getObjectDetails('spam', 'ham', true);
expect(promise.catch).toHaveBeenCalledWith(angular.noop);
expect(toastService.add).not.toHaveBeenCalled();
});