This patch forces the use of the en_US locale for tests run.
This is done to avoid tests failing due to message translation.
For example:
When asserting if the message of an exception is correct, those are
usually hardcoded in the tests.
Change-Id: Ia8068b454f1461f17994733afc57337f4b017460
Since we're running python 3.5 tests now, we should also be
running them when running all tests with just `tox`.
Change-Id: I3f57abcbeaa3550f49d56f08140a34d6989885c9
Collecting warning logs in the case of download failure
and write them to error logs in the end. This will help
a user to diagnose a problem when warning log was not
enabled.
Change-Id: I4198d7be08fc11b616b3f95c595ff53794436e24
Partial-Bug: 1512186
might be useful sometimes,
for example debugging in normal terminal is usually more pleasant
than in QEMU console.
Add env variables `ENABLE_SSH` and `SSH_PUBLIC_KEY`,
documentation is amended accordingly.
Change-Id: I71352c2087e1fb9a7174affb78fe695932a924d7
Use the namedtuple class to improve code readability by creating a Host
class with namedtuple to store the 'hostname' and 'port'
Replace foo[0] with foo.hostname, and foo[1] with foo.port to make code
more readable.
Change-Id: Ie2b5f9cf89e7ccbbcf0a2573dab6f6c5d14c018b
Following OpenStack Style Guidelines [1], I changed:
assertFalse(sth in sth) to assertNotIn(sth, sth).
After this change, a more specific message is shown on error.
[1]: http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises
Change-Id: I5d47d775dcff194693d97db6b797b7b027cbab56
Following OpenStack Style Guidelines[1]:
http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises
[H203] Unit test assertions tend to give better messages for more specific assertions.
As a result, assertIsNone(...) is preferred over assertEqual(None, ...)
Change-Id: I53c6d6d3e53d9fac38c50faf065c131d3aa55224
In noauth mode when running stable/mitaka, Ironic responds to the
initial lookup request with code 406, NOT_ACCEPTABLE, due to the client
supplied microversion of 1.22 by IPA.
As such, we should fallback upon receiving the 406 error code.
Related-Bug: #1616461
Change-Id: Ief9c151cf27a3c38c33a837bb7d6581868a3dc22
Currently, building ramdisks installs ironic-python-agent without any
upper-constraints. This causes the package to be installed with newer,
untested dependencies.
This commits introduces a tool to generate a local upper-constraints
file based on predefined strategies (below). Additionally, the fallback
to the openstack/requirements uses the URL defined in tox.ini instead of
redefining it. This prevents having to keep track of two separate
variables when releasing.
upper-constraints lookup strategies (in order):
* UPPER_CONSTRAINTS_FILE points to a local file
* UPPER_CONSTRAINTS_FILE points to a URL
* /opt/stack/new/requirements/upper-constraints.txt
* upper-constraints.txt from openstack/requirements git repository
Partial-bug: #1616554
Change-Id: Ib5c0c57cafdb6ffd7456e61f3b1bb5fa57520e5a
Re-initialization of the API client causes the identification
of an older ironic API to be forgotten.
As such, we need to re-use the API client from the initial lookup
for the heartbeat.
Tested with current master branch and stable/mitaka ipa
in noauth mode, and was able to deploy without any issues.
Closes-Bug: #1616461
Change-Id: I3ae1e2ce83f614b5b936a3cbb1b9587c6c55a89a
Update the hacking test-requirement to match openstack/requirements
global-requirements.txt
The hacking requirement is not updated by the proposal bot.
Change-Id: I6cfbaf55abad0c33cbcbe8063d873db717f5252e
This will make sure the socket list and the interface list are
always in sync, and the select call is on the right list of
sockets.
Co-Authored-By: Dmitry Tantsur <dtantsur@redhat.com>
Closes-Bug: #1533892
Change-Id: Id6710f4648203b7d476a2a16ea647224baca1bb9
The differences between 1010.6.0 and 1068.9.0 are published by the
CoreOS team [1] and are noted below.
1068.9.0
========
Security Updates:
* libcurl 7.50.1 for CVE-2016-5419, CVE-2016-5420, CVE-2016-5421,
CVE-2016-4802, CVE-2016-3739
1068.8.0
========
Security Updates:
* libpcre 8.38-r1 for CVE-2014-8964, CVE-2014-8964, CVE-2015-5073,
CVE-2015-5073, CVE-2015-5073, CVE-2015-8380, CVE-2015-8381,
CVE-2015-8383, CVE-2015-8384, CVE-2015-8385, CVE-2015-8386,
CVE-2015-8387, CVE-2015-8388, CVE-2015-8389, CVE-2015-8390,
CVE-2015-8391, CVE-2015-8392, CVE-2015-8393, CVE-2015-8394,
CVE-2015-8395, CVE-2016-1283, CVE-2016-1283
Bug Fixes:
* Properly escape systemd specifiers (#1459)
1068.6.0
========
Bug Fixes:
* Fix parsing of the user database which caused systemd-sysusers to crash (#1394)
* Fix handling of certain unicode characters in bash (#1411)
* Fix issue when starting transient services (#1430)
* Include work-around for empty SSH host keys (#106)
Changes:
* Removed Kubernetes kubelet
* The Stable channel has never contained a version which included the
kubelet. If an instance was booted from the Beta or Alpha channels
and then moved to the Stable channel, it will lose the kubelet when
it updates to this release.
* Set group for /dev/kvm
Updates:
* coreos-metadata v0.4.1
* bash 4.3_p46
[1] https://coreos.com/releases/
Change-Id: I00c2114aeea9d4c1b8e38f5786158f248875970d
Prior to this patch the ironic-python-agent service would only fallback
to use the old endpoints for /lookup and /heartbeat on a 404 error but,
since Ironic will check auth (if enabled) before it routes the requests
a 401 (Unauthorized) was returned.
Closes-Bug: #1612696
Change-Id: Idba5fed587e77aaa683d2c2b2126a520214712ce
This is a follow up to Ic08d4ff78b6fb614b474b956a32eac352a14262a.
It enhances an example, fixes a spelling error, and modifies some
sentences for better readability.
Change-Id: Icfc89edd426ddee6a93be40c5b2f56d9d78fbd0c
Falls back to vendor passthru on receiving 404.
Also fixes logging around lookup: log traceback on unexpected
exceptions, log successful lookup and replace % with ,
Change-Id: I7160c99ca63585fc333482fa578fdf5e0962b2b6
Depends-On: I9080c07b03103cd7a323e2fc01be821733b07eea
Partial-Bug: #1570841
This utilizes the new metrics support in ironic-lib to allow the agent to
report timing metrics for agent API methods as configured in ironic-lib.
Additionally, this adds developer docs on how to use metrics in IPA,
including some caveats specific to ironic-lib.metrics use in IPA.
Co-Authored-By: Jay Faulkner <jay@jvf.cc>
Co-Authored-By: Alex Weeks <alex.weeks@gmail.com>
Change-Id: Ic08d4ff78b6fb614b474b956a32eac352a14262a
Partial-bug: #1526219