openstack/ironic
Code Issues Proposed changes

Disabling test_upgrade_twice temporarily for CI fix

Browse Source 
This test has been taking an inordinate amount of time to complete. We
should figure out the root cause and fix it, but in the meantime it only
causes us harm to be unable to land patches.

Related-Bug: 2023316
Change-Id: I604369e000c80914cf0c584c9deab7245c66b1b4
This commit is contained in:
Jay Faulkner 2023-06-08 10:01:35 -07:00
parent ca5b2feeee
commit b4f8209b99
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
ironic/tests/unit/db/sqlalchemy/test_migrations.py
View File

@ -1339,13 +1339,16 @@ class MigrationCheckersMixin(object):
self.assertRaises(db_exc.DBMigrationError, self.assertRaises(db_exc.DBMigrationError,
self.migration_api.create_schema) self.migration_api.create_schema)
def test_upgrade_twice(self): # NOTE(JayF): bug2023316 means we need to disable this for now. We need
with patch_with_engine(self.engine): # to fix the hangs in this test then re-enable it as quickly
self.migration_api.upgrade('31baaf680d2b') # as possible
v1 = self.migration_api.version() # def test_upgrade_twice(self):
self.migration_api.upgrade('head') # with patch_with_engine(self.engine):
v2 = self.migration_api.version() # self.migration_api.upgrade('31baaf680d2b')
self.assertNotEqual(v1, v2) # v1 = self.migration_api.version()
# self.migration_api.upgrade('head')
# v2 = self.migration_api.version()
# self.assertNotEqual(v1, v2)
class TestMigrationsMySQL(MigrationCheckersMixin, class TestMigrationsMySQL(MigrationCheckersMixin,