openstack/ironic
Code Issues Proposed changes

Move execution of 'tools/check-releasenotes.py' to pep8

Browse Source 
The 'releasenotes' gate job does not run our tox section. This allowed a
releasenote to land that had a filename in an incorrect format because
it was not created with 'reno new'.

Move the running of 'tools/check-releasenotes.py' to the pep8 section
and whitelist the releasenote that got merged.

Change-Id: Id5bd8e0cbc9186c89f682224088a8f23998d59c3
This commit is contained in:
John L. Villalovos 2018-02-22 11:01:21 -08:00 committed by Ruby Loo
parent e68d1a71b1
commit fabcf1a402
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/check-releasenotes.py
View File

@ -25,6 +25,8 @@ RELEASE_NOTES_DIR = "releasenotes/notes/"
IGNORE_FILES = (
'releasenotes/notes/fix-get-deploy-info-port.yaml', # Newton 6.0.0
'releasenotes/notes/fix-mitaka-ipa-iscsi.yaml', # Newton 6.0.0
# Rocky, accidentally got in
'releasenotes/notes/add-id-and-uuid-filtering-to-sqalchemy-api.yaml',
)

3
tox.ini
View File

@ -36,6 +36,8 @@ commands =
{toxinidir}/tools/run_bashate.sh {toxinidir}
# Check the *.rst files
doc8 README.rst CONTRIBUTING.rst doc/source --ignore D001
# Check to make sure reno releasenotes created with 'reno new'
{toxinidir}/tools/check-releasenotes.py
[testenv:cover]
setenv = VIRTUAL_ENV={envdir}
@ -88,7 +90,6 @@ commands =
[testenv:releasenotes]
commands =
{toxinidir}/tools/check-releasenotes.py
sphinx-build -a -E -W -d releasenotes/build/doctrees -b html releasenotes/source releasenotes/build/html
[testenv:venv]