11308 Commits

Author SHA1 Message Date
Zuul
4c30827f2d Merge "Wipe agent tokens on inspection start and abort" 2021-04-20 19:32:36 +00:00
Zuul
0af9a9fdf8 Merge "Read default cirros version from stackrc" 2021-04-20 16:00:26 +00:00
Zuul
f184a0f0d0 Merge "Update to not use deprecated get_task_monitor." 2021-04-20 15:44:47 +00:00
Riccardo Pittau
df368cbd8a Read default cirros version from stackrc
Workaround for grenade jobs to read CIRROS_VERSION variable from
stackrc.
We also give the possibility to specify a custom CIRROS_VERSION

In addition, fix transient iDRAC WS-Man BIOS test.

Depends-On: https://review.opendev.org/c/openstack/ironic/+/786387

Change-Id: Ic7f5dae5e6aa6916f0a7d73f43cc9552349385c5
2021-04-19 13:47:10 -04:00
Zuul
b4d8a493d9 Merge "Fix idrac-wsman BIOS factory_reset result finding" 2021-04-08 16:20:46 +00:00
Aija Jauntēva
233a8d2c42 Update to not use deprecated get_task_monitor.
`update_service.get_task_monitor` is deprecated, using
top level `get_task_monitor` instead.

Change-Id: Ib028313ee14744a2c016ebaa463e6bfc3a4cc5f0
2021-04-08 10:55:11 -04:00
Dmitry Tantsur
c6e8281f85 Wipe agent tokens on inspection start and abort
Also make sure the pregenerated flag is always reset.

Change-Id: I73aaa803d3eb84ddac59a778e998836a645217eb
2021-04-08 13:42:25 +02:00
Zuul
4d79021513 Merge "Fix typo in security docs around is_admin rule" 2021-04-08 07:52:16 +00:00
Zuul
d2e7f36949 Merge "Add security dashboard clean steps to ilo drivers" 2021-04-07 13:57:59 +00:00
Zuul
e97e6eb660 Merge "Update python-dracclient version" 2021-04-07 12:03:45 +00:00
Yogesh Ramachandra
82627acadc Fix idrac-wsman BIOS factory_reset result finding
This change fixes the idrac-wsman BIOS hardware interface
implementation's determination of the result of its factory_reset
cleaning/deploy step, and, on success, updating of the cached BIOS
settings to their defaults. It uses a deterministic means of identifying
when the reset has successfully completed and the default BIOS settings
are available to be read.

The time when the iDRAC last performed a system inventory is referred to
as Collect System Inventory on Restart (CSIOR). CSIOR updates the values
of BIOS settings that can be read from the iDRAC. The interface reads
the CSIOR and records it on the ironic bare metal node before requesting
the factory reset and rebooting the system to process the request.
Following the system reboot, the CSIOR is periodically read until its
value changes from its recorded value. If that occurs before the
configured amount of time has passed, the step succeeds and the cached
BIOS settings are updated. Otherwise, the step fails and the node is
placed in the failed state.

Story: 2008058
Task: 40739
Depends-On: https://review.opendev.org/c/openstack/python-dracclient/+/748571
Change-Id: I11b92612d6686b7133ddef67068664c9b81df30e
2021-04-06 23:56:35 -04:00
Richard Pioso
90d21edbfd Update python-dracclient version
Update python-dracclient version to indicate Wallaby compatibility with
6.*.* releases.

Version 6.0.0 is available from PyPI [1].

[1] https://pypi.org/project/python-dracclient/6.0.0/

Change-Id: Ia7093a3ed48e19197f74da9e1c49416a974a76be
2021-04-06 12:48:40 -04:00
Zuul
bc028e0b65 Merge "Followup idrac configuration mold steps" 2021-04-05 22:36:17 +00:00
ankit
f5413a9bd5 Add security dashboard clean steps to ilo drivers
This commit adds new clean steps security_parameters_update,
update_minimum_password_length and update_auth_failure_logging_threshold
to allow users to edit following security parameters which fetched
during node inspection -
``Password_Complexity``, ``RequiredLoginForiLORBSU``,
``RequireHostAuthentication``, ``MinPasswordLength``,
``IPMI/DCMI_Over_LAN``, ``Authentication_failure_Logging``,
and ``Secure_Boot``.

Story: 2008024
Task: 40736
Change-Id: I0dd9a83ee23c6b846eda3ff171ab7b3138b22fa7
2021-04-05 17:53:28 +00:00
OpenStack Proposal Bot
0a417f52e6 Imported Translations from Zanata
For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: Ie9a1b59bf7c070fe69c9d3a20d4d972364eb527c
2021-04-05 06:48:35 +00:00
Julia Kreger
c6b8ee6667 Update release note version header for wallaby
Change-Id: Ib52d0a1e1944e657b1b0be38d433717493cdc401
2021-04-01 10:21:53 -07:00
Zuul
af0e5ee096 Merge "Add Python3 xena unit tests" 2021-04-01 13:05:07 +00:00
Zuul
a4f087a27a Merge "Update master for stable/wallaby" 2021-04-01 10:24:19 +00:00
Zuul
3b2d15394e Merge "Follow-up Automaticaly set cipher suite" 2021-04-01 10:08:40 +00:00
94bd4c8e37 Add Python3 xena unit tests
This is an automatically generated patch to ensure unit testing
is in place for all the of the tested runtimes for xena.

See also the PTI in governance [1].

[1]: https://governance.openstack.org/tc/reference/project-testing-interface.html

Change-Id: I24a4b8fd3d7c086b79875a2d0dd5f2399357d988
2021-04-01 09:12:27 +00:00
dd56a20b6b Update master for stable/wallaby
Add file to the reno documentation build to show release notes for
stable/wallaby.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/wallaby.

Sem-Ver: feature
Change-Id: I87ce46bfcca8b023ef26cf0cdc807de6956fb2b3
2021-04-01 09:12:21 +00:00
Aija Jauntēva
ae30139af2 Followup idrac configuration mold steps
Followup to change: I10dbc30614d8654dda540ffaa5e61e7a9f03c7b3

Change-Id: Ie7cb2c831854be288553dc634d5367739519e0e1
2021-04-01 03:16:41 -04:00
Zuul
31d93dccdc Merge "Restrict syncing of boot mode to Supermicro" 2021-04-01 07:12:46 +00:00
Zuul
5249646f64 Merge "Add agent_status and agent_status_message params to heartbeat" 2021-04-01 07:09:33 +00:00
Arun S A G
288b8fd883 Add agent_status and agent_status_message params to heartbeat
agent_status is used by anaconda ramdisk to inform the
conductor about state of the deployment. Valid agent
states are 'start', 'end' and 'error'. The agent_status_message
is used to describe the why the agent_status is set to a
particular state. Use of these parameters require API
version 1.72 or greater.

When anaconda finishes deployment the agent_status is
set to 'end'. When anaconda ramdisk is unable to deploy
the OS for some reason the agent_status is set to 'error'.

PXEAnacondaDeploy is implemented to handle the 'anaconda'
deploy interface. PXEAnacondaDeploy ties to together pieces
needed to deploy a node using anaconda ramdisk.

Co-Authored-By: Jay Faulkner <jay@jvf.cc>
Change-Id: Ieb452149730510b001c4712bbb2e0f28acfc3c2e
2021-03-31 14:20:39 -07:00
Bob Fournier
8bd25a9882 Restrict syncing of boot mode to Supermicro
The fix for https://storyboard.openstack.org/#!/story/2008252 synced
the boot mode after changing the boot device, because Supermicro nodes
reset the boot mode if not included in the boot device set. However this
can cause a problem on Dell nodes when changing the mode uefi->bios or
bios->uefi. Restrict the syncing of the boot mode to Supermicro.

Story: 2008712
Task: 42046
Change-Id: I9f305cb3f33766c1c93cf4347368b1ce025fc635
2021-03-31 15:02:57 -04:00
Zuul
e215f7a180 Merge "Fix Bandit check" 2021-03-31 18:41:42 +00:00
Zuul
a7988cb416 Merge "Add iDRAC management via Redfish to idrac HW type" 2021-03-31 17:52:39 +00:00
Iury Gregory Melo Ferreira
a036728fb4 Follow-up Automaticaly set cipher suite
This commit is a follow-up to  I6788585a83268e20ff6447e570995871bc9c25d5

Change-Id: I658b6b4eca7978473b08244c349ea5ac8bf37f76
2021-03-31 18:35:45 +02:00
Zuul
c9f9c2ca9b Merge "Generic way to configure clean step priorites" 2021-03-31 16:30:19 +00:00
DhuldevValekar3
601f6d51f6 Add iDRAC management via Redfish to idrac HW type
This change adds support for managing an iDRAC -- reset, clear job
queue, and reset to known good state -- via the Redfish out-of-band
(OOB) management protocol to the idrac hardware type. This is offered by
new idrac-redfish management hardware interface implementation cleaning
steps: reset_idrac, clear_job_queue, and known_good_state.
known_good_state both resets an iDRAC and clears its job queue.

Story: 2007617
Task: 39628
Depends-On: https://review.opendev.org/c/x/sushy-oem-idrac/+/782254

Change-Id: Iad69c8d7cf3a373f5cfcc619a479a106efa2e4d4
2021-03-31 09:13:59 -04:00
Zuul
ff4c370d4b Merge "Add import, export configuration to idrac-redfish" 2021-03-31 11:53:03 +00:00
Zuul
4e8a3fdc29 Merge "Fix configuration generation for ironic doc pages" 2021-03-31 05:36:31 +00:00
Zuul
c2ac96458a Merge "Always add 'boot_method' vmedia in redfish/ilo vmedia boot" 2021-03-31 05:19:48 +00:00
Jacob Anders
1523ae1ce4 Generic way to configure clean step priorites
This change adds a generic method of configuring clean step
priorities instead of making changes in Ironic code every time a new
clean step is introduced.

Change-Id: I56b9a878724d27af2ac05232a1680017de4d8df5
Story: 1618014
2021-03-31 14:11:49 +10:00
Jason Anderson
7813fe8888
Fix typo in security docs around is_admin rule
The security docs give an example of how to enable admins to show
passwords via the API, but the policy guidance is wrong. There is no
"is_admin" _role_, it is instead a _rule_.

Change-Id: Ic14ebc04f01bece1460f6244ec2dd88c8dd00b0e
2021-03-30 14:56:52 -05:00
Zuul
34b2183862 Merge "[doc] Warning about out-of-sync ESPs for UEFI software RAID" 2021-03-29 23:38:19 +00:00
Julia Kreger
12d1dd5309 Fix configuration generation for ironic doc pages
Ironic's sample configuration page previously did not render any
of the items in the default section, except for those items added
by other libraries. This was because we were trying to use an iterator
instead of a list.

Using an iterator, in theory should have worked, and did work for
normal invocations, but didn't work when it came to sphinx generated
output.

Instead of trying to use itertools to assemble everything, we just
now instead assemble the list and use a list_opts method like some
of the other more complex groups to add values.

Confirmed in local build output that the sphinx generated output
works as expected now.

Change-Id: I7f1cffb2a91728ab632ab0ccaa6acbb7e86fb533
2021-03-29 15:56:51 -07:00
Julia Kreger
4afbf74798 Fix Bandit check
Bandit has started to fail on master.

 >> Issue: [B701:jinja2_autoescape_false] Using jinja2 templates with autoescape=False is dangerous and can lead to XSS. Ensure autoescape=True or use the select_autoescape function to mitigate XSS vulnerabilities.
    Severity: High   Confidence: Medium
    Location: ironic/common/utils.py:491
    More Info: https://bandit.readthedocs.io/en/latest/plugins/b701_jinja2_autoescape_false.html
 489	    # NOTE(pas-ha) not using default_for_string=False as we set the name
 490	    # of the template above for strings too.
 491	    env = jinja2.Environment(
 492	        loader=loader,
 493	        autoescape=jinja2.select_autoescape(),
 494	        undefined=jinja2.StrictUndefined if strict else jinja2.Undefined
 495	    )

It appears that Arun changed this around a little in
https://review.opendev.org/c/openstack/ironic/+/777448/10/ironic/common/utils.py
however this doesn't seem to pass reliably. As such, I'm returning
the notation of the label to the first line as it was before, which
seems to consistently pass bandit checking.

Change-Id: I7f5b7323b108b303b5b77609d5903128d4adca3c
2021-03-29 14:45:56 -07:00
Julia Kreger
4bd1c40bdc Always add 'boot_method' vmedia in redfish/ilo vmedia boot
The inclusion of a boot_method=vmedia kernel command line
argument is mandatory singnaling so IPA understands it has
been booted via virtual media, and to act accordingly.

Change-Id: I92751a3f4305fe0ded9ff379643b45132fe66157
Story: 2008749
Task: 42181
2021-03-29 10:41:47 -07:00
Zuul
b748ff6529 Merge "Fix webserver_verify_ca config documentation" 2021-03-29 17:25:50 +00:00
Zuul
d80a6b2651 Merge "Fix idrac-wsman BIOS step async error handling" 2021-03-29 17:25:26 +00:00
Aija Jauntēva
457d0cd70b Add import, export configuration to idrac-redfish
Introduces import_configuration, export_configuration
and import_export_configuration steps.

Currently as MVP supports OEM section only.

Story: 2003594
Task: 40622

Depends-On: https://review.opendev.org/#/c/759425/

Change-Id: I10dbc30614d8654dda540ffaa5e61e7a9f03c7b3
2021-03-29 12:33:10 -04:00
Zuul
851aac397e Merge "Allow using per-site network_data schema" 2021-03-29 16:09:49 +00:00
Zuul
065bc617fd Merge "Allow running RAID cleaning steps with in-band cleaning" 2021-03-29 16:09:35 +00:00
Zuul
cd75c7dc70 Merge "Move configuration mold utilities" 2021-03-29 15:44:44 +00:00
Zuul
1caaa0c507 Merge "Validate the kickstart template and file before use" 2021-03-29 15:13:31 +00:00
Aija Jauntēva
d913ef6396 Move configuration mold utilities
Utilities moved to ironic.common.molds.
New config section [molds] created and settings moved there.

Change-Id: I1177f7dd5d5157bb3a5c0bd09acd75c9a394ab47
2021-03-29 07:42:53 -04:00
Zuul
356734aaca Merge "Automaticaly set cipher suite" 2021-03-29 10:51:18 +00:00
Zuul
6fe8e6beb8 Merge "DRAC : idrac-redfish inspect updates pxe port" 2021-03-29 10:07:21 +00:00