13311 Commits

Author SHA1 Message Date
Zuul
f76b006b3f Merge "Add support for node name in port creation" 2024-10-24 18:18:56 +00:00
cid
da002a341c Add support for node name in port creation
Add support for creating ports using either node UUID or node name.

Closes-Bug: #1439901
Change-Id: I215619648bbe7aa1152e0f117971bece74ffe1fe
2024-10-23 11:43:10 +01:00
Zuul
1f740c8a90 Merge "docs: Updates redfish metrics docs with required configuration file settings" 2024-10-22 18:49:03 +00:00
Zuul
100f9b6829 Merge "Enable GLOBAL_VENV in ironic grenade jobs" 2024-10-22 18:48:58 +00:00
Zuul
fd51cead30 Merge "Added Localdev Docs on changing microversion" 2024-10-21 23:28:19 +00:00
Sharpz7
823a7c93bd Added Localdev Docs on changing microversion
Added some documentaition that details how to change the ironic localdev microversion for testing purposes.

Rendered View: https://files.mcaq.me/944ch.png

Change-Id: I1e21a12ad1413046a41f856ddf229e399f82523a
2024-10-21 22:27:01 +00:00
Ghanshyam Mann
7b807eff73 Enable GLOBAL_VENV in ironic grenade jobs
grenade by default enable GLOBAL_VENV which means it
install and run everything from virtual env

- https://review.opendev.org/c/openstack/grenade/+/930507

We faced the error in ironic grenade scripts in virtual env
so GLOBAL_VENV was disabled explicitly. This fixing the scripts
and enable GLOBAL_VENV in ironic jobs also.

Change-Id: I48ee1dd4adc2e5bcc18c5f116d979e7524248495
2024-10-17 14:48:11 -07:00
Zuul
45ee7dc365 Merge "CI: Add a 4k disk CI job" 2024-10-17 15:37:45 +00:00
Zuul
69a788ab55 Merge "devstack: Remove IRONIC_USE_WSGI" 2024-10-17 14:07:58 +00:00
Zuul
0d07ad03d8 Merge "devstack: Remove IRONIC_USE_MOD_WSGI" 2024-10-17 13:28:13 +00:00
Nicholas Kuechler
ae4d5b5c49 docs: Updates redfish metrics docs with required configuration file settings
Change-Id: Ide7c245e017a92519e17ed1fb62c7fc986a1ae6a
2024-10-16 15:29:37 -05:00
Stephen Finucane
05ccd2c323 devstack: Remove IRONIC_USE_WSGI
No jobs are setting this, nor have any set it in some time. Remove it.

Change-Id: I38a092de125e382607d89d8e5a3b85db809a6d61
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-10-16 11:48:06 +01:00
Stephen Finucane
fd9e8b9455 devstack: Remove IRONIC_USE_MOD_WSGI
Nothing is setting this anymore, making this a layer of indirection
we do not need. Remove it.

Change-Id: Iba3674536ee98ba4d2d0cb5ffb0ec52e5286b7e7
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2024-10-16 11:16:49 +01:00
Ghanshyam Mann
5f58cbf22d Continue disable the GLOBAL_VENV in grenade job
Grenade is moving to virtual env by default
- https://review.opendev.org/c/openstack/grenade/+/930507

and ironic job is failing on virtual env
- https://zuul.opendev.org/t/openstack/build/f5c4aa3dd64047a1909c4a964ad89aa8/log/controller/logs/grenade.sh_log.txt#15028

Until ironic greande job is ready for virtual env,
let's continue disable it in ironic side.

Change-Id: Ia76054c7b977dd17778dc4c89e8e212ab22f51af
2024-10-15 22:02:35 -07:00
Zuul
c80b8bfdb2 Merge "Reject explicit requests to power off nodes with disable_power_off" 2024-10-14 14:36:00 +00:00
Zuul
6e078cdb6b Merge "Add disable_power_off field to the node model" 2024-10-11 21:26:21 +00:00
Zuul
a47cb572d6 Merge "docs: Add context around asynchronous device initialization" 2024-10-09 15:37:01 +00:00
Zuul
181d721057 Merge "Fix actual size calculation for storage fallback logic" 2024-10-08 15:53:56 +00:00
Zuul
fca4843295 Merge "Add timeout to SERVICEWAIT" 2024-10-08 15:53:54 +00:00
Julia Kreger
ac31720ac1
docs: Add context around asynchronous device initialization
Centos Stream and ultimately RHEL have switched to asynchronous
device initialization, which impacts root device hints and their
usability on those systems, in large part because context which
people have traditionally had, no longer holds true on those newer
kernels.

This doc update attempts to provide the needful context to guide
operators to the best possible outcome given the distribution changes.

Change-Id: I541086cfe235b10f1f1dba95fad95022a22f9ce7
2024-10-07 07:13:26 -05:00
Takashi Kajinami
1f5798bced Use oslo.utils implementation to parse server address
... so that the address can be properly parsed even when IPv6 address
is used.

Change-Id: Ic3e043e9272518f73252ea9a8f0524ed092204b9
2024-10-06 00:58:41 +09:00
Zuul
462f86889b Merge "Checksum files before raw conversion" 2024-10-03 17:58:06 +00:00
Julia Kreger
00c5e0faf8 Checksum files before raw conversion
While working another issue, we discovered that support added to
the ironic-conductor process combined the image_download_source
option of "local" with the "force_raw" option resulted in a case
where Ironic had no concept to checksum the files *before* the
conductor process triggered an image format conversion and
then records new checksum values.

In essence, this opened the user requested image file to be
suspetible to a theoretical man-in-the-middle attack OR
the remote server replacing the content with an unknown file,
such as a new major version.

The is at odds with Ironic's security model where we do want to
ensure the end user of ironic is asserting a known checksum for
the image artifact they are deploying, so they are aware of the
present state. Due to the risk, we chose to raise this as a CVE,
as infrastructure operators should likely apply this patch.

As a note, if your *not* forcing all images to be raw format
through the conductor, then this issue is likely not a major
issue for you, but you should still apply the patch.

This is being tracked as CVE-2024-47211.

Closes-Bug: 2076289
Change-Id: Id6185b317aa6e4f4363ee49f77e688701995323a
Signed-off-by: Julia Kreger <juliaashleykreger@gmail.com>
2024-10-03 15:06:07 +00:00
Julia Kreger
90f9fa3eb0 Fix actual size calculation for storage fallback logic
When we were fixing the qemu-img related CVE, in our rush we didn't
realize that the logic for storage sizing, which only falls back to
actual size didn't match the prior interface exactly. Instead of
disk_size, we have actual_size on the format inspector.

This was not discovered because all of the code handling that side
of the unit tests were mocked.

Anyhow, easy fix.

Closes-Bug: 2083520
Change-Id: Ic4390d578f564f245d7fb4013f2ba5531aee9ea9
2024-10-03 06:53:30 -07:00
Julia Kreger
0d7fd73919 CI: Add a 4k disk CI job
Add a CI job to leverage a 4k logical block disk image which is
deployed to the remote system to ensure the build pipeline and
code to naviate 4k disk images is in working order.

Change-Id: If7aee654f9282b33ea489558f45f45cfed86e9d1
2024-10-02 14:25:19 -07:00
OpenStack Proposal Bot
083ea91abf Imported Translations from Zanata
For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: I9f3d07f56e24d359e8e9055faf4613af3ce41c0f
2024-10-02 04:09:53 +00:00
Dmitry Tantsur
f92258e767
Reject explicit requests to power off nodes with disable_power_off
Checks are added to three places:
1) Power state change API
2) Power sync loop in the conductor
3) The common node_power_action call

Partial-Bug: #2077432
Change-Id: Ifcc539b32022870bf8e96aa17fdeb2d111d2a393
2024-09-27 16:43:37 +02:00
Zuul
be33fcf38b Merge "Drop logic for pysnmp < 5" 2024-09-27 13:05:38 +00:00
Dmitry Tantsur
b1e38a45c4
Add disable_power_off field to the node model
No actual logic behind it and not exposed in the API yet.

Partial-Bug: #2077432
Change-Id: Ibf1f51ab4fc62c081bbaf487aa31018d340e45e8
2024-09-27 13:47:35 +02:00
Zuul
e25cff9621 Merge "Firmware Update via Firmware Interface Docs" 2024-09-27 09:02:52 +00:00
Zuul
6f6ae12948 Merge "doc: Promote built-in introspection from experimental" 2024-09-27 09:02:49 +00:00
Zuul
b430d3ed67 Merge "[doc] Add instructions on making big fake-BM nodes" 2024-09-27 09:02:47 +00:00
Zuul
bae9c25a75 Merge "CI: Enable the ability to have test VMs with different block sizes" 2024-09-27 09:02:44 +00:00
OpenStack Proposal Bot
aac5fa28e6 Imported Translations from Zanata
For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: Ie2be0e7ccb1e881c2a2a6b46fd9f83d565d9bf7d
2024-09-27 03:28:43 +00:00
Takashi Kajinami
46f1962ea1 Drop logic for pysnmp < 5
According to the driver-requirements.txt, nironic requires pysnmp >= 5
now, so this logic is just useless.

Change-Id: Iea843689ebf04fa0539c0ff2c783c18131646dff
2024-09-27 11:36:30 +09:00
Julia Kreger
6f1c603b5b CI: Enable the ability to have test VMs with different block sizes
Recently we became aware that some operators might need a larger
block size, but our CI testing doesn't represent any ability to
assert a different block size.

We can now assert a block size override in the scripting which
allows us to create a CI job.

Change-Id: I8470fb5b2827226dc155938a94c3a2cbe98912b5
2024-09-26 15:21:46 -07:00
Zuul
9550eca761 Merge "Refactoring: get rid of AgentDeployMixin" 2024-09-25 11:03:14 +00:00
Zuul
c8b5619714 Merge "Fix double transition to INSPECTFAIL on aborting in-band inspection" 2024-09-25 10:45:18 +00:00
Dmitry Tantsur
1a0de72470
Add timeout to SERVICEWAIT
Change-Id: I11ae8fc3273107b9e6713166fb077f00e2dcef7e
2024-09-25 11:51:04 +02:00
Zuul
05cc53f0df Merge "Move the benchmark job to the experimental pipeline" 2024-09-24 23:14:58 +00:00
Zuul
9fe510a14a Merge "Fix inspect interface for redfish driver in the docs" 2024-09-24 12:49:08 +00:00
Iury Gregory Melo Ferreira
82b67aa36c Firmware Update via Firmware Interface Docs
This patch adds some initial documentation
for the update step available via
the redfish firmware interface.

Change-Id: I4a70e2e78d725fd96a2ddd116c6d6e0d9c3b9639
2024-09-24 08:12:16 -03:00
Mahnoor Asghar
adfb091695 Fix inspect interface for redfish driver in the docs
Change-Id: If8d833bc5b012a17588aa7e3ebcb143bba12de12
2024-09-24 07:08:18 -04:00
Dmitry Tantsur
8a6b5eb8c3
Fix double transition to INSPECTFAIL on aborting in-band inspection
Both the driver and the conductor code try to transition the node to
INSPECTFAIL, with the 2nd attempt failing. Rework the driver code to
only do implementation-specific clean-up. Also safeguard the conductor
code against this case.

Change-Id: Ie1c64b4807ecf29fa0da54501798d363675977c8
2024-09-24 10:39:40 +02:00
Zuul
75927a8673 Merge "doc/source/admin fixes part-1" 2024-09-24 07:44:03 +00:00
Dmitry Tantsur
4724eb9d6f
Refactoring: get rid of AgentDeployMixin
Its existence is probably a legacy of the iSCSI deploy times. Currently,
we have 4 different base classes/mixins in agent_base, which is
confusing even for a long-term contributor like me. AgentDeployMixin is
only used in CustomAgentDeploy, so it makes sense to get rid of it to
simplify the code navigation.

All deploy steps are moved to CustomAgentDeploy. Two two helper methods,
prepare_instance_to_boot and configure_local_boot are only used in
AgentDeploy, so moving them there.

Change-Id: Ib670571eb511d2f2e724ecfab1d2abb1ab471346
2024-09-23 17:22:58 +02:00
Zuul
04dc10331b Merge "Imported Translations from Zanata" 2024-09-23 15:07:33 +00:00
Zuul
c84aee5608 Merge "Fix typo in parameter description" 2024-09-23 15:07:30 +00:00
OpenStack Proposal Bot
c2ed9296f5 Imported Translations from Zanata
For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: I4126f8c0edfa759dea7e5dad54e520f579b94a45
2024-09-22 03:19:40 +00:00
Takashi Kajinami
c53ed07155 Fix typo in parameter description
Trivial-Fix

Change-Id: I3334823fbb614192771a77d3123aa9cf2546e5a1
2024-09-21 23:10:09 +09:00