no-cache is marked for removal. we should move to cache parameter
instead. Ie6d5ab380a22c32eb6a5cee29ff7912e9f4cfe74 handle this parameter
for mistak.
TrivialFix
Change-Id: I4a6bc3eca07e9930381091fcf735529019523975
save_dependency function needs the image status which is set
by filter_images.
Change-Id: I7aa097c94d59de9389d8a53babe63d8b991a6e23
Closes-bug: 1623291
1、As mentioned in [1], we should avoid using six.iteritems/keys
achieve iterators. We can use dict.items/keys instead, as it
will return iterators in PY3 as well. And dict.items/keys will
more readable.
2、In py2, the performance about list should be negligible,
see the link [2].
[1] https://wiki.openstack.org/wiki/Python3
[2] http://lists.openstack.org/pipermail/openstack-dev/
2015-June/066391.html
TrivialFix.
Change-Id: I0cbe8af3210233a58d25f0df187c3d085405aa2a
Added a condition to skip debug message during image build, when the
base image is dependent on image of other service
Closes-Bug: #1513904.
Change-Id: I68d568981cebf442b34c958e125b0f921b883247
- Adds debian_package_install method to the jinja environment
that will return the necessary set of commands needed to
install packages via apt-get and/or URLs to .deb packages
- Updates install_packages macro to make use of the method
above
Change-Id: Ie9318a7def54b5034ba91375fd8fd3b589d18349
Partially-implements: blueprint third-party-plugin-support
The dict.values()[0] will raise a TypeError in PY3
as dict.values() doesn't return a list any more in PY3
but a view of list.
TrivialFix.
Change-Id: I01297bb68e45db4d15800d2d42e08560da7346bd
It's sorta required to actually build the image
list (and strucutre) to make any of these commands
do anything.
TrivalFix
Change-Id: Ib601bd4d2cc84af6d35a8623b77f9b512124d2ad
Instead of having the program sys.exit when a docker
client object can not be created (which kills all the threads
and messes up the program and its associated state) have a
exception be raised when this (for whatever reason) fails.
Also refactor so that there is a docker task that the docker
client using tasks can all inherit from.
TrivalFix
Change-Id: Ie81aff10cfe6f2fc5c65d53402200e3928fb460c
To correctly customize lists, we need to specify *_append, *_remove or
*_override variable in customization file.
Change-Id: I18d67ab89089e2696399ff1b99c1047a2f554442
Partially-implements: blueprint third-party-plugin-support
Instead of using the same logger for all the things
which makes it incredibly hard to figure out what the images
and there builds are doing; instead have it so that each
image gets its own logger which is then used by tasks that
process that image.
Each images logs now will (optionally) go to a logs directory
that can be more easily read and looked over and leaves
the main logger for informational/task kind of
output only.
Closes-Bug: #1586478
Change-Id: I939e073a2bc5ed8b5a1e969888fc743d80f468c9
Instead of trying to use a signal handler to stop
when ctrl-c is triggered use technique that cooperates
better with the threads that are running and lets
them die a happy death vs being forced to die in
unpleasant ways.
Closes-Bug: #1586476
Change-Id: I7fdb6a77a144bdd02276cca07b616bbb0c2f1957
The things in self.images are images, not items so
reflect these to use the shared 'image' name vs
having a one-off that uses 'item'.
TrivalFix
Change-Id: I781514d3e116de32b4fe61a7f55455282680fec1
This patchset enables potentially full customization of Dockerfiles
provided by Kolla without having to change main Kolla code. Mechanism is
based on jinja2 block mechanism. In our dockerfiles we'll add blocks
(mostly empty) with highly standarized naming, then in override file
users will be able to fill/override contents of these blocks. Example is
shown in this patch.
To enable cutomized override file call build.py
--template-override=path-to-file Only caveat is that header {% extends
.. %} has to stay
Change-Id: I5957024e5652f9677c439fb2fcd524e467b951af
Partially-implements: blueprint third-party-plugin-support
First step to break it down is to make it
importable lib rather than self-contained script.
Change-Id: Ibbc924c2849cc79006046f62f31a1909ce959066
Partially-implements: bp build-refactor