Always no quotes for $() statement.
We don't need quotes to hold blanks in result:
# i=$(echo 1 2 3)
# echo $i
1 2 3
#
These quotes can make something wrong in some case:
# i=$(echo '!')
#
# i="$(echo '!')"
-bash: !: event not found
#
No real problem for current code, only to use a better code style.
Change-Id: I06520f4b11ea6b56c4e73049b6f38bfc62fe1392
Closes-Bug: #1499716
Signed-off-by: Zhao Lei <zhaolei@cn.fujitsu.com>
The deployer is expected to know the correct permissions for his
environment. Remove 'sudo' everywhere and unify commands
Change-Id: I1ca295221a57e9d8cb35293620d14c0d8c72007d
Closes-Bug: #1496566
The previous patch (I92f2eac895283791b2eea6a4351a43e90fdbb5a3) didn't
fix it because of the ceph patch that merged.
Change-Id: I82207f5cc684f7c180e301cac69fcc98fca63268
Partially-Implements: blueprint replace-config-external
Ubuntu binary is not supported and may never be. Installing from
cloud-archive packaging is only for the current stable distros, Ubuntu
does not have a Delorean type repo. We place a fail message in the
base image to catch this and remove the messages throughout the
project.
An additional fail message is placed to catch all other things.
Change-Id: Id2953f503ebd42226f6a08e75979ae56511c40f7
Implements: blueprint install-from-ubuntu
A new version was released and it is not necessary anymore to install
from git.
Change-Id: Id05c4b0c969d32c14e63f1b3e88bc73c8b7ff890
Partially-Implements: blueprint vagrant-improvements
This resolves the package versions conflicts we saw recently and fixes
source image building gate.
Change-Id: I489499e447ac1b7bb82ae9d69eb5b7fe7bd7591d
Closes-Bug: #1498303
This implements all the openstack pieces needed to make ceph work.
DocImpact
Change-Id: I1d24476a966602cf955e5ef872b0efb01319894a
Partially-Implements: blueprint ceph-container
Implements: blueprint kolla-live-migration
I removed the files but not the COPY commands thus breaking all of
Kolla
Change-Id: I37d3e0cb94a1ecc12971f485f953310ba8fee53c
Partially-Implements: blueprint replace-config-external
Changed the repository of kolla to
openstack
(Note: the bug describes using github, but in the review it was
determined that using openstack repos is best.)
Change-Id: I26c9543776a441ab3ca606ad7aa7381db94fe094
Closes-Bug: #1495162
All services should have a guide that follows the same style as
cinder-guide.rst or swift-guide.rst and all should be named
service-guie.rst.
Change-Id: Iaa75d137d4e159452153f9fe572fe017fe988be4
Removes config-external for all services that have been replaced in
Ansible
Change-Id: I839a14418638b977fbc1d02ba6839811b0f909ea
Partially-Implements: blueprint replace-config-external
