7279 Commits

Author SHA1 Message Date
Maksim Malchuk
8c8dad0187 Fix Venus containers start issue
The venus containers failed to start with an error
(venus_api container):
/usr/local/bin/kolla_start: line 24: exec: venus-api: not found
because of [1] and also changes the encoding of the files form
dos to unix introduced in [2].

1. https://opendev.org/openstack/venus/src/branch/master/setup.cfg#L29-L30
2. If3562bbed6181002b76831bab54f863041c5a885

Change-Id: I8bee27882c15e39a3d2946787d56bc90db994887
Signed-off-by: Maksim Malchuk <maksim.malchuk@gmail.com>
2023-06-07 21:56:16 +03:00
Zuul
0fc3418b8f Merge "Fix the fluentd regexp to collect the logs" 2023-05-24 13:50:25 +00:00
lishuliang
900c2d20bb Fix the fluentd regexp to collect the logs
The default value of logging_context_format_string and
logging_user_identity_format has changed [1][2][3].
This is to correct fluentd to use the same format.

[1]ebdee7f399
[2]7ed065f38d

[3]https://review.opendev.org/c/openstack/oslo.log/+/838185

Closes-Bug: #1872220

Change-Id: Ide0079ef4d28e3a3fa60288a74b936531c52ce60
2023-05-24 09:04:18 +00:00
Michal Nasiadka
1769a49115 opensearch: alter path after using rpm/deb packaging
opensearch-dashboards now use a dedicated user

Depends-On: https://review.opendev.org/c/openstack/kolla/+/883941
Change-Id: I6908f52f824a97a5a4a2bead92b7b2e5cdebdb9f
2023-05-24 08:48:45 +00:00
Zuul
8661c1bbed Merge "neutron: Add neutron-ovn-agent support" 2023-05-19 13:42:55 +00:00
Zuul
62be98f90c Merge "Add container engine option to scripts" 2023-05-19 11:59:56 +00:00
Michal Nasiadka
07815a21da neutron: Add neutron-ovn-agent support
Depends-On: https://review.opendev.org/c/openstack/neutron/+/878535
Change-Id: I05d8b29b59a7de76da488f68775547a8f0f11d0f
2023-05-19 10:20:16 +00:00
Michal Nasiadka
10fc1b748a ansible: bump min to 2.13 and max to 2.14.2
We limit to 2.14.2 due to a regression in ansible-core [1] that breaks
conditional include_task loops in handlers. This is used for controlled
restarts of MariaDB and RabbitMQ.

[1]: 65366f663d

Change-Id: I57425680a4cdbf0daeb9b2cc35920f1b933aa4a8
Co-Authored-By: Michal Nasiadka <michal@stackhpc.com>
2023-05-18 20:04:48 +01:00
Sean Mooney
ddadaa282e always add service_user section to nova.conf
As of I3629b84d3255a8fe9d8a7cea8c6131d7c40899e8 nova
now requires the service_user section to be configured
to address CVE-2023-2088. This change adds
the service user section to the nova.conf template in
the nova and nova-cell roles.

Related-Bug: #2004555
Signed-off-by: Sven Kieske <kieske@osism.tech>
Change-Id: I2189dafca070accfd8efcd4b8cc4221c6decdc9f
(cherry picked from commit a77ea13ef1991543df29b7eea14b1f91ef26f858)
(cherry picked from commit 03c12abbcc107bfec451f4558bc97d14facae01c)
(cherry picked from commit cb105dc293ff1cdb11ab63fa3e3bf39fd17e0ee0)
(cherry picked from commit efe6650d09441b02cf93738a94a59723d84c5b19)
2023-05-16 04:20:21 +00:00
Zuul
be1ca8a910 Merge "Fix Bash variable expansion issues in openrc file" 2023-05-16 01:58:48 +00:00
Matt Crees
46c2b60d9f Correct ovn-ctl --db-nb-pidfile usage in templates
The flags ``--db-nb-pid`` and ``--db-sb-pid`` are corected to be
``--db-nb-pidfile`` and ``--db-sb-pidfile`` respectively. See here for
reference:
6c6a7ad1c6/utilities/ovn-ctl (L1045)

Closes-Bug: #2018436
Change-Id: Ic1e8768374566eb2198302807ecc644a19cd3062
2023-05-04 10:33:51 +01:00
Martin Hiner
53e8b80ed3 Add container engine option to scripts
This patch add a way to choose container engine inside tool and test
scripts. This is in preparation for Podman introduction but still
leaves Docker as default container engine.

Signed-off-by: Martin Hiner <m.hiner@partner.samsung.com>
Change-Id: I395d2bdb0dfb4b325b6ad197c8893c8a0f768324
2023-04-28 16:16:55 +02:00
Zuul
92ddbdfbc1 Merge "octavia: Fix hm-interface after bumping openstack collection" 2023-04-27 09:28:36 +00:00
Michal Nasiadka
c0d0866785 octavia: Fix hm-interface after bumping openstack collection
New openstack collection modules have changed output
dicts/variable names - adapting to that.

Also changing octavia amphora image to focal, since bionic
hasn't been rebuilt since May 2021.

Closes-Bug: #2012255
Change-Id: Icf38a52472d02ef7d69bcd3716afb16e859d44a2
2023-04-26 13:13:31 +00:00
Maksim Malchuk
df6472e0af Fix Bash variable expansion issues in openrc file
Sometimes passwords, URLs and other values of the variables can
contain special symbols, for example the dollar sign, using these
values can lead to unpredictable attempts of the variable expansions
in the Bash scripts, such as openrc file, so we need to use single
quotes for all variables values.

Change-Id: Ib2aabadd0ffd6a8dc2591245f29b4478e03d92fc
Signed-off-by: Maksim Malchuk <maksim.malchuk@gmail.com>
2023-04-25 14:46:11 +03:00
Zuul
6c3738a84c Merge "Designate: provide certificates file to use for neutron client requests" 2023-04-24 14:40:38 +00:00
Zuul
3b24d77c48 Merge "Fix faulty precheck for RabbitMQ" 2023-04-24 09:55:10 +00:00
Maksim Malchuk
31e0d374bd Designate: provide certificates file to use for neutron client requests
Closes-Bug: #1919464
Change-Id: I64a5185627f98bcaf471ed8ccf0fd8f314769404
Signed-off-by: Maksim Malchuk <maksim.malchuk@gmail.com>
2023-04-23 01:13:32 +03:00
Zuul
e8091acefc Merge "Add check_mode: false to Nova upgrade checks" 2023-04-21 07:39:16 +00:00
Zuul
861e9467ad Merge "Revert "ansible: bump min to 2.13 and max to 2.14"" 2023-04-20 13:20:52 +00:00
Magnus Lööf
fdacf9d1d9 Fix faulty precheck for RabbitMQ
When using externally managed certificates, according to [1],
one should set `kolla_externally_managed_cert: yes` and ensure
that the certificates are in the correct place.

However, RabbitMQ precheck still expects the certificates to be
available on the controller node. This is incorrect.

Fix by not running the tasks in question when `kolla_externally_managed_cert: yes`

[1] https://docs.openstack.org/kolla-ansible/latest/admin/tls.html

Closes-Bug: 1999081
Related-Bug: 1940286
Signed-off-by: Magnus Lööf <magnus.loof@basalt.se>
Change-Id: I9f845a7bdf5055165e199ab1887ed3ccbfb9d808
2023-04-20 13:28:39 +02:00
Zuul
557b1272ff Merge "Trivial fix - add int filter for rabbitmq definitions" 2023-04-20 11:15:16 +00:00
Dr. Jens Harbott
b98a71e5d4 Revert "ansible: bump min to 2.13 and max to 2.14"
This reverts commit 9867060b6b3bd36aad121b53b9e5dddfca8a8e4c.

Reason for revert: seems this broke some jobs

Change-Id: I1ca81214ece403351c0a522ea05bf07802e4c4c0
2023-04-20 09:26:11 +00:00
Zuul
226eb2aa99 Merge "Configure coordination in default for masakari-api" 2023-04-20 09:11:13 +00:00
Michal Arbet
d1b24a4137 Trivial fix - add int filter for rabbitmq definitions
Change-Id: I1d8021a1bc780449e3ca96183c6f4abaed17b382
2023-04-19 21:27:20 +02:00
Zuul
6421d8df07 Merge "Add precheck to fail if RabbitMQ HA needs configuring" 2023-04-19 17:11:04 +00:00
Matt Crees
e0191cb167 Add check_mode: false to Nova upgrade checks
The step "Run Nova upgrade checks" needs to be excluded from check mode.

Related-Bug: #2002657
Change-Id: Ida582606b03d1896a6c58d4b324d088dc3b71852
2023-04-19 16:19:59 +01:00
Zuul
9cfba97cf5 Merge "Use the upgraded image to run Nova upgrade checks" 2023-04-19 14:16:19 +00:00
Matt Crees
a5331d3208 Add precheck to fail if RabbitMQ HA needs configuring
Currently, the process of enabling RabbitMQ HA with the variable
``om_enable_rabbitmq_high_availbility`` requires some manual steps to
migrate from transient to mirrored queues. In preparation for setting
this variable to ``True`` by default, this adds a precheck that will
fail if a system is currently running non-mirrored queues and
``om_enable_rabbitmq_high_availbility`` is set to ``True``.

Includes a helpful message informing the operator of their choice.
Either follow the manual procedure to migrate the queues described in
the docs, or set ``om_enable_rabbitmq_high_availbility`` to ``False``.

The RabbitMQ HA section of the reference docs is updated to include
these instructions.

Change-Id: Ic5e64998bd01923162204f7bb289cc110187feec
2023-04-19 09:45:34 +01:00
Zuul
f5991df02b Merge "mariadb: add mariadb_datadir_volume parameter" 2023-04-19 08:27:42 +00:00
Zuul
17aa380bf8 Merge "ansible: bump min to 2.13 and max to 2.14" 2023-04-19 01:26:28 +00:00
Zuul
fab40de52f Merge "Remove RabbitMQ ha-all policy when not required" 2023-04-18 20:24:54 +00:00
Zuul
7a8f3d3212 Merge "Fix create sasl account before config file is ready" 2023-04-18 18:57:00 +00:00
Zuul
52611ecbab Merge "Fix maximum width of the DIB Multiline-YAML" 2023-04-18 14:51:39 +00:00
Michal Arbet
842adf6d2f Configure coordination in default for masakari-api
This patch introduces distributed lock for masakari-api
service when handle the concurrent notifications for the same
host failure from multiple masakari-hostmonitor services.

Change-Id: I46985202dc8da22601357eefe2727599e7a413e5
2023-04-17 20:02:42 +02:00
Michal Nasiadka
c0a45c7eb7 opensearch: default dashboards tag to opensearch_tag
Closes-Bug: #2016627

Change-Id: I5ae1d911c5df423e0b70dab306709320083b7b69
2023-04-17 12:37:33 +00:00
Maksim Malchuk
47862b56bd Fix maximum width of the DIB Multiline-YAML
The dib_env_vars variable in the Bifrost's dib.yml file can contain
the DIB_BLOCK_DEVICE_CONFIG environment variable which is always the
Multiline-YAML data. By default, the format of the data is not
preserved while the configuration is merged and saved for the
bifrost-deploy container.

This is because Ansible uses the PyYAML library which has a default
80 symbol string length limit. The official Ansible documentation [1]
recommends using to_yaml or to_nice_yaml filters with width parameter.
This change adds the same ability to the merge_yaml Ansible plugin.

1. https://docs.ansible.com/ansible/latest/user_guide/playbooks_filters.html#formatting-data-yaml-and-json

The related change for the diskimage-builder to solve the issue with
incorrect data provided by Kolla-Ansible is also provided:
I3b74ede69eb064ad813a9108ec68a228e549e8bb

Closes-Bug: #2014980
Related-Bug: #2014981
Change-Id: Id79445c0311916ac6c1beb3986e14f652ee5a63c
Signed-off-by: Maksim Malchuk <maksim.malchuk@gmail.com>
2023-04-14 16:36:22 +03:00
Zuul
b142b0ae7a Merge "Fix merge action plugins verbose output" 2023-04-14 10:36:45 +00:00
Zuul
be2e353da3 Merge "RabbitMQ use maintenance mode on container restart" 2023-04-13 21:47:41 +00:00
Zuul
4b27d19b63 Merge "Set RabbitMQ ha-promote-on-shutdown=always" 2023-04-13 15:05:48 +00:00
Michal Nasiadka
9867060b6b ansible: bump min to 2.13 and max to 2.14
Change-Id: Ibc9cc91f64b0450de3cae6e2830b4ff2c52c0395
2023-04-13 14:10:28 +00:00
Matt Crees
c85b64d158 Remove RabbitMQ ha-all policy when not required
With the addition of the variable
`om_enable_rabbitmq_high_availability`, this feature in the upgrade
task should be brought back. It is also now used in the deploy task. The
`ha-all` policy is cleared only when
`om_enable_rabbitmq_high_availability` is set to `false`.

Change-Id: Ia056aa40e996b1f0fed43c0f672466c7e4a2f547
2023-04-13 15:58:15 +02:00
Matt Crees
e709599ff0 RabbitMQ use maintenance mode on container restart
Puts the RabbitMQ node into maintenance mode before restarting the
container. This will make the node shutdown less disruptive. For details
on what maintenance mode does, see:
https://www.rabbitmq.com/upgrade.html#maintenance-mode

Change-Id: Ia61573f3fb95fe8fcde6b789ca77ef5b45fe0a65
2023-04-12 15:58:17 +01:00
Michal Nasiadka
b30c7bc87b rabbitmq: Do not stop containers on upgrade
Since RMQ 3.8 we can use rolling upgrade [1].

Depends-On: https://review.opendev.org/c/openstack/kolla/+/872393

[1]: https://www.rabbitmq.com/upgrade.html#rolling-upgrades

Change-Id: If6a7c6c12d9226a2406728108b3c87b3485ac55f
2023-04-12 11:12:30 +00:00
gamerslouis
46415123d5 Fix create sasl account before config file is ready
Add checking for container readiness before create sasl user

Closes-Bug: #2015589
Change-Id: Ic650ba6be1f192e3cbeaa94de3d00507636c1c92
2023-04-08 17:48:46 +00:00
Zuul
717eb8c14f Merge "nova: Fix live migration on RHEL9 derivatives" 2023-04-03 14:31:39 +00:00
Michal Nasiadka
7c32e6f3b3 nova: Fix live migration on RHEL9 derivatives
Closes-Bug: #2005119
Change-Id: I542f7ae19b4400355b04854f42a1d1802a6efeea
2023-04-03 10:28:48 +00:00
Zuul
3e556dad61 Merge "Add LimitRequestBody configuration for Horizon" 2023-04-03 10:25:55 +00:00
Maksim Malchuk
8972241dc9 Fix merge action plugins verbose output
This change fixes the output 'module_args' information of the plugins
'merge_configs' and 'merge_yaml' when Ansible is executed in maximum
verbose mode. Now all the plugin options are displayed instead of
standard 'copy' plugin options only.

Also, this change contains fixes already applied in the Kayobe
project to improve and synchronize the code of the plugins between
projects.

Change-Id: Ie2d9a0501fe29bfd854eb31258f282b197855948
Signed-off-by: Maksim Malchuk <maksim.malchuk@gmail.com>
2023-04-02 00:33:40 +03:00
Zuul
dbb4f3d0ae Merge "Add neutron_ovn_availability_zones parameter" 2023-03-29 16:48:23 +00:00