openstack/manila
Code Issues Proposed changes

[devstack] cleanup iptables rules

Browse Source 
When MANILA_ALLOW_NAS_SERVER_PORTS_ON_HOST is set
to True, we setup some firewall rules to allow
ingress into NAS ports exposed on the devstack
host; we'll need to clean them up during teardown
to ensure that re-stacking the devstack wouldn't
raise a 'iptables: Chain already exists' error.

The cleanup commands will run only if there
is a chain called "manila-storage".

Change-Id: Ia409ec2145e3b4c361fb381048f277ce5a10ecde
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>
This commit is contained in:
Goutham Pacha Ravi
2021-07-13 17:25:38 -07:00
parent 7fd3fe1dc6
commit 417b5de97e
1 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
devstack/plugin.sh
View File

@@ -52,6 +52,19 @@ function _clean_zfsonlinux_data {
done
}
function _clean_ip_tables {
for ipcmd in iptables ip6tables; do
# cleanup rules in the "manila-storage" chain
sudo $ipcmd -S -v | sed "s/-c [0-9]* [0-9]* //g" | \
grep "manila-storage" | grep "\-A" | sed "s/-A/-D/g" | \
awk -v ipcmd="$ipcmd" '{print "sudo " ipcmd,$0}' | bash
# cleanup the "manila-storage" chain
sudo $ipcmd -S -v | sed "s/-c [0-9]* [0-9]* //g" | \
grep "manila-storage" | grep "\-N" | sed "s/-N/-X/g" | \
awk -v ipcmd="$ipcmd" '{print "sudo " ipcmd,$0}' | bash
done
}
# cleanup_manila - Remove residual data files, anything left over from previous
# runs that a clean run would need to clean up
function cleanup_manila {
@@ -59,6 +72,7 @@ function cleanup_manila {
_clean_share_group $SHARE_GROUP $SHARE_NAME_PREFIX
_clean_manila_lvm_backing_file $SHARE_GROUP
_clean_zfsonlinux_data
_clean_ip_tables
if [ $(trueorfalse False MANILA_USE_UWSGI) == True ]; then
remove_uwsgi_config "$MANILA_UWSGI_CONF" "$MANILA_WSGI"