- Never initialize the log by passing it in to `load_plugin`. Unity and VNX
driver plugins initialize it in their implementation.
- Move plugins specific options from framework to Unity and VNX plugins.
- Rename driver options for Unity/VNX, the old ones are deprecated:
emc_nas_pool_names -> unity_share_data_pools/vnx_share_data_pools,
emc_nas_server_pool -> unity_server_meta_pool,
emc_interface_ports -> unity_ethernet_ports/vnx_ethernet_ports,
emc_nas_server_container -> unity_server_container/vnx_server_container.
DocImpact
Closes-Bug: 1652710
Change-Id: I8f1404de8dea9eeb09f1e5f6fc2538cefb0d63d9
Adds instructions on how to set up a fully functional manila
development environment using Devstack to the Developers Reference.
Partially-implements bp improve-manila-developer-docs
Change-Id: Id9781046716af2e04a0aea2734fbe4590bfd28dc
Whereas the bug report associated to this fix is about
Manila UI not working, this fix addresses more than this.
On the first place, it decouples Manila UI from Manila Devstack
plugin. This is a desired change since not every Manila user
needs to work with the UI, and it doesn't make sense to have
Manila UI bits on the Manila code if we can place all Manila UI
related code on the Manila UI repo and, in this case,
Manila UI Devstack plugin. This patch-set removes all the traces
of Manila UI setup from the Manila Devstack plugin.
Manila UI Devstack plugin was added in 457249be7ab3849b3479b96077a411ca37c37a95.
And, secondly, it fixes Manila UI deploy with Devstack. Enabling
manila-ui plugin on Devstack properly sets the UI component for
Manila.
Change-Id: I7a3372371e25c69d3df6d395c703a6412750effd
Closes-Bug: #1570033
An attribute check is being performed: "if not self.image_ref"
but self.image_ref may not be defined at all, leading to the
following error. So, let's define it first so it can be properly
evaluated.
AttributeError: 'TestShareBasicOpsNFS' object
has no attribute 'image_ref'
TrivialFix
Change-Id: I0c454009b95c5cb0b6fc1304bb0cba1ff87c9fe9
3rd party CIs cannot set this config by exporting an env var
or local.conf setting, as it is always being overriden in code.
Change-Id: Ia2a4790d3a0d03faa231b400c32f6c1928bdca1f
Closes-bug: #1649249
One IP port is enough for share server created on Unity system.
This patch change the IP allocation in Unity driver from 2 to 1.
Change-Id: I3e8ea3f5fe1d3e713239d5c0fb19733abc97f5bd
Closes-Bug: 1648328
Reportedly [1], the kernel-nfs-server has a bug where we have overlap of
filesystem identifiers using LVM volumes and their snapshots.
We face this bug in manila LVM driver and Generic driver when we use
cinder LVM driver. So, fix it generating unique UUID for all
snapshots (only for LVM, because we cannot do it in Generic driver
while we do not have "mount-snapshot" feature support there) and
child volumes that will be exported as child shares.
[1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1071733
Change-Id: Ib93bfb0d4184da1e70ecece6fde6931e44d05a30
Closes-Bug: #1645751
1.As mentioned in [1], we should avoid using
six.iteritems to achieve iterators. We can
use dict.items instead, as it will return
iterators in PY3 as well. And dict.items/keys
will more readable. 2.In py2, the performance
about list should be negligible, see the link [2].
[1] https://wiki.openstack.org/wiki/Python3
[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html
Change-Id: Ic68ba358d51002e1a1aeac6159248ffb730b5daf
The VNX manila driver doesn't support the "update_access" API.
Add support for this API which implements following functions:
* Add a list of access rules.
* Remove a list of access rules.
* Recover access rules.
Change-Id: I49de0864e2f2c74d1b4d0f57fa0939a6d8c7c5df
Implements: blueprint vnx-manila-update-access
Administrators intend to get the pool's information filtered
by share type(actually filtered by share_type's *extra_spec*)
more directly.
The blueprint is to add a filter key 'share_type' to cover
this situation.
APIImpact
Implements: blueprint pool-list-by-share-type
Change-Id: Ifd64bb84d03a02aa0a118cc42e1d1b373c439884
One our scenario tempest test [1] started failing randomly.
It was failing on resources removal. So, start deleting resources
in proper order.
[1] manila_tempest_tests.tests.scenario.test_share_basic_ops.\
TestShareBasicOpsNFS.test_mount_share_one_vm
Change-Id: Ib1eba66e4d27552cf8e78b302a9f03ac84d978ba
Closes-Bug: #1647350
Adding support for manage/unmanage snapshots in Hitachi HNAS
driver. In order to manage a snapshot, the admin should provide the
snapshot size in "--driver-options" parameter.
Also, updating tempest tests for manage/unmanage snapshots to include
the required driver option.
DocImpact
Implements: blueprint hnas-manage-unmanage-snapshot-support
Change-Id: I93e56dda5cbe8d3dbe142d773f93d03a0c126d2f
Because, it leads to inheritance of access rules too. That is a bug.
All other expected options are generated on-fly already.
Change-Id: Ibe744c9fd001156a8184aa8f955c424cebfb8664
Closes-Bug: #1645746
Switch manila devstack plugin for usage of only openstack client,
because other CLIs (such as neutron [1]) "are"/"going to be" deprecated
in favor of openstack client.
[1] https://review.openstack.org/#/c/243348/
Change-Id: If06dfc2c79df4628e747ac28d0add8d4a223777c
Closes-Bug: #1644589
Recent change to devstack [1] broke our DHSS=False CI job running
generic driver that was depending on ip route from host to
private network. So, to avoid this error use floating ip address
for connection to service Nova VMs from host machine.
Also, fix generation of second export location that should be dedicated
for service needs such as mounting share doing host-assisted
migration.
[1] If45e3fc15c050cfbac11b57c1eaf137dd7ed816f
Change-Id: Ieea992293ae02898741c939da15f0dbb4609d8b0
Closes-Bug: #1644523
Closes-Bug: #1646097
Recent devstack change [1] changed order of installing things,
where tempest now is installed later than it was. So, run our
tempest updates later too, when tempest is installed.
Closes-Bug: #1646492
[1] I3d98692e69d94756e0034c83a247e05d85177f02
Change-Id: I85ca94455ad0b7882cde70c6ba0091f9f83f39b8
The `deleted` column in volume_type_extra_specs was as a boolean;
The same column in share_type_extra_specs is an integer. However,
the code migrating from volume_types to share_types
assumes them to be vice-versa. This breaks downgrading from that
migration.
Further, the `id` column in share_type_extra_specs is a primary key
field of Integer datatype. Such fields have auto-increment turned on
by default; we shouldn't be copying the `id` from
volume_type_extra_specs when we copy the data.
Fix these bugs and add a unit test.
Change-Id: Ic32a8a17b1b6a773de6dcf7792d9b37f6aed4a3c
Needed-by: Ib0ad5fbfdf6297665c208149b08c8d21b3c232be
Closes-Bug: 1643535
Some distros ship with /etc/samba/smb.conf already in
place, without /usr/share/samba/smb.conf.
Only copy /etc/samba/smb.conf from /usr/share/samba/smb.conf
if /usr/share/samba/smb.conf exists.
Change-Id: I22aeed317a94774ff03c1aadf6a65f5edb490837
Fixes-bug: 1645860
For drivers that implement update_access always through recovery
mode, access rules previously set to read-only were being reset
to read-write when the Data Service was adding/removing its access
rule.
Fixed it by integrating the logic that casts DB rules to read-only
into access helper class.
Change-Id: Ife35dcdb99dffa2f266b5c2f6a68fe163da7edd3
Closes-bug: #1626523
