The newer version of six (1.4.1) provides six.StringIO
which is a fake file object for textual data. It's an
alias for cStringIO.StringIO, in python2 and io.StringIO
in Python3
Change-Id: I5f4af05eb0754d85a73068d5f6b285d4be07cdfc
As per OpenStack licensing guide lines [1]:
[H102 H103] Newly contributed Source Code should be licensed under the Apache 2.0 license.
[1] http://docs.openstack.org/developer/hacking/#openstack-licensing
Change-Id: Ib3cb284f5232b4641058d262160d4204566e1904
Commit [1] does not cover last comments.
Tempest tests should have been in
"manila_tempest_tests/tests/api/admin/test_scheduler_stats.py".
Also, fix the validation if API returns empty list and the py3
compatibility issue.
[1] Ifd64bb84d03a02aa0a118cc42e1d1b373c439884
Change-Id: I62a7bf7fcffcab990b19812cd677a0d51088ae0e
Fix the command cited in the devref devstack doc to copy
samples/local.conf up one directory for use as basis for
a local.conf with manila plugin added.
TrivialFix
Change-Id: Iab4d35d41444a05757a3f2a5552e7b4939007327
Several bugs are caused by an error code and
exception raised when a path has no NFS exports.
Use the machine-readable mmnfs export list command
(the -Y option) which does not cause an exception
when checking for exports.
Co-Authored-By: digvijay2016 <digvijay.ukirde@in.ibm.com>
Change-Id: I770756e0a36c5b61386878164b651fadf9730b7f
Closes-Bug: #1650043
Closes-Bug: #1650044
Closes-Bug: #1650045
This patch adds the documentation related to DriverFilter and
GoodnessWeigher added with change ID
I873f4152e16efdeb30ceae26335a7974dc9b4b69.
Change-Id: I03df00e4852ac5eed74d1079ec8830272f813e4d
Closes-bug: #1605737
Adds instructions on how to set up a fully functional manila
development environment using Devstack to the Developers Reference.
Partially-implements bp improve-manila-developer-docs
Change-Id: Id9781046716af2e04a0aea2734fbe4590bfd28dc
In addition to functional tests.
Also, make some corrections to scenario tests code to make it work
with shares located on localhost.
Co-Authored-By: Alexey Ovchinnikov <aovchinnikov@mirantis.com>
Co-Authored-By: Valeriy Ponomaryov <vponomaryov@mirantis.com>
Change-Id: Ice61a7593f5e4e443cffbe78ecd71d683a9c274e
Add tempest scenario test where we create share from snapshot and
test its relations to source share. Design for this test is available
at 'Add spec for Scenario tests' spec [1].
[1] I224a52521033b47574ff5fd5a94b096c91593aa7
Change-Id: I9863ea70977453b3e7492164002b983f3d9944ab
Whereas the bug report associated to this fix is about
Manila UI not working, this fix addresses more than this.
On the first place, it decouples Manila UI from Manila Devstack
plugin. This is a desired change since not every Manila user
needs to work with the UI, and it doesn't make sense to have
Manila UI bits on the Manila code if we can place all Manila UI
related code on the Manila UI repo and, in this case,
Manila UI Devstack plugin. This patch-set removes all the traces
of Manila UI setup from the Manila Devstack plugin.
Manila UI Devstack plugin was added in 457249be7ab3849b3479b96077a411ca37c37a95.
And, secondly, it fixes Manila UI deploy with Devstack. Enabling
manila-ui plugin on Devstack properly sets the UI component for
Manila.
Change-Id: I7a3372371e25c69d3df6d395c703a6412750effd
Closes-Bug: #1570033
An attribute check is being performed: "if not self.image_ref"
but self.image_ref may not be defined at all, leading to the
following error. So, let's define it first so it can be properly
evaluated.
AttributeError: 'TestShareBasicOpsNFS' object
has no attribute 'image_ref'
TrivialFix
Change-Id: I0c454009b95c5cb0b6fc1304bb0cba1ff87c9fe9
3rd party CIs cannot set this config by exporting an env var
or local.conf setting, as it is always being overriden in code.
Change-Id: Ia2a4790d3a0d03faa231b400c32f6c1928bdca1f
Closes-bug: #1649249
One IP port is enough for share server created on Unity system.
This patch change the IP allocation in Unity driver from 2 to 1.
Change-Id: I3e8ea3f5fe1d3e713239d5c0fb19733abc97f5bd
Closes-Bug: 1648328
Reportedly [1], the kernel-nfs-server has a bug where we have overlap of
filesystem identifiers using LVM volumes and their snapshots.
We face this bug in manila LVM driver and Generic driver when we use
cinder LVM driver. So, fix it generating unique UUID for all
snapshots (only for LVM, because we cannot do it in Generic driver
while we do not have "mount-snapshot" feature support there) and
child volumes that will be exported as child shares.
[1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1071733
Change-Id: Ib93bfb0d4184da1e70ecece6fde6931e44d05a30
Closes-Bug: #1645751
1.As mentioned in [1], we should avoid using
six.iteritems to achieve iterators. We can
use dict.items instead, as it will return
iterators in PY3 as well. And dict.items/keys
will more readable. 2.In py2, the performance
about list should be negligible, see the link [2].
[1] https://wiki.openstack.org/wiki/Python3
[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html
Change-Id: Ic68ba358d51002e1a1aeac6159248ffb730b5daf
The VNX manila driver doesn't support the "update_access" API.
Add support for this API which implements following functions:
* Add a list of access rules.
* Remove a list of access rules.
* Recover access rules.
Change-Id: I49de0864e2f2c74d1b4d0f57fa0939a6d8c7c5df
Implements: blueprint vnx-manila-update-access
Administrators intend to get the pool's information filtered
by share type(actually filtered by share_type's *extra_spec*)
more directly.
The blueprint is to add a filter key 'share_type' to cover
this situation.
APIImpact
Implements: blueprint pool-list-by-share-type
Change-Id: Ifd64bb84d03a02aa0a118cc42e1d1b373c439884
One our scenario tempest test [1] started failing randomly.
It was failing on resources removal. So, start deleting resources
in proper order.
[1] manila_tempest_tests.tests.scenario.test_share_basic_ops.\
TestShareBasicOpsNFS.test_mount_share_one_vm
Change-Id: Ib1eba66e4d27552cf8e78b302a9f03ac84d978ba
Closes-Bug: #1647350
Adding support for manage/unmanage snapshots in Hitachi HNAS
driver. In order to manage a snapshot, the admin should provide the
snapshot size in "--driver-options" parameter.
Also, updating tempest tests for manage/unmanage snapshots to include
the required driver option.
DocImpact
Implements: blueprint hnas-manage-unmanage-snapshot-support
Change-Id: I93e56dda5cbe8d3dbe142d773f93d03a0c126d2f
