Added support for manage/unmanage in GPFS NFS driver.
This patch added functions that allow share on Spectrum Scale
node to be managed by OpenStack if existing fileset is an
independent fileset and doesn't have any NFS export
over the fileset path. Also, share can be unmanaged from
OpenStack but still left in Spectrum Scale cluster.
Implements: blueprint gpfs-manage-support
Change-Id: I9134408b59c30ac4bc593f287294741f6e996136
Creation of security group using openstack client is broken. So,
use nova client for it temporary while 'related' bug is not fixed.
Change-Id: I51b5be5157bd49d5835b30eaa8b6b0e7185cabdf
Related-Bug: #1652317
Use looser error code checking and add a verify
after deny access so that the call will succeed
whenever it can be confirmed that the access no
longer exists.
This fixes a variety of situations where previously
a return code of 1 while attempting to remove access
would cause the manila access rule to get stuck while
the actual client access export was removed or never
existed.
Change-Id: Ie058a6185e3f5d91fb1cf232301eb0ac6ddcea7e
Closes-Bug: #1651587
Fix GPFS KNFS allow/deny access so that it does not reuse
the ssh prefix when looping through NFS server commands for
allow and deny access.
This fixes GPFS KNFS allow/deny access incorrect behavior
when multiple NFS servers are configured (gpfs_nfs_server_list)
and any of the servers are remote (except the last one).
Change-Id: I8c182eed386e8325b087c3192d363502bb848633
Closes-Bug: #1651578
The snapshot_support extra spec has always meant two
things: a driver can take snapshots and create shares
from snapshots. As we add alternate snapshot semantics,
it is likely that some drivers will want to support
snapshots and some of the new semantics while being
unable to create new shares from snapshots.
This work adds a new extra spec,
create_share_from_snapshot_support, that removes the
overloading on snapshot_support. It also makes the
existing snapshot_support extra spec optional,
allowing admins to create types without setting
snapshot_support; shares created with such types
will not support snapshots.
APIImpact
DocImpact
Co-Authored-By: Goutham Pacha Ravi <gouthamr@netapp.com>
Implements: blueprint add-create-share-from-snapshot-extra-spec
Change-Id: Ib0ad5fbfdf6297665c208149b08c8d21b3c232be
The newer version of six (1.4.1) provides six.StringIO
which is a fake file object for textual data. It's an
alias for cStringIO.StringIO, in python2 and io.StringIO
in Python3
Change-Id: I5f4af05eb0754d85a73068d5f6b285d4be07cdfc
As per OpenStack licensing guide lines [1]:
[H102 H103] Newly contributed Source Code should be licensed under the Apache 2.0 license.
[1] http://docs.openstack.org/developer/hacking/#openstack-licensing
Change-Id: Ib3cb284f5232b4641058d262160d4204566e1904
The minimum file system on Unity is 3 GB. This patch changes
driver to create 3 GB underlying file system for shares
smaller than 3 GB.
DocImpact
Change-Id: Ida6ad9ad7e752c25b53390f0fee327c594e03f9f
Closes-Bug: 1648316
Commit [1] does not cover last comments.
Tempest tests should have been in
"manila_tempest_tests/tests/api/admin/test_scheduler_stats.py".
Also, fix the validation if API returns empty list and the py3
compatibility issue.
[1] Ifd64bb84d03a02aa0a118cc42e1d1b373c439884
Change-Id: I62a7bf7fcffcab990b19812cd677a0d51088ae0e
Fix the command cited in the devref devstack doc to copy
samples/local.conf up one directory for use as basis for
a local.conf with manila plugin added.
TrivialFix
Change-Id: Iab4d35d41444a05757a3f2a5552e7b4939007327
Several bugs are caused by an error code and
exception raised when a path has no NFS exports.
Use the machine-readable mmnfs export list command
(the -Y option) which does not cause an exception
when checking for exports.
Co-Authored-By: digvijay2016 <digvijay.ukirde@in.ibm.com>
Change-Id: I770756e0a36c5b61386878164b651fadf9730b7f
Closes-Bug: #1650043
Closes-Bug: #1650044
Closes-Bug: #1650045
This patch adds the documentation related to DriverFilter and
GoodnessWeigher added with change ID
I873f4152e16efdeb30ceae26335a7974dc9b4b69.
Change-Id: I03df00e4852ac5eed74d1079ec8830272f813e4d
Closes-bug: #1605737
Adds instructions on how to set up a fully functional manila
development environment using Devstack to the Developers Reference.
Partially-implements bp improve-manila-developer-docs
Change-Id: Id9781046716af2e04a0aea2734fbe4590bfd28dc
In addition to functional tests.
Also, make some corrections to scenario tests code to make it work
with shares located on localhost.
Co-Authored-By: Alexey Ovchinnikov <aovchinnikov@mirantis.com>
Co-Authored-By: Valeriy Ponomaryov <vponomaryov@mirantis.com>
Change-Id: Ice61a7593f5e4e443cffbe78ecd71d683a9c274e
Add tempest scenario test where we create share from snapshot and
test its relations to source share. Design for this test is available
at 'Add spec for Scenario tests' spec [1].
[1] I224a52521033b47574ff5fd5a94b096c91593aa7
Change-Id: I9863ea70977453b3e7492164002b983f3d9944ab
Whereas the bug report associated to this fix is about
Manila UI not working, this fix addresses more than this.
On the first place, it decouples Manila UI from Manila Devstack
plugin. This is a desired change since not every Manila user
needs to work with the UI, and it doesn't make sense to have
Manila UI bits on the Manila code if we can place all Manila UI
related code on the Manila UI repo and, in this case,
Manila UI Devstack plugin. This patch-set removes all the traces
of Manila UI setup from the Manila Devstack plugin.
Manila UI Devstack plugin was added in 457249be7ab3849b3479b96077a411ca37c37a95.
And, secondly, it fixes Manila UI deploy with Devstack. Enabling
manila-ui plugin on Devstack properly sets the UI component for
Manila.
Change-Id: I7a3372371e25c69d3df6d395c703a6412750effd
Closes-Bug: #1570033
An attribute check is being performed: "if not self.image_ref"
but self.image_ref may not be defined at all, leading to the
following error. So, let's define it first so it can be properly
evaluated.
AttributeError: 'TestShareBasicOpsNFS' object
has no attribute 'image_ref'
TrivialFix
Change-Id: I0c454009b95c5cb0b6fc1304bb0cba1ff87c9fe9
3rd party CIs cannot set this config by exporting an env var
or local.conf setting, as it is always being overriden in code.
Change-Id: Ia2a4790d3a0d03faa231b400c32f6c1928bdca1f
Closes-bug: #1649249
One IP port is enough for share server created on Unity system.
This patch change the IP allocation in Unity driver from 2 to 1.
Change-Id: I3e8ea3f5fe1d3e713239d5c0fb19733abc97f5bd
Closes-Bug: 1648328
Reportedly [1], the kernel-nfs-server has a bug where we have overlap of
filesystem identifiers using LVM volumes and their snapshots.
We face this bug in manila LVM driver and Generic driver when we use
cinder LVM driver. So, fix it generating unique UUID for all
snapshots (only for LVM, because we cannot do it in Generic driver
while we do not have "mount-snapshot" feature support there) and
child volumes that will be exported as child shares.
[1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1071733
Change-Id: Ib93bfb0d4184da1e70ecece6fde6931e44d05a30
Closes-Bug: #1645751
