openstack/mistral
Code Issues Proposed changes
a7cd611c78
mistral/HACKING.rst
Sharat Sharma 61ed17e421 Added style enfore checks for assert statements 
Added following style checks:
 * Enforce use of assertTrue/assertFalse
 * Enforce use of assertIs/assertIsNot

Change-Id: Ic4bc964fef9ea78934937dc74017569c2a55ba44
Implements: blueprint mistral-hacking
2017-06-05 16:05:57 +00:00

687 B
Raw Blame History

Style Commandments

Read the OpenStack Style Commandments https://docs.openstack.org/developer/hacking/

Mistral Specific Commandments

  • [M001] Use LOG.warning(). LOG.warn() is deprecated.
  • [M318] Change assertEqual(A, None) or assertEqual(None, A) by optimal assert like assertIsNone(A)
  • [M319] Enforce use of assertTrue/assertFalse
  • [M320] Enforce use of assertIs/assertIsNot
  • [M327] Do not use xrange(). xrange() is not compatible with Python 3. Use range() or six.moves.range() instead.
  • [M328] Python 3: do not use dict.iteritems.
  • [M329] Python 3: do not use dict.iterkeys.
  • [M330] Python 3: do not use dict.itervalues.