070113c906
As discussed at the Epoxy PTG meeting, run an automated upgrade tool to make code python 3.9+ compliant. Result of running: $ pyupgrade --py39-plus $(git ls-files | grep ".py$") Fixed PEP8 errors introduced by pyupgrade by running: $ autopep8 --select=E127,E128,E501 --max-line-length 79 -r \ --in-place neutron_fwaas Also did manual updates as necessary to fix other errors and warnings after above commands. Inspired by Octavia and Nova [0]. [0] https://review.opendev.org/c/openstack/nova/+/896986 Change-Id: I28003aa9e42479ac966a05edd174fc0435e57e3a
48 lines
1.6 KiB
Python
48 lines
1.6 KiB
Python
# Copyright 2019 Red Hat Inc.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from unittest import mock
|
|
|
|
from oslo_config import cfg
|
|
from oslo_upgradecheck.upgradecheck import Code
|
|
|
|
from neutron_fwaas.cmd.upgrade_checks import checks
|
|
from neutron_fwaas.tests import base
|
|
|
|
|
|
class TestChecks(base.BaseTestCase):
|
|
|
|
def setUp(self):
|
|
super().setUp()
|
|
self.checks = checks.Checks()
|
|
|
|
def test_get_checks_list(self):
|
|
self.assertIsInstance(self.checks.get_checks(), list)
|
|
|
|
def test_fwaas_v1_check_sucess(self):
|
|
cfg.CONF.set_override('service_plugins', ['l3', 'qos'])
|
|
check_result = checks.Checks.fwaas_v1_check(mock.Mock())
|
|
self.assertEqual(Code.SUCCESS, check_result.code)
|
|
|
|
def test_fwaas_v1_check_warning(self):
|
|
plugins_to_check = [
|
|
['l3', 'firewall', 'qos'],
|
|
['l3',
|
|
'neutron_fwaas.services.firewall.fwaas_plugin:FirewallPlugin',
|
|
'qos']]
|
|
for plugins in plugins_to_check:
|
|
cfg.CONF.set_override('service_plugins', plugins)
|
|
check_result = checks.Checks.fwaas_v1_check(mock.Mock())
|
|
self.assertEqual(Code.FAILURE, check_result.code)
|