openstack/neutron
Code Issues Proposed changes

Move factory assignment in _ipam_allocate_ips()

Browse Source 
It was inside a for loop, but should be outside since it's
a static assignment.

Trivialfix

Change-Id: I6385ec91b9df3c53175c5be17857a0402d7c4f4e
This commit is contained in:
Brian Haley 2019-08-12 12:39:35 -04:00
parent 59203d02a2
commit cf3410b6c0
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
neutron/db/ipam_pluggable_backend.py
View File

@ -118,6 +118,7 @@ class IpamPluggableBackend(ipam_backend_mixin.IpamBackendMixin):
allocated ip addresses.
"""
allocated = []
factory = ipam_driver.get_address_request_factory()
# we need to start with entries that asked for a specific IP in case
# those IPs happen to be next in the line for allocation for ones that
@ -132,7 +133,6 @@ class IpamPluggableBackend(ipam_backend_mixin.IpamBackendMixin):
ip_list = [ip] if isinstance(ip, dict) else ip
subnets = [ip_dict['subnet_id'] for ip_dict in ip_list]
try:
factory = ipam_driver.get_address_request_factory()
ip_request = factory.get_request(context, port, ip_list[0])
ipam_allocator = ipam_driver.get_allocator(subnets)
ip_address, subnet_id = ipam_allocator.allocate(ip_request)