L3 agent imports the processutils module to catch exceptions that
wouldn't ever be thrown because the underlying execute() being
called is the one from neutron.agent.linux.utils which raises a
RuntimeError on failure.
Also, processutils is now part of oslo.concurrency. So when we
actually start using it, we'll use it from there.
Closes-Bug: 1401626
Change-Id: I43874e1b63a0ba7b01415cafe0538f4343057066
The file l3_agent.py has become too large. This patch is a simple
pure refactor to move some of the functionality in to other files
where things aren't too tangled up. There is no functional change
with this patch and I avoided gratuitous other fixups in this patch in
order to make it easier to review.
I plan to follow up on the new l3_dvr and l3_agent_router modules with
more restructuring in the near future.
Partially-Implements: bp restructure-l3-agent
Change-Id: I3529fe4146c50c940f41eb26d0b5efc5870b3af9
Change I6a079ad introduced some magic to enable showing test output
as the test run. Do the same for *-functional tests too, by reusing
the default testenv
Change-Id: I6d1ede1c66e7b62c68449224f274417a5d66c12f
- Nuke more services code, killing some refs in vmware plugin
- Vmware plugin foreign key relationships are temporary disabled
- Vmware unit tests are temporarily disabled
- Remove router insertion test, as its only user is going away
- Add thin service plugin shims
- Temporarily disable model sync test
Post services-split, existing neutron.conf configurations may contain
references to in-tree plugin classes. Add thin shims so that those configs
will continue to work.
Change-Id: I5dd26def685bcc643e35badc23885afc6240ae94
- After l3_agent is refactored, need to remove services/firewall
- After vmware plugin moves services out of monolothic,
remove model copies and services/loadbalancer/constants,
and re-enable unit tests.
- After alembic chain gets split in four, tweak models/head and
fix heal/current chain.
- Re-factor test_routerserviceinsertion into one of the service repos
Partially-Implements: blueprint services-split
Change-Id: I5466984a9e57128266f97e9bd5c265f4dc3cba7b
This change replaces a few no-op string statements with regular
comments. While there was no harm in the previous use of strings for
comments, this allows us to re-enable the corresponding pylint check
which may catch genuinely unintended cases.
Change-Id: I796a059292e26c4df75c54f095d9e20e99187c98
When debugging problems from logs, it would be useful to know what
version is running across program start and stop. In one case I have
a suspicion that an upgrade was run inbetween but the logs don't help
identify that.
My first thought was to grab this from argparse just as --version
does, but that's not really currently possible [1].
The original starting message is probably irrelevant, but I realise
log messages tend to suffer from Hotel California syndrome; you can
check-in but you can never leave.
[1] http://bugs.python.org/issue9399
Change-Id: Ia1bfd2f3589b508e19fd8a94d59beaafd6d657d2
This change enforces log hints use and removes debug level log
translation, modifications are validated through a hacking rule
and the change respects loggging guidelines. Validate that hacking
rules apply to directories:-
neutron/plugins/ofagent
neutron/plugins/oneconvergence
Change-Id: I520a36ae53848b828ce33f4050606a7238f4cbce
Partial-bug: #1320867
All the log messages now have the required hints. In addition to
this debug messages are not translated. This is done for the
plugins/nec directory.
Change-Id: Ic0a352cd61131637c471931e3e73995e2143675f
Commit abc16ebf made the get_sg_ids_grouped_by_port function not return
entries for ports without security groups. This causes the agent to not remove
previously created security groups for that port since the port is not
returned in the security_group_info_for_devices data.
This change fixes that by always including a list of security groups for each
port, even if that list is empty.
Change-Id: I9616708462a8b6f3d46ebd76db5cf8cb2826f4ad
Closes-Bug: #1398312
All the log messages now have the required hints. In addition to this
debug messages are not translated.
This is done for the plugins/ibm
Change-Id: I8239e73eb959648178aa94535d15d77a817c89f5
Replace URLs for workflow documentation to appropriate parts of the
OpenStack Project Infrastructure Manual.
Change-Id: I77aa4152a903a0f1f47de20bb1a006d29f5a1bf2
While bash is not available on every environments, there seems to be
a tendency to introduce more bash dependency very casually. This check
is intended to be a reminder to give people a chance to consider
alternatives.
Related-Bug: #1398266
Change-Id: I5103e0d7c111880d9a02dd93de56c567066ed14c
