Although AF_INET is always 2, AF_INET6 can vary
depending on the OS. Use the system-defined
value so the routing table tests work on OSX.
Change-Id: I11dca8e4022b23282838799798f352beb2416881
Update the bug triage policy for neutron DocImpact bugs affecting
openstack-manuals.
The two policy additions are:
1. Tagging the bug for the appropriate guide. This will assist the
openstack-manuals team with their part of the triage process.
2. Removing neutron from affected projects if the bug only affects
openstack-manuals. This will help reduce clutter in the neutron bug queue.
Change-Id: Iac2dd10f1476cde0843c356f0d161b5a59943c99
In one of tests, pstree received SIGSEGV signal and was terminated. This
means the output is empty and we check on empty string. This patch makes
the test less prone to the errors coming from executed binaries.
Change-Id: I22a7f2fea56c9d97a1d765f0f25e9f28c7942b55
Closes-bug: 1659965
The QoS devref has a bad link to the L2 agent extensions
doc. This patch fixes the link.
Note: The bug reports a few other neutron dead links, but
these are either already fixed, or for liberty release notes
and liberty is already EOL.
Change-Id: I047f638f0a348d636aa533c0db93e8a1f23c6356
Closes-Bug: #1652944
CT zones are used only in OVSHybridIptablesFirewallDriver.
Such zones are not set in IptablesFirewallDriver class but
even if iptables driver was is not using CT zones, it was
used by conntrack manager class during delete of conntrack
entry.
This cause issue that for Linuxbridge agent established and
active connection stayed active even after security group
rule was deleted.
This patch changes conntrack manager class that it will not
use CT zone (-w option) if zone for port was not assigned
earlier.
Change-Id: Ib9c8d0a09d0858ff6f36db406c6b2a9191f304d1
Closes-bug: 1657260
WarningsFixture class was set to display deprecation
warnings "alway" - which means every occurence of
a warning.
Since oslo.context 2.12.0 there was huge amount of such
warnings displayed. It causes functional tests fails due
to reach global timeout for tests.
Now deprecation warning should be disaplayed only on first
occurence of matching warning in test.
Change-Id: I91196a8457c25e6eb5561fb74fd5864de85a070a
Closes-Bug: 1660088
Looking at the cache before aqcuiring a lock may cause the
agent to mistakenly think the network doesn't exist when it
is actually being wired in parallel.
Always acquiring the network-based semaphore will ensure that
the network isn't currently being setup in another coroutine.
Closes-Bug: #1659919
Change-Id: I99ae71e3c5b1cd91dca3f6c80b04d2ecb79de64f
Current testing of Keepalived was not configuring the connectivity
between 2 agent namespaces.
Added setting up the veth pair.
Also, bridges external qg-<id> and internal qr-<id> were removed
from agent1 namespace and moved to agent2 namespace, because they had
the same name.
Added patching the qg and qr bridges name creation to be different for
functional tests.
Change-Id: I82b3218091da4feb39a9e820d0e54639ae27c97d
Closes-Bug: #1580648
While debugging the related bug, this showed up in the logs:
AddBridgeCommand(datapath_type=None, may_exist=system, name=test-brd8f3648c)
This was caused by the add_bridge command not passing in the datapath
type as named argument so it was taking the positional argument of
may_exist. So the datapath type was being lost whenever this command
was being used.
This fixes it by makeing add_bridge use a named argument for
datapath_type and it also switches it to using the
OVSBridge.create() method to unify the code-paths for bridge
creation.
It's not clear that this was a cause of the bug though, so
this fix is only related.
Change-Id: I5711c29c21741dd847f2c27fb621f723b24cb7fd
Related-Bug: #1627106
After deleting the router interfaces, another concurrent
process (e.g. HA port creation) could happen before the actual
router is deleted, which would lead to an SQLAlchemy error due
to the relationship being violated.
This patch fixes the issue by bumping the router revision before
deleting the router to check for concurrent interface additions.
A race will trigger a staledataerror which will be retried by
the decorator
Closes-Bug: #1655281
Change-Id: I465e9a2f9b216991afa26c16271854fb88068006
Ever since https://review.openstack.org/#/c/418609/
merged, changing to use the pyroute2 library for managing
neighbour entries, there has been an up-tick in DVR
error messages - "DVR: Failed updating arp entry" is
happening trying to delete a non-existent entry.
Since the error is not fatal, just catch and ignore it.
Change-Id: If6c4715b85c0bd65f5f58600ce5572fa60651510
Extended the Primary Key of ml2_port_binding table to include "hosts"
and added a new column named "status" to indicate the status of the
port similar to the ml2_distributed_port_binding table. Updated the
PortBinding object with the above changes.
Change-Id: Ie01f83b01ab673b9ae7e05b4eaed504ffc8db773
Co-Authored-By: Brian Stajkowski <brian.stajkowski@rackspace.com>
Partial-Bug: #1580880
This will prevent the common_db_mixin dictionary
extension functions and query hooks from stopping
the GC of plugins in tests and causing resource leaks.
Change-Id: I7576851a44abd14cbc337a3d3e28690c7316ec81
When the process is using the IptablesFirewall driver
and is running in namespaces, there is no
/proc/sys/net/bridge in the namespace available and
enable of netfilter for bridge fails with stacktrace
in logs.
This patch handles the exception thrown during a
failed attempted to retrieve net.bridge variable names
and prints an info message in agent logs instead of
printing a stacktrace.
Change-Id: I1ff6cedbf933ac54ef4bbf1d44fc8f57f68d57fc
Closes-bug: 1658343
Change 68ac442f11a6698bc43210fae877ba3809b1c02d introduce refactor
and start passing context instead of session.
For those who still use old TypeDriver usage methods
* allocate_fully_specified_segment
* allocate_partially_specified_segment
can end up with error. Current change adds check for type of the
argument that has been passed.
Change-Id: I8c6e60408dcc0a83ac401585c7cf962a84af92bd
A few fixes required to allow deserialization/serialization
of OVO resources.
* Set shared to False when context is missing for RBAC calculations
* Parse strings received from json into netaddr objects
Partially-Implements: blueprint push-notifications
Change-Id: I1609014d6100a0c410c66d159f9e682d8aa3e7ba
The resources module was missing the SUBNET variable
so it wasn't possible for consumers to reference it
like the other resources.
TrivialFix
Partially-Implements: blueprint push-notifications
Change-Id: I954858f5c4487ea97a482a24576a6ca523d4d5d6
