27500 Commits

Author SHA1 Message Date
Brian Haley
c282077058 Fix pointless-string-statement pylint warning
For some reason, kilo_initial.py is triggering this warning,
so fix it by using comments instead of a docstring.

Also updated the template to use comments as well, so any
migrations created in the future use them, even though
none seem to be causing a similar warning right now.

Closes-bug: #2036763
Change-Id: I63b7ac83fdd3ebc6251979f1376daf2105489fdc
2023-09-21 10:43:46 -04:00
Zuul
dbe4ba910b Merge "Open the 2024.1 (Caracal) DB branch" 2023-09-19 20:24:07 +00:00
OpenStack Proposal Bot
53d4a43251 Imported Translations from Zanata
For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: Ic7e880b7fc04a3acffa5aa0f4b558f382dcd6827
2023-09-19 04:24:58 +00:00
Zuul
c33805919e Merge "Update master for stable/2023.2" 2023-09-18 07:52:42 +00:00
Zuul
d01f0695e7 Merge "Remove ovn.ini example file" 2023-09-16 00:04:28 +00:00
efd7199960 Update master for stable/2023.2
Add file to the reno documentation build to show release notes for
stable/2023.2.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/2023.2.

Sem-Ver: feature
Change-Id: I9c87c69e50379559771ce278039c0c5e822697d6
2023-09-15 13:48:01 +00:00
Zuul
741f504c7b Merge "Prevent internal IP change for floating IP" 23.0.0.0rc1 2023-09-13 14:09:44 +00:00
Zuul
2aae505f32 Merge "Fix wrong indentation in release note" 2023-09-13 01:03:12 +00:00
Brian Haley
0ca6953194 Fix wrong indentation in release note
Default-security-group-rules-added release note had some
extra indentation, which rendered it with a "bar" in
front of the list of items. Remove the two spaces.

Also fixed other grammatical issues in the note.

Trivialfix

Change-Id: I5d4a2e3be9a86c29f75e131d677f288bfe3222d1
2023-09-12 12:54:28 -04:00
Slawek Kaplonski
b2ceb8b854 Add release note with known issue with FIP PFs and vlan tenant networks
This patch adds just release note with the known issue to describe known
wrong configuration which cause FIP Port Forwarding to not work properly
in ML2/OVN backend and distributed FIPs enabled.
For more details, please check related bug.

Related-bug: #2028846
Change-Id: I48b5358f4c3ac492d68b00a4c0153370332e9249
2023-09-12 16:06:41 +00:00
Rodolfo Alonso Hernandez
7e0ba8bcda Open the 2024.1 (Caracal) DB branch
According to the TC resolution [1] and the release identification
document [2], the release number will be used as primary identifier in
the development cycle. Release name will be used in marketing.

[1]https://governance.openstack.org/tc/resolutions/20220524-release-identification-process.html
[2]https://governance.openstack.org/tc/reference/release-naming.html

Change-Id: I1ffd5878489176f33146688de03367101ede2305
2023-09-09 22:13:40 +00:00
Brian Haley
0611735715 Remove ovn.ini example file
The ovn.ini file is a hold-over from the networking-ovn
tree. The docs all reference configuring OVN (and OVS)
options in ml2_conf.ini, so remove the old file and add
the neutron.ml2.ovn namespace to
etc/oslo-config-generator/ml2_conf.ini.

Trivialfix

Change-Id: I26dedc80e07aedffb1713560d4431b7a334b70b5
2023-09-06 15:19:30 -04:00
Rodolfo Alonso Hernandez
8cba9a2ee8 Call the "tc qdisc" command for ingress qdisc without parent
The "tc qdisc" command to create an ingress qdisc does not require
to define a parent qdisc [1]. The ingress qdisc "differs from other
qdiscs in that it does not occupy the root of a device".

The previous command was replacing the default root egress qdisc:
  root@dev20:~# ip netns exec ns01 tc qdisc show
  qdisc noqueue 0: dev dummy root refcnt 2

This operation is now not permitted with the new kernel.

This patch is also changing how the TC funtional tests interact with
the namespace interface created. Now the interface is set to UP before
the test starts. That changes the "tc qdisc show" command because now
the default qdisc (see the aforementioned CLI output) is now present,
as it should be in a live environment (where the interfaces are UP).

Closes-Bug: #2034540

[1]https://tldp.org/HOWTO/Adv-Routing-HOWTO/lartc.adv-qdisc.ingress.html

Change-Id: I2f8130dc3cf3244be2a44a4ecbdbaa9c7f865731
2023-09-06 16:11:11 +00:00
Zuul
37c4998699 Merge "[CI] Bump OVS_BRANCH in ovs/ovn source deploy jobs" 2023-09-05 16:50:43 +00:00
Zuul
ea2449b593 Merge "Revert "[OVN][Trunk] Set the subports correct host during live migration"" 2023-09-05 16:50:29 +00:00
Zuul
a280a8d25f Merge "Check the device ID and host ID during virtual port binding" 2023-09-05 14:01:53 +00:00
Rodolfo Alonso
34e441e06c Revert "[OVN][Trunk] Set the subports correct host during live migration"
This reverts commit 7ed79c1f7890456488a4b44769ed84fea23c9a39.

Reason for revert: the port binding handling done in this patch is
incorrect and leads to issues during the cold migration process with
trunk ports in ML2/OVN.

Change-Id: I642c3eb1771463db73248a8c50c0db6f7467a6d5
Partial-Bug: #2033887
2023-09-05 10:50:35 +00:00
c930196dd8 [CI] Bump OVS_BRANCH in ovs/ovn source deploy jobs
Since [1] OVN/OVS source deploy jobs running with
OVN_BRANCH=main fails to compile ovn as this now
requires newer ovs commits from branch-3.2.

[1] https://github.com/ovn-org/ovn/commit/558da0cd

Closes-Bug: #2034096
Change-Id: I5247ce2b1a8606bde807a1744ed37daff04438f1
2023-09-05 10:28:38 +05:30
f7489abaf8 [UT] Adjust autogen_process_directives for alembic-1.12.0+
With [1] included in alembic-1.12.0 the unit test
test_autogen_process_directives fails as it was
expecting 'type_' param in Autogenerated output.
But this is not included with 1.12.0 by default,
this patch enhances the regex to care only for relevant
parameters.

[1] https://github.com/sqlalchemy/alembic/commit/733197e
Closes-Bug: #2034016
Change-Id: I088cc4b260cccf6be2963d23a76a05f11cfccf2c
2023-09-04 08:42:44 +00:00
Zuul
9716e0356d Merge "[OVN] Fix rate and burst for stateless security groups" 2023-09-01 17:25:06 +00:00
Zuul
ed6023c347 Merge "Update QoS config document: use YAML config examples" 2023-09-01 09:06:51 +00:00
Zuul
1bb9fe1b21 Merge "Default SG rules template - Update related docs and add release note" 2023-08-31 19:05:54 +00:00
Zuul
9dceb760df Merge "Default SG rules - use new rules templates to create rules for SGs" 2023-08-31 19:05:49 +00:00
Elvira García
a3a113aedb [OVN] Fix rate and burst for stateless security groups
Right now, as per kernel limitation, the burst limit is not correctly
enforcing the rate and burst when using the ovn "log-related" option and
stateless security groups. We log exactly double the burst. Creating a
new meter that limits the rate and burst to half of the expected ones is
a workaround that solves the issue.

Closes-bug: #2032929

Signed-off-by: Elvira García <egarciar@redhat.com>
Change-Id: Ib0047d38c58bcebb23c8887e7934987ff8c8a432
2023-08-31 15:10:20 +02:00
Zuul
dde31aae39 Merge "[OVN] Add the 'uplink-status-propagation' extension to ML2/OVN" 2023-08-31 11:37:30 +00:00
Zuul
b63370a2fc Merge "[UT] Reduce the binding retry loop in `L3HATestFramework`" 2023-08-31 08:45:21 +00:00
Zuul
bd6df15ca0 Merge "Drop release notes for l3-ext-gw-multihoming and adjacent features" 2023-08-30 17:28:28 +00:00
Zuul
a7dfdf287a Merge "[Fullstack] Use new DB for each running test" 2023-08-30 17:28:16 +00:00
Rodolfo Alonso Hernandez
b250b85770 [UT] Reduce the binding retry loop in `L3HATestFramework`
That reduces the test execution time.

Trivial-Fix

Change-Id: I9c7ecc9f52a67bbed5d6377bd9e1c58c13fd6d3f
2023-08-30 15:13:43 +00:00
Frode Nordahl
c6b6ecc751 Drop release notes for l3-ext-gw-multihoming and adjacent features
We did unfortunately not make it into Bobcat, and will try again
to get it into Caracal.

Partial-Bug: #2002687
Change-Id: I5b4579a96152b8bdb1d34e59fb492c6f2a01b71e
2023-08-30 15:35:23 +02:00
Zuul
e7528f7841 Merge "Use HasStandardAttributes as parent class for Tags DB model" 2023-08-30 13:34:25 +00:00
Zuul
2b9a981d66 Merge "[OVN] Cleanup old Hash Ring node entries" 2023-08-30 11:12:21 +00:00
Slawek Kaplonski
5c2f54ca03 Default SG rules template - Update related docs and add release note
This patch updates docs related to the Security Groups to add info about
possibility to change default set of rules created in every new security
group.
It also adds release note about this new API in Neutron.

Closes-Bug: #1983053
Change-Id: I0f6ecc5cf374a0090930e9786834ed7a1be3dc0b
2023-08-30 10:18:34 +00:00
Slawek Kaplonski
a4c8392209 Default SG rules - use new rules templates to create rules for SGs
Default SG rules created as template in the Neutron DB are now used to
create security group rules for each new default and non-default SG
created in Neutron.

Closes-bug: #1983053
Change-Id: Iaf27deb955c3844409fcd36239511478e9607a82
2023-08-30 10:18:19 +00:00
Slawek Kaplonski
78bc33d300 [Fullstack] Use new DB for each running test
Until now neutron fullstack tests which were run by the same worker were
using same DB but after test content of the DB was cleaned.
This could cause problems e.g. for default security group rules which
weren't created properly in second test run by the same worker.

To fix that issue patch [1] was proposed and merged some time ago. But
this didn't solve the problem so this patch is effectively reverting [1]
and proposing another solution which will make each fullstack test to
use own DB and run db migration script.

As running DB migration before every test makes this jobs to run a bit
longer than it took before, this patch also increases timeout for the
fullstack job(s) to 3h (10800 seconds).

[1] https://review.opendev.org/c/openstack/neutron/+/891040

Related-bug: #1983053
Change-Id: Ia261b4c62db9a99ef6eb161acb4609520e45d101
2023-08-30 12:16:51 +02:00
Zuul
f06e659170 Merge "Add some more known issues to the OVN gap document" 23.0.0.0b3 2023-08-29 20:27:06 +00:00
Lucas Alvares Gomes
7f777c223e [OVN] Cleanup old Hash Ring node entries
This patch introduces a maintenance task that runs once a day and is
responsible for cleaning up Hash Ring nodes that haven't been updated in
5 days or more.

Change-Id: Ibed9e0d77500570c3d0f9f39bfe40cb9239d0d7a
Closes-Bug: #2033281
Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com>
2023-08-29 12:09:00 +01:00
Rodolfo Alonso Hernandez
d9eb04478e [FT] Make explicit the "publish" call check in "test_port_forwarding"
The functional test "TestMaintenance.test_port_forwarding" is checking
the "registry.publish" call after calling
"delete_floatingip_port_forwarding". This patch makes this check
explicit for the expected call.

Closes-Bug: #2033387
Change-Id: I95074a0fe071e3ed8bf58c9210d63a2f30ee68a0
2023-08-29 10:04:52 +00:00
Zuul
03e07ade2e Merge "Fix race condition when creating two routers without HA network" 2023-08-29 03:39:27 +00:00
Zuul
f91429100b Merge "Use the new network HA parameter" 2023-08-29 03:34:52 +00:00
Rodolfo Alonso Hernandez
fa130f29f7 Update QoS config document: use YAML config examples
Closes-Bug: #2033203
Change-Id: I0162cf74e74ff915918d36bd1150d2ac474ac882
2023-08-28 10:12:58 +00:00
Rodolfo Alonso Hernandez
0545f40a04 [OVN] Add the 'uplink-status-propagation' extension to ML2/OVN
Closes-Bug: #2032770
Change-Id: I5f11b568bab4518617409b7c3a02c7222df80a92
2023-08-28 09:59:30 +00:00
Rodolfo Alonso Hernandez
a3b00768d6 Check the device ID and host ID during virtual port binding
If a port receives a device ID and a binding profile host ID
fields update, at the same time, this is because Nova is trying
to bind the port to a VM (device ID) in a host (host ID). In
ML2/OVN, a virtual port cannot be bound to a VM.

NOTE:
* A virtual port can receive a host ID update. That happens when
  the fixed IP port that has the virtual port IP address as
  allowed address pair is bound.
* A virtual port can receive a devide ID update. Octavia uses
  the devide ID to identify to what load balancer the virtual
  port belongs.

This check was introduced in [1].

[1]https://review.opendev.org/c/openstack/neutron/+/882588

Closes-Bug: #2028651
Related-Bug: #2018529
Change-Id: I8784c6716f5a53b91d43323771e6f30fa8e8e506
2023-08-28 09:50:10 +00:00
Dr. Jens Harbott
0e5c91c499 Add some more known issues to the OVN gap document
See the related bugs.

Related-Bug: #2030294
Related-Bug: #2030295
Change-Id: If90e4233c599b0ab4363d7eea6b00436bf7ab92c
2023-08-27 15:15:42 +02:00
Zuul
bffb88f5f8 Merge "[OVN][Trunk] Set the subports correct host during live migration" 2023-08-25 18:01:21 +00:00
Zuul
20e26f9bb6 Merge "[OVN] Skip the port status UP update during a live migration" 2023-08-25 18:01:17 +00:00
Zuul
4be5a38685 Merge "Fix ovn-metadata agent sync of unused namespaces" 2023-08-25 11:46:19 +00:00
Zuul
3578543ce0 Merge "[OVN] Disable the mcast_flood_reports option for LSPs" 2023-08-25 10:15:54 +00:00
Rodolfo Alonso Hernandez
e6fb32e27d Fix race condition when creating two routers without HA network
When a HA router is created and the HA is not yet, before creating
the router, the Neutron server creates the HA network and the
corresponding subnet.

The HA network cannot be duplicated (see previous patches related to
this bug). But the subnet, that is created in another database
transaction, cannot be present when the router creation call tries
to create the HA port.

This patch adds a HA subnet check before creating the router and the
HA port. Even if the subnet check fails and the worker tries to
create this subnet, if the process fails with ``InvalidInput``, that
means other worker created the subnet before and the current one
fails because tries to create the same subnet with the same CIDR.
In this case, we dismiss the exception and continue with the router
creation.

Closes-Bug: #2016198

Change-Id: I82225fcc6248bb0fd68959ceb1daabff423d81ff
2023-08-25 08:43:46 +00:00
Rodolfo Alonso Hernandez
4109ee9bb4 Use the new network HA parameter
This patch implements the new network HA boolean field API extension.
This field is an input only parameter for POST operations (creation).
By default is "False". When enabled, the Neutron server will create
a ``ha_router_networks`` register in the same transaction of the
network creation.

If by any circumstance (a race condition, for example), another
``ha_router_networks`` exists in the same project, a
``DBDuplicateEntry`` exception will be raised and the transaction
will be rolled back.

Partial-Bug: #2016198
Change-Id: Ie42c13ecbe4abcad9229b71f6942e393fd0f2e4e
2023-08-25 08:43:37 +00:00