26305 Commits

Author SHA1 Message Date
Rodolfo Alonso Hernandez
c5b76a8393 Script to remove duplicated port bindings
A new script to remove the duplicated port bindings was added. This
script will list all ``ml2_port_bindings`` records in the database,
finding those ones with the same port ID. Then the script removes
those ones with status=INACTIVE. This script is useful to remove
those leftovers that remain in the database after a failed live
migration.

"dry_run" mode is possible if selected in "[cli_script] dry_run"
boolean config option. The duplicated port bindings are printed in
the shell but not deleted.

Related-Bug: #1979072

Change-Id: I0de5fbb70eb852f82bd311616557985d1ce89bbf
2022-08-18 08:13:56 +00:00
Rajesh Tailor
8ab5ee1d17 Fix remaining typos in comments and tests
Change-Id: I872422cffd1f9a2e59b5e18a86695e5cb6edc2cd
2022-07-06 21:20:27 +05:30
Zuul
ac0f247352 Merge "update the nova host aggregates links" 2022-07-06 06:05:07 +00:00
Zuul
7b8c8104c6 Merge "Report ExternalDNSOverQuota exception for zone quota error" 2022-07-05 20:15:23 +00:00
Zuul
5f80b91f58 Merge "Fix some pylint indentation warnings" 2022-07-05 17:19:29 +00:00
Erik Olof Gunnar Andersson
8b0a34a585 Report ExternalDNSOverQuota exception for zone quota error
This bug was previously fixed for recordsets, but can also fail
when creating zones.

Closes-Bug: #1980673
Related-Bug: #1923700
Change-Id: Icef3eab6a27f3b8950a7877de0d387e668a067ad
2022-07-05 15:05:14 +00:00
Zuul
3dcf0eefa7 Merge "Fix requirements for doc build" 2022-07-05 09:31:49 +00:00
Dr. Jens Harbott
62568cf307 Fix requirements for doc build
The doc build needs WebTest, which used to be imported as a transitive
requirement via pecan, but the latest release of pecan dropped this
dependency. So make this requirement explicit.

Change-Id: Ib3f3318440c79909090616b9d480b8dbf55e7b81
2022-07-05 10:26:08 +02:00
Zuul
7c2896963f Merge "Implement experimental features framework" 2022-07-04 15:54:25 +00:00
Zuul
cd2538f729 Merge "[sqlalchemy-20] Remove unnecessary DB context" 2022-07-04 15:53:50 +00:00
Zuul
0e09e26830 Merge "ovs: handle segmentation ids per network ports" 2022-07-04 15:45:13 +00:00
Slawek Kaplonski
e39011c733 Use common wait_until_ha_router_has_state method everywhere
In the L3 functional tests framework module there is already helper
method called wait_until_ha_router_has_state which should be used to
wait for desired HA router's state.
This method has proper debug logging added so debugging issues in CI is
easier when it's used.
It is also decorated with unstable_test decorator to skip tests when
router will fail to transition to desired state (see related bug for
details).

In some tests this method wasn't used so we couldn't benefit from the
logging and unstable_test decorator there. Now it should be unifed and
used everywhere in the same way.

Related-Bug: #1956958
Change-Id: I9d79b123bb20ded327208d84a14d4f8d2e505087
2022-07-04 11:09:23 +02:00
Zuul
2a66dda182 Merge "Revert "[fips jobs] blacklist AttachInterfacesTestJSON tempest test"" 2022-07-04 08:56:44 +00:00
Zuul
705b99bdc6 Merge "Revert "Temporary blacklist test_reboot_server_hard in OVN IPv6 job"" 2022-07-04 08:56:39 +00:00
Zuul
27cda9f274 Merge "ovs: remove unused function _get_port_local_vlan" 2022-07-04 08:56:34 +00:00
renliang17
210f5297f5 update the nova host aggregates links
https://docs.openstack.org/nova/latest/admin/aggregates.html link failure,
From openstack U version, this link is not in the user directory. Currently, only the latest version has been changed.
You are advised to change all the links

Change-Id: Ic3b5a0ac7d832b162848b363396264ed0bfc4a25
2022-07-04 14:13:30 +08:00
Brian Haley
58b1df699d Fix some pylint indentation warnings
Running with a stricter .pylintrc generates a lot of
C0330 warnings (hanging/continued indentation). Fix
some of them, about 10%.

Feel free to reject if we think it will cause too much
trouble with cherry-picks, else I'll slowly work my way
through the rest of the tree.

Trivialfix

Change-Id: I3d484d11e273cb8ee617f9445a069887e7b2b89f
2022-07-01 17:52:59 -04:00
Zuul
ae87995a08 Merge "ovn: use requested-chassis list format for live migration" 2022-07-01 20:23:33 +00:00
Zuul
fbdc8c0e3e Merge "[FT] Run all .*MySQL and .*PostgreSQL tests in an isolated thread" 2022-07-01 16:02:18 +00:00
Zuul
6dd37e2b62 Merge "[FT] Ensure "update_virtual_port_host" has been called" 2022-07-01 15:24:26 +00:00
Zuul
b737253943 Merge "[sqlalchemy-20] Add the needed DB context decorators in `ml2.plugin`" 2022-07-01 13:48:33 +00:00
Zuul
57ca1a3d54 Merge "Replace "Inspector.from_engine()" with "sqlalchemy.inspect()"" 2022-07-01 13:48:27 +00:00
Zuul
22396ddf1f Merge "Mellanox_eth.img url expires, remove the mellanox_eth.img node" 2022-07-01 11:19:23 +00:00
Elvira García Ruiz
a630fc79a5 Revert "Temporary blacklist test_reboot_server_hard in OVN IPv6 job"
This reverts commit 7c95150c84d77f3eae69def5b1328243ccec248a.

Reason for revert: The bug related to this change has been fixed for a while: https://bugs.launchpad.net/neutron/+bug/1906490

Change-Id: Icd8208d63be413f45fcd0c8652ab02a3a53ffc3a
2022-07-01 11:51:48 +02:00
f879d1f957 Revert "[fips jobs] blacklist AttachInterfacesTestJSON tempest test"
This reverts commit a1384678b88fc7ffb5eeccfbfc0da16a9cb8910a.

Reason for revert: https://bugzilla.redhat.com/show_bug.cgi?id=2092856 fixed in libvirt-8.4.0-3.el9 and available in CentOS 9-Stream.

Change-Id: I2f33543fa7ee65ce3d25f70af49a18b69f799aec
Related-Bug: #1979047
Related-Bug: rhbz#2092856
2022-07-01 05:39:14 +00:00
Miguel Lavalle
7f0413c84c Implement experimental features framework
During the Zed PTG it was decided to handle unsupported features in
Neutron as experimental. See section titled "When we say something is
not supported?", day 2 in [1]. The agreement was:

"We keep existing jobs for linuxbridge driver for example, but when the
tests start to fail we skip them and finally we stop the job also.
To make it clear for operators we add warning logs highlighting that the
given feature/driver is experimental, and introduce cfg option to enable
such features explicitly."

This commit implements this agreement, initially with Linuxbridge

Depends-On: https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/845646

[1] https://lists.openstack.org/pipermail/openstack-discuss/2022-April/028164.html

Change-Id: Ib18efa3f472736b58c8967847b1061da0e3897d7
2022-06-30 17:59:49 -05:00
Rodolfo Alonso Hernandez
6c92d7a307 [sqlalchemy-20] Remove unnecessary DB context
All "reserve_provider_segment" implementations create their own
DB contexts, if needed.

Related-Bug: #1976357
Change-Id: Ic5c8a80f1dc0bebbd117ad9b56365e8c606c112d
2022-06-30 19:55:21 +00:00
Ihar Hrachyshka
35fade3b5f ovn: use requested-chassis list format for live migration
This makes OVN asynchronously set up destination port while VMs
are being migrated, reducing network downtime.

Also configure 'rarp' activation strategy to wait until libvirt
notifies the network about new VM location with a RARP issued from
the vif.

Change-Id: I55811ea72b2bf0d0b244f422861dca4a7bf8f257
2022-06-30 19:32:48 +00:00
Rodolfo Alonso Hernandez
d3f711e7f6 [sqlalchemy-20] Add the needed DB context decorators in `ml2.plugin`
The method "_handle_segment_change" was handling the network DB object
outside a DB writer context.

Closes-Bug: #1980346
Related-Bug: #1976357
Change-Id: Ic79ad0f8e7fa1d55328e2315d87a3950fdb82258
2022-06-30 18:58:09 +00:00
Sahid Orentino Ferdjaoui
1bfbc33ce0 ovs: handle segmentation ids per network ports
This is changing the datastructure that maintains the relationship
between ports and networks to also handle the segmenation ids related.

This will be necessary in future to support multiple segments per
networks on a same physical provider network.

Partial-Bug: #1956435
Partial-Bug: #1764738
Signed-off-by: Sahid Orentino Ferdjaoui <sahid.ferdjaoui@industrialdiscipline.com>
Change-Id: Iaf40ddc20692a3a51a8d5f5acfc2094b2d5c00c4
2022-06-30 19:41:33 +02:00
Sahid Orentino Ferdjaoui
c9abb2cec3 ovs: remove unused function _get_port_local_vlan
Signed-off-by: Sahid Orentino Ferdjaoui <sahid.ferdjaoui@industrialdiscipline.com>
Change-Id: I611ed3233ea689fe3a7218f0cca7e9b0a44aa9ce
2022-06-30 19:32:40 +02:00
Zuul
7ebc8281e5 Merge "ovn: revert to stateful dnat_and_snat" 2022-06-30 16:38:00 +00:00
Rodolfo Alonso Hernandez
d7ba5948ff Replace "Inspector.from_engine()" with "sqlalchemy.inspect()"
Since SQLAlchemy 1.4, the method "Inspector.from_engine()" is
deprecated.

This patch is related to [1].

[1]https://review.opendev.org/c/openstack/neutron/+/808103

Related-Bug: #1943155
Change-Id: Ic26da2e20c0878204cf9565e173b4825cb36f34c
2022-06-29 18:42:18 +00:00
Rodolfo Alonso Hernandez
753fbff11b [FT] Ensure "update_virtual_port_host" has been called
An OVS DB event once matched, is stored in a cache and processed in
``ovsdbapp.event.RowEventHandler.notify_loop``. The method
``update_virtual_port_host`` is called in the ``run`` method of the
event. Sometimes in the FT execution, the test checks if the
method has been called when the event ``run`` method has not been
executed yet.

This patch adds a short active wait to ensure the event is actually
processed and the method called.

This bug can be easily reproduced if in the
``PortBindingUpdateVirtualPortsEvent.run`` method, a 2 seconds delay
is added:
  import time; time.sleep(2)

Closes-Bug: #1971672
Change-Id: I2e389e3cce70505ce01f03c09b36fa9d55be964a
2022-06-29 18:32:14 +00:00
Rodolfo Alonso Hernandez
d3ce69b946 [FT] Run all .*MySQL and .*PostgreSQL tests in an isolated thread
Similar to [1], this patch moves the PostgreSQL tests to a second
test execution step, where all tests are executed with one single
worker, avoiding any parallel execution on the SQL tests.

[1]https://review.opendev.org/c/openstack/neutron/+/834746

Closes-Bug: #1980127
Related-Bug: #1962594
Change-Id: I3a9f665653c3e2a5f75175867a45391e6ad01176
2022-06-29 15:03:33 +00:00
Rajesh Tailor
732c1dcbc2 Fix typos in error/log messages
This change fixes some typos in ERROR and LOG messages.

Change-Id: I4ec5b10cdd38bb8734b70d459b2afe99275cd8bd
2022-06-29 15:59:22 +05:30
renliang17
1e5d43a2f3 Mellanox_eth.img url expires, remove the mellanox_eth.img node
Mellanox_eth. Img download link failure,
delete the http://www.mellanox.com/repository/solutions/openstack/images/mellanox_eth.img node

Change-Id: I984dad79505b85822ffdd9a088a04b6ed5a14f27
2022-06-29 17:54:34 +08:00
e9a479519f Temporary make rally job non voting
Actual fix is already proposed in rally[1], but
rally CI is red for other issues, so to unblock
neutron gate let's temporary make this job
non-voting.

ovn rally job is already non-voting.

[1] https://review.opendev.org/c/openstack/rally-openstack/+/847879

Related-Bug: #1980055
Change-Id: I39c9db9f3a1eea3cea4f1f4979e0abdce6946bea
2022-06-28 21:02:25 +05:30
Zuul
095d0bc79b Merge "ovn-migration: Remove second tripleo-update call" 2022-06-28 13:41:54 +00:00
Zuul
f60f24d5d8 Merge "Modify the url of OVN tutorial" 2022-06-27 15:22:16 +00:00
Zuul
aa30bd1821 Merge "Filter the ports by VNIC type" 2022-06-27 15:22:10 +00:00
Zuul
4638febf02 Merge "Add policy for packet rate limit rules" 2022-06-27 15:08:45 +00:00
Zuul
a9912caf3f Merge "Use neutron-lib method update_qos_allocation" 2022-06-27 08:20:07 +00:00
wangkuntian
b1f4890102 Modify the url of OVN tutorial
Original url leads user to a markdown file, I think it's better to
use official html document rather than a markdown file.

Change-Id: Ib3ee4c6bccbb98a6469e2d7e9cde652288bbb163
2022-06-27 06:09:56 +00:00
Takashi Kajinami
17106dc6f5 ml2: Use the base module to register common ml2 agent config
The neutron.plugins.ml2.drivers.agent.config module registers options
commonly used by the ml2 agents but in fact it is used only by linux
bridge agent and macvtap agent.

This change makes all ml2 agents use that base module consistently in
individual config modules.

Change-Id: Ib3ec8a8eaf347721bb06f092a0887e62f3a6bffd
2022-06-24 12:58:31 +00:00
Zuul
f8673c0516 Merge "Fullstack tests of packet rate limit for ovs qos driver" 2022-06-24 11:01:44 +00:00
Zuul
088d115978 Merge "Add a release note for 834162" 2022-06-24 09:31:34 +00:00
Nurmatov Mamatisa
738fb24f44 Use neutron-lib method update_qos_allocation
Method update_qos_allocation was modified and released
in neutron-lib [1] so can be removed from neutron code

1) https://review.opendev.org/c/openstack/neutron-lib/+/813660

Change-Id: Iebf38c0d4d01559b799eebee7221ed1f3b9baf6d
2022-06-24 08:14:22 +00:00
Damian Dabrowski
2365abfd00 Add a release note for 834162
I forgot to write a release note when pushing change 834162 [1].
It may be an important change for operators so it's good to have a
release note about that.

[1] https://review.opendev.org/c/openstack/neutron/+/834162

Related-Bug: #1952907
Change-Id: Ie707f461af11357d6eaa004bc98c7eb09a62202f
2022-06-23 22:18:44 +02:00
Jakub Libosvar
60fade43de ovn-migration: Remove second tripleo-update call
The second tripleo-update call was there only to update back integration
bridge variable. However the action did the whole deploy for all nodes
in the environment, which can take hours to finish. This patch relies on
other patch in THT that sets br-int as default value. This way once
ovn-extras.yml is not used and the integration bridge is not overriden,
we no longer need to update tripleo about the value so it's safe to
remove the second call.

Depends-On: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/847402
Change-Id: I7455852898bb6e9698ecf5261d4401bc5077c506
Signed-off-by: Jakub Libosvar <libosvar@redhat.com>
2022-06-23 15:16:16 -04:00