27641 Commits

Author SHA1 Message Date
Zuul
d2b5ad4ac5 Merge "Make unit tests compatible with neutron-lib-3.9.0" 2023-11-20 19:13:44 +00:00
Zuul
5c3f1cd02f Merge "Update OVN db sync code log messages" 2023-11-20 15:25:46 +00:00
Zuul
9694c64bf0 Merge "Forbid updating vnic type on a bound port" 2023-11-20 15:25:41 +00:00
95b4e8f41d Make unit tests compatible with neutron-lib-3.9.0
A new flag was added with [1], adapt unit tests with it.
Also drop an older compatibility check which is no longer
needed as neutron-lib>=3.8.0 already.

[1] https://review.opendev.org/c/openstack/neutron-lib/+/895940
Needed-By: https://review.opendev.org/c/openstack/requirements/+/901231
Closes-Bug: #2043959

Change-Id: I3b48b418d2d1293cdcf8fefb1b9ff7005bbebb29
2023-11-20 12:34:10 +05:30
Zuul
6514e37e47 Merge "[CI] Remove py310-with-sqlalchemy-master job" 2023-11-15 18:15:41 +00:00
Zuul
3ebf243c6a Merge "[OVN] Update the External Ports documentation" 2023-11-15 15:10:42 +00:00
Zuul
07a7a25eed Merge "Use py311 for all neutron jobs" 2023-11-15 14:11:57 +00:00
Zuul
c595032032 Merge "Catch non-existent entry failures better in ip_lib" 2023-11-15 14:11:53 +00:00
Jakub Libosvar
354205a423 Forbid updating vnic type on a bound port
The vnic type should not be changed once the port is bound since it's
related to the actual port binding. The patch validates the port update
operation and fails the update if the vnic type is attempted to be
changed on a bound port.

Closes-bug: #2033090
Change-Id: I5cb79d9da96ba41a7787083c81f522c328fae049
Signed-off-by: Jakub Libosvar <libosvar@redhat.com>
2023-11-15 13:59:46 +00:00
Zuul
fd36c483a3 Merge "Fix modified-iterating-list pylint warning" 2023-11-15 12:43:57 +00:00
Zuul
20222c85ad Merge "[OVN] Remove logic for old localnet port naming" 2023-11-15 12:43:53 +00:00
8d7d6f154b [CI] Remove py310-with-sqlalchemy-master job
It's all uses are removed with the Depends-On.

Depends-On: https://review.opendev.org/c/openstack/neutron-lib/+/901009
Change-Id: Ifecd75eb80355c96caa4135ce6abe40ac62ba57b
2023-11-15 16:39:00 +05:30
Brian Haley
fb9437ca25 Use py311 for all neutron jobs
There are three job definitions here for testing
neutron with the master branches of other projects,
specifically neutron-lib, oslo, and ovsdbapp. As
neutron is no longer testing py310 in its master
gate, start using the py311 versions of these jobs
so we can move forward.

Also moved the sqlalchemy job to start using py311
as well.

Depends-on: https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/899745
Change-Id: Iec1d5fcdfd8c85a3edb5bc9a399d44839fbc879a
2023-11-15 16:29:45 +05:30
Zuul
1cd4c0a475 Merge "[OVN] Enhanced external port scheduling" 2023-11-15 10:34:18 +00:00
Zuul
5f2777f137 Merge "Get default value for BFD/ECMP extra attributes from config" 2023-11-15 03:45:19 +00:00
Zuul
0027928c34 Merge "Remove obsolete PID files before start" 2023-11-14 18:02:53 +00:00
Lucas Alvares Gomes
cd8816acd1 [OVN] Update the External Ports documentation
This patch is part of the solution for LP #2037294 and updates the
documentation to explain the new "enable-chassis-as-extport-host"
configuration as well as enhancing the documentation in general
to better explain each configuration, database information and
high availability for external ports.

Change-Id: Iad048a71653dc791fc27585b509c02470e5d08a2
Related-Bug: #2037294
Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com>
2023-11-14 08:55:01 +00:00
Lucas Alvares Gomes
770914f98d [OVN] Enhanced external port scheduling
This patch introduces a new configuration for OVN CMS Options called
"enable-chassis-as-extport-host". This configuration can be used
by ML2/OVN to identify nodes that are eligible for scheduling OVN's
external ports.

Prior to this patch, external ports were always scheduled on centralized
networked nodes tagged with the "enable-chassis-as-gw" flag in the OVN
CMS Options but, when it comes to deploying OpenStack on OpenShift
requiring services such as the OVN Metadata Agent or DHCP Agent to
serve those external ports and running them on control plane nodes are
not ideal. This is where this patch comes handy allowing these ports to
have more flexibility in where they are scheduled.

The patch is also backward compatible and if the new configuration is
not present on the OVN CMS Options, ML2/OVN will continue to schedule
the external ports on nodes configured with the previous configuration
like always.

Documentation will be updated on a follow up patch.

Closes-Bug: 2037294
Change-Id: Ic46d847e3aebfe543d5a7ab49d18d1f1abf1342e
Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com>
2023-11-14 08:54:59 +00:00
Luis Tomas Bolivar
f2a3020cf0 Ensure ovn loadbalancer FIPs are centralized upon neutron restarts
When neutron server restarts the mac address for NAT entries related
to ovn-lb FIPs gets re-added, distributing the traffic that should
be centralized and therefore breaking the connectivity. This happens
due to the port being down. This patch is ensuring the MAC entry
is only being readded in case the port is UP

Closes-Bug: #2042938
Change-Id: I6203009750a4e589eeb808f842cb522d61476179
2023-11-13 16:42:51 +01:00
Zuul
b1585c52dc Merge "[Fullstack] Drop all linuxbridge scenarios from fullstack tests" 2023-11-10 17:56:16 +00:00
Zuul
56e39eda07 Merge "Revert "Make job openstack-tox-py310-with-sqlalchemy-master non-voting temporary"" 2023-11-10 16:02:55 +00:00
618478d304 Revert "Make job openstack-tox-py310-with-sqlalchemy-master non-voting temporary"
This reverts commit e1b4a065c73ef7a97ac5451a3d8f60ba30e086a1.

Depends-On: https://review.opendev.org/c/openstack/requirements/+/900517
Reason for revert: Issue fixed in oslo.utils 6.3.0
Closes-Bug: #2042939

Change-Id: Ia8e97c6dd2ae60ddfd180e580830a263c473c576
2023-11-09 12:57:53 +00:00
Slawek Kaplonski
688c5e2a91 [Fullstack] Drop all linuxbridge scenarios from fullstack tests
As we discussed on the Neutron CI meeting on 7.11.2023 (it was video
meeting, no strict logs stored) [1], to save some time in the fullstack
job execution we want to stop running all the Linuxbridge related
tests/scenarios in fullstack test suite.
Linuxbridge is experimental feature now, not really fully supported by
the Neutron team so we are allowed to do so in this case.
This patch is doing exactly that. There are no any Linuxbridge agent
related tests/scenarios.

Support for Linuxbridge in the Fullstack framework wasn't however
removed completely. It is like that because of 2 reasons:

* there is one DHCP agent related test which tests different segments
  and is using Linuxbridge agent on one of the fake nodes,
* maybe there will be at some point need to have some Linuxbridge agent
  test there so the infrastructure for that is still available, it won't
  cause any issues while it's (almost) not used currently.

[1] https://meetings.opendev.org/meetings/neutron_ci/2023/neutron_ci.2023-11-07-15.00.html

Change-Id: I709c477f66ada037e47ec9abc7fbed1d1a238d20
2023-11-09 10:19:32 +01:00
Brian Haley
e13aea6b8c Fix modified-iterating-list pylint warning
In test_ovn_nb_sync_mode_repair(), create_port_list is
modified while being iterated, use a copy.

TrivialFix

Change-Id: I3251226446ea416e6f29ba6b444169d6d49d067f
2023-11-08 15:08:11 -05:00
Takashi Kajinami
9bab423bf3 [OVN] Remove logic for old localnet port naming
The logic was added by [1] in addition to the maintenance task
(check_for_localnet_legacy_port_name) to update the old name.

The maintenance task was already removed by [2] because it has been
kept for enough cycles so we can also remove the logic to support
old naming before migration by the task.

[1] 483f468fdd5bb549f763d0507e0a7ac1106eb85a
[2] d966845e5b80b1cec3cbfe25e4a7e1542e9fca65

Change-Id: I24328e6c1f9b907d402eb34f9b4d98e3d182e636
2023-11-09 01:02:55 +09:00
Zuul
26f1734239 Merge "ovn: Spawn metadata resources on additional chassis event" 2023-11-08 02:16:03 +00:00
Zuul
e48b0b8843 Merge "Validate [designate] ipvN_ptr_zone_prefix_size at config layer" 2023-11-07 22:45:59 +00:00
Zuul
3bccc6ff45 Merge "Make job openstack-tox-py310-with-sqlalchemy-master non-voting temporary" 2023-11-07 17:35:11 +00:00
Slawek Kaplonski
e1b4a065c7 Make job openstack-tox-py310-with-sqlalchemy-master non-voting temporary
Related-bug: #2042939
Change-Id: I3eee48af327687455453ab6b8d5afb9e137b547c
2023-11-07 15:29:39 +01:00
Takashi Kajinami
a555a274e6 Validate [designate] ipvN_ptr_zone_prefix_size at config layer
This change re-implements validation of ipvN_ptr_zone_prefix_size at
config definition layer. This brings a few benefits.
 - The validation is executed at an earlier stage
 - The validation can be leveraged by the oslo-config-validator.

Change-Id: Ib72109bcb537b3e44719efb6f33ea46f0d45a1ef
2023-11-05 14:15:29 +09:00
Zuul
f99da4d15c Merge "get_hosts_mapped_with_segments add filter agt_type" 2023-11-03 17:41:43 +00:00
Zuul
dfa6dc4c0e Merge "[DHCP agent] Add route to OVN metadata port if exists" 2023-11-02 21:03:07 +00:00
Zuul
1daa0dd5bf Merge "ovn-metadata: Refactor events" 2023-10-31 12:57:05 +00:00
Zuul
fbca7f0104 Merge "[OVN] Populate the "router.distributed" flag in ML2/OVN" 2023-10-30 15:05:09 +00:00
Zuul
0f3cbde095 Merge "Use convert_version_to_tuple() throughout tree" 2023-10-30 11:37:32 +00:00
Zuul
04d982746e Merge "[Docs] Fix info about provider bridge name in the bridge_mappings" 2023-10-27 18:20:06 +00:00
Slawek Kaplonski
842f2f8e6c [Docs] Fix info about provider bridge name in the bridge_mappings
Previously in all our install guides there were info that name of the
physical interface should be put in the bridge_mappings config option in
ths OVS agent's config. This wasn't correct as bridge_mappings expects
there bridge name instead.

Change-Id: I0698aa4621a15c1927ad2c352501cea02e6ee70c
2023-10-27 17:57:41 +02:00
49b83c0561 Update job overrides for Caracal release
Target jobs are updated for Caracal release[1],
Let's update job overrides as per it.

[1] https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/891238

Change-Id: Id8bcf25004bb52f91a412872269ab6d93fb04d53
2023-10-27 10:16:59 +05:30
Zuul
53f4fd6b9f Merge "doc: Fix wrong sections of ovs-agent config options" 2023-10-26 18:36:56 +00:00
Zuul
f90d7d2a9e Merge "[FT] Clear the idl lock in TestMaintenance tests" 2023-10-26 10:17:42 +00:00
Takashi Kajinami
34f7a5805e doc: Fix wrong sections of ovs-agent config options
The sections described in the documentation does not match the actual
section names in current neutron.

 * local_ip now belongs to the [ovs] section
 * tunnel_types now belongs to the [agent] section
 * l2_population now belongs to the [agent] section

Also the tunnel_types option is not explained in the example snippet.

Change-Id: Ic2bde217a03a884855d299f3142394a4229745bc
2023-10-26 09:00:56 +09:00
Zuul
389bc155f8 Merge "doc: Stop configuring authtoken middleware in compute" 2023-10-25 23:58:36 +00:00
Zuul
cc84cfeba3 Merge "doc: Remove remaining description about allow_overlapping_ips" 2023-10-25 23:51:04 +00:00
39a1f1e7fd [FT] Clear the idl lock in TestMaintenance tests
One or the other test in TestMaintenance fails
randomly with missing idl lock.

DBInconsistenciesPeriodics set's the idl lock
but in TestMaintenance we don't run it as a seperate
maintenance worker and instead call check_for_inconsistencies
when needed so not a requirement to have a dedicated lock.
This patch clears the lock for these tests to avoid
such random issues.

Closes-Bug: #2039417
Change-Id: I931997fe010295120f2400b1ec310dff82497ab6
2023-10-25 21:21:54 +05:30
Harald Jensås
64b5787c32
get_hosts_mapped_with_segments add filter agt_type
Extend the get_hosts_mapped_with_segments method to add
optional filters to include/exclude based on agent type.
Uses a joined query, when both include and exclude
filtering is used togheter the exclude filter is most
significant.

Partial-Bug: #2040172

Change-Id: I2cfd52a2657fad989e24e974fda470ecd960262b
Signed-off-by: Harald Jensås <hjensas@redhat.com>
2023-10-25 16:31:30 +02:00
Takashi Kajinami
2bcad25d34 doc: Stop configuring authtoken middleware in compute
... because the middleware is used only by neutron-server.

This also removes the metadata shared secret from compute, because
metadata-agent runs only in controller nodes according to the guide.

Change-Id: I0e5ed7453384d24581bcd8c3a85c8fc36fab910f
2023-10-25 11:26:51 +09:00
Takashi Kajinami
2a637820eb doc: Remove remaining description about allow_overlapping_ips
The option was already removed.

Change-Id: Ic1bcec77e3ef1bac5dc59d5f492348ee9ac9993e
2023-10-25 11:24:51 +09:00
Zuul
f185379980 Merge "Add support for FDB aging" 2023-10-24 16:00:17 +00:00
Luis Tomas Bolivar
1e9f50c736 Add support for FDB aging
In [1] we added support for FDB learning. In order to avoid issues
due to that table increasing without limits, which will impact OVN
performance, this patch is adding support for its aging mechanisms
which was added in OVN 23.09 in [2]. By default is disabled, so if
`localnet_learn_fdb` is enabled, the new configuration parameters
should be appropriately configured too: `fdb_age_threshold` and
`fdb_removal_limit`

[1] https://review.opendev.org/c/openstack/neutron/+/877675
[2] ae9a548882

Closes-Bug: 2035325

Change-Id: Ifdfaec35cc6b52040487a2b5ee08aba9282fc68b
2023-10-24 08:25:03 +00:00
Brian Haley
bd0fec95fa Use convert_version_to_tuple() throughout tree
Most code uses convert_version_to_tuple() from
oslo_utils.versionutils to determine minimum version
numbers, but there were two places that used the
packaging.version class instead. Change to always
use the same code throughout the tree.

Also added a flake8 enforcement check for it so we
don't regress.

TrivialFix

Change-Id: Ida4dcd504562646f0a450160e57680a44c387b1d
2023-10-20 18:03:21 -04:00