7a2a85623d
Oslo project decided to move away from using oslo.* namespace for all their libraries [1], so we should migrate to new import path. This patch applies new paths for: - oslo.config - oslo.db - oslo.i18n - oslo.messaging - oslo.middleware - oslo.rootwrap - oslo.serialization - oslo.utils Added hacking check to enforce new import paths for all oslo libraries. Updated setup.cfg entry points. We'll cleanup old imports from oslo-incubator modules on demand or if/when oslo officially deprecates old namespace in one of the next cycles. [1]: https://blueprints.launchpad.net/oslo-incubator/+spec/drop-namespace-packages Depends-On: https://review.openstack.org/#/c/147248/ Depends-On: https://review.openstack.org/#/c/152292/ Depends-On: https://review.openstack.org/#/c/147240/ Closes-Bug: #1409733 Change-Id: If0dce29a0980206ace9866112be529436194d47e
33 lines
1.3 KiB
ReStructuredText
33 lines
1.3 KiB
ReStructuredText
Neutron Style Commandments
|
|
=======================
|
|
|
|
- Step 1: Read the OpenStack Style Commandments
|
|
http://docs.openstack.org/developer/hacking/
|
|
- Step 2: Read on
|
|
|
|
Neutron Specific Commandments
|
|
--------------------------
|
|
|
|
- [N319] Validate that debug level logs are not translated
|
|
- [N320] Validate that LOG messages, except debug ones, have translations
|
|
- [N321] Validate that jsonutils module is used instead of json
|
|
- [N322] Detect common errors with assert_called_once_with
|
|
- [N323] Enforce namespace-less imports for oslo libraries
|
|
|
|
Creating Unit Tests
|
|
-------------------
|
|
For every new feature, unit tests should be created that both test and
|
|
(implicitly) document the usage of said feature. If submitting a patch for a
|
|
bug that had no unit test, a new passing unit test should be added. If a
|
|
submitted bug fix does have a unit test, be sure to add a new one that fails
|
|
without the patch and passes with the patch.
|
|
|
|
All unittest classes must ultimately inherit from testtools.TestCase. In the
|
|
Neutron test suite, this should be done by inheriting from
|
|
neutron.tests.base.BaseTestCase.
|
|
|
|
All setUp and tearDown methods must upcall using the super() method.
|
|
tearDown methods should be avoided and addCleanup calls should be preferred.
|
|
Never manually create tempfiles. Always use the tempfile fixtures from
|
|
the fixture library to ensure that they are cleaned up.
|