openstack/openstacksdk
Code Issues Proposed changes

Merge "Fix Port resource properties"

Browse Source
This commit is contained in:
Jenkins
2016-02-03 20:29:44 +00:00
committed by Gerrit Code Review
parent 7b978a0a64 e5d0e74469
commit 5d723e1d26
2 changed files with 21 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
openstack/network/v2/port.py
View File

@@ -31,19 +31,20 @@ class Port(resource.Resource):
#: The administrative state of the port, which is up ``True`` or
#: down ``False``. *Type: bool*
admin_state_up = resource.prop('admin_state_up', type=bool)
#: Allowed address pairs. *Type: dict*
allowed_address_pairs = resource.prop('allowed_address_pairs', type=dict)
#: Allowed address pairs.
allowed_address_pairs = resource.prop('allowed_address_pairs')
#: The ID of the host where the port is allocated. In some cases,
#: different implementations can run on different hosts.
binding_host_id = resource.prop('binding:host_id')
#: A dictionary the enables the application running on the specified
#: host to pass and receive vif port-specific information to the plug-in.
binding_profile = resource.prop('binding:profile')
#: *Type: dict*
binding_profile = resource.prop('binding:profile', type=dict)
#: Read-only. A dictionary that enables the application to pass
#: information about functions that the Networking API provides.
#: To enable or disable port filtering features such as security group
#: and anti-MAC/IP spoofing, specify ``port_filter: True`` or
#: ``port_filter: False``.
#: ``port_filter: False``. *Type: dict*
binding_vif_details = resource.prop('binding:vif_details', type=dict)
#: Read-only. The vif type for the specified port.
binding_vif_type = resource.prop('binding:vif_type')
@@ -62,8 +63,12 @@ class Port(resource.Resource):
device_id = resource.prop('device_id')
#: The ID of the entity that uses this port. For example, a dhcp agent.
device_owner = resource.prop('device_owner')
#: DNS assignment for the port.
dns_assignment = resource.prop('dns_assignment')
#: DNS name for the port.
dns_name = resource.prop('dns_name')
#: Extra DHCP options.
extra_dhcp_opts = resource.prop('extra_dhcp_opts', type=dict)
extra_dhcp_opts = resource.prop('extra_dhcp_opts')
#: IP addresses for the port. Includes the IP address and subnet ID.
fixed_ips = resource.prop('fixed_ips')
#: The MAC address of the port.
@@ -75,8 +80,8 @@ class Port(resource.Resource):
#: The ID of the project who owns the network. Only administrative
#: users can specify a project ID other than their own.
project_id = resource.prop('tenant_id')
#: The IDs of any attached security groups.
security_groups = resource.prop('security_groups')
#: The IDs of any attached security groups. *Type: list*
security_groups = resource.prop('security_groups', type=list)
#: The port status. Value is ``ACTIVE`` or ``DOWN``.
status = resource.prop('status')
#: The port security status, which is enabled ``True`` or disabled

14
openstack/tests/unit/network/v2/test_port.py
View File

@@ -17,24 +17,26 @@ from openstack.network.v2 import port
IDENTIFIER = 'IDENTIFIER'
EXAMPLE = {
'admin_state_up': True,
'allowed_address_pairs': {'2': 2},
'allowed_address_pairs': [{'2': 2}],
'binding:host_id': '3',
'binding:profile': '4',
'binding:profile': {'4': 4},
'binding:vif_details': {'5': 5},
'binding:vif_type': '6',
'binding:vnic_type': '7',
'device_id': '8',
'device_owner': '9',
'extra_dhcp_opts': {'10': 10},
'fixed_ips': {'11': '12'},
'extra_dhcp_opts': [{'10': 10}],
'fixed_ips': [{'11': '12'}],
'id': IDENTIFIER,
'mac_address': '13',
'name': '14',
'network_id': '15',
'tenant_id': '16',
'security_groups': '17',
'security_groups': ['17'],
'status': '18',
'port_security_enabled': True,
'dns_assignment': [{'19': 19}],
'dns_name': '20',
}
@@ -76,3 +78,5 @@ class TestPort(testtools.TestCase):
self.assertEqual(EXAMPLE['status'], sot.status)
self.assertEqual(EXAMPLE['port_security_enabled'],
sot.is_port_security_enabled)
self.assertEqual(EXAMPLE['dns_assignment'], sot.dns_assignment)
self.assertEqual(EXAMPLE['dns_name'], sot.dns_name)