748 Commits

Author SHA1 Message Date
Jenkins
0055d25eaf Merge "Fixes test_two_pools_three_listener" 2015-01-16 13:34:52 +00:00
Jenkins
a38494d48d Merge "fix qpid test issue with eventlet monkey patching" 2015-01-16 11:07:28 +00:00
Mehdi Abaakouk
b888ee3ebf Fixes test_two_pools_three_listener
The Notification Listener Tracker class is not threadsafe,
so when a test stop an already stopped listener this one
can be restarted, due to concurrency access of the threads list and
concurrency execution of the start/stop/wait method of the notification
listener.
This result of a lockup of the test or a listener can continue to
got unepxected message.

This change fixes that by never stop the tread with the tracker callback
but only manually with the test.

This test also rename some 'Listener' to 'Server', to not mismatch
the driver listener from the notification listener.

Closes-bug: #1410902

Change-Id: I4777c7dd0ba71c61850d36641e85f33f9461e9c1
2015-01-16 09:43:03 +01:00
Mehdi Abaakouk
be9fca7f6f fix qpid test issue with eventlet monkey patching
I516c580faef04f55fcc095d22adbfabcfa001da7 have been
merged just after the namespace change patch, but change only
the old test directory.

So reapply I516c580faef04f55fcc095d22adbfabcfa001da7 to the
new test directory.

Change-Id: I5cd7d7b6c507967e7fb4744012b2ad215c4f1ad3
Closes-Bug: #1409899
2015-01-15 15:00:41 +01:00
Dan Prince
0ca1b1e6a1 Make setup.cfg packages include oslo.messaging
This properly deploys the oslo.messaging package may resolve
sphinx build errors for projects which have not yet
upgraded to oslo_messaging.

Change-Id: I4db750fb2356ebf44a8fccf7c422b474fefec0ee
2015-01-15 08:47:02 -05:00
Mehdi Abaakouk
408d0da9be Upgrade to hacking 0.10
Change-Id: I7930988fd9ed9da27c6c333f865f54edfb5ff812
2015-01-14 09:04:22 +01:00
Victor Stinner
bc8675afb0 fix qpid test issue with eventlet monkey patching
Tests now ensure that eventlet monkey patching is enabled before
importing the qpid module, otherwise qpid will hang.

Currently, qpid randomly hangs, depending on the order of the Python
module import, which probably depends on the local file modification
time.

Closes-Bug: #1409899
Change-Id: I516c580faef04f55fcc095d22adbfabcfa001da7
2015-01-13 10:35:02 +00:00
Doug Hellmann
e55a83e832 Move files out of the namespace package
Move the public API out of oslo.messaging to oslo_messaging. Retain
the ability to import from the old namespace package for backwards
compatibility for this release cycle.

bp/drop-namespace-packages

Co-authored-by: Mehdi Abaakouk <mehdi.abaakouk@enovance.com>
Change-Id: Ia562010c152a214f1c0fed767c82022c7c2c52e7
2015-01-12 12:50:41 -05:00
Jenkins
8102f25dd2 Merge "Fix some comments in a backporting review session" 2015-01-08 19:23:39 +00:00
Jenkins
c45ad9ebfe Merge "Add a info log when a reconnection occurs" 2015-01-08 19:22:13 +00:00
Mehdi Abaakouk
31a149a4df Add a info log when a reconnection occurs
This change adds a info log when a reconnection occurs
like we have before.

Change-Id: I3b7d86894efac09e27125c368fc83e83c36b630e
2015-01-07 21:30:22 +00:00
Mehdi Abaakouk
44132d4344 rabbit: fix timeout timer when duration is None
When the duration of the timeout timer used in the rabbit driver.is
None and we want that the timer return a maximum of N secs it return None
(infinite) instead of N.

This change fixes that.

Closes-bug: #1408370

Change-Id: I7f4cb3075f776c63aa7dc497173677f92b68c16d
2015-01-07 21:30:01 +00:00
Jenkins
f31f519e15 Merge "Don't log each received messages" 2015-01-07 20:21:41 +00:00
Mehdi Abaakouk
c18f9f7c61 Don't log each received messages
oslo.utils.strutils.mask_password take too much time on
big payload (nova-conductor can receive payload ~ 66k in
largeops jobs for example).

This change removes this logging until we make mask_password
more efficient or we have a smarted the oslo.messaging logging to
not log everything.

Change-Id: Ib1f1d70c5cb820e8ff2de10e6064037808ea1f3a
Closes-bug: #1408362
2015-01-07 18:27:32 +01:00
Jenkins
1949c7641d Merge "Add an optional executor callback to dispatcher" 2015-01-06 20:54:25 +00:00
Jie Li
3e2d142a87 Fix some comments in a backporting review session
* add i18n support to some exception messages
  * remove the return value of DecayingTimer.start()

Relates to review: I898a236a384b3466147026abc7a1ee21801e8ca1

Change-Id: I7adf5478732f1f46db1009b059b66ff8af6ecdc3
2014-12-27 12:01:25 +08:00
Jenkins
84f18e8167 Merge "safe_log Sanitize Passwords in List of Dicts" 2014-12-23 23:27:05 +00:00
Jenkins
c575df2fdb Merge "Enable IPv6-support in libzmq by default" 2014-12-21 03:48:36 +00:00
Jenkins
39e4a0bcc4 Merge "Add a thread + futures executor based executor" 2014-12-21 03:44:32 +00:00
Jenkins
4b1fcd3622 Merge "Fix incorrect attribute name in matchmaker_redis" 2014-12-19 09:53:43 +00:00
Frode Nordahl
c40ba040a6 Enable IPv6-support in libzmq by default
Change-Id: I53790e5492ebf026e0b331ecb3c294da89603540
Closes-Bug: 1389137
2014-12-19 09:41:46 +01:00
Joshua Harlow
372bc4947e Add a thread + futures executor based executor
The concurrent.futures module is one of the ways
that async activities can be done in the future,
so we should try to work on getting to that future
by using more futures. To enable this (as well as
to enable getting off eventlet), add a thread pool
based executor which will process incoming messages
using the pool.

Also begins adding according docs as well for the
different types of executors that are available.

Change-Id: I1482fd70abbf69f4e2994597c5e95d91fecb815e
2014-12-18 23:49:53 -08:00
Jenkins
3129701354 Merge "Don't allow call with fanout target" 2014-12-16 22:12:12 +00:00
Mehdi Abaakouk
56a9c55a3f safe_log Sanitize Passwords in List of Dicts
Sanitizes password fields found in lists of dicts for messages
before logging.

This change uses oslo.utils.strutils.mask_password to do it.

Change-Id: I7cd1e53e2ced7ebf9c5942b7a0dbbeb991acab4d
Closes-Bug: #1268459
2014-12-16 16:17:46 +00:00
Jenkins
dcf264221b Merge "Updated from global requirements" 2014-12-12 14:48:50 +00:00
Jenkins
935b5bd5fa Merge "rabbit: add some tests when rpc_backend is set" 2014-12-12 12:43:31 +00:00
Jenkins
85cd841ae7 Merge "Make the RPCVersionCapError message clearer" 2014-12-11 19:17:34 +00:00
Jenkins
fa68eaa280 Merge "Add functional and unit 0mq driver tests" 2014-12-11 09:55:31 +00:00
OpenStack Proposal Bot
709c401cb8 Updated from global requirements
Change-Id: I55eed75a9d6a8375823480220b8312eb255e417a
2014-12-11 07:19:31 +00:00
Mehdi Abaakouk
98bfdd1d34 rabbit: add some tests when rpc_backend is set
This change improves test coverage of the rabbit driver for new
value allowed in rpc_backend config option.

Change-Id: I52a8a8beb5b0d32647f52bb21abd5f7164dac2df
2014-12-11 07:15:43 +00:00
Jenkins
f6be71c503 Merge "Warns user if thread monkeypatch is not done" 2014-12-10 16:54:22 +00:00
Mehdi Abaakouk
d3e6ea1788 Warns user if thread monkeypatch is not done
This change warns the user that it does have monkeypatched the
oslo.messaging library correclty.

Change-Id: Ice80ffc6cbc39919eac4bc0809992daea51b5922
Closes-bug: #1288878
2014-12-10 15:59:59 +01:00
Jenkins
cb4c5bce0b Merge "The executor doesn't need to set the timeout" 2014-12-10 13:05:31 +00:00
Jenkins
9cc46bafb0 Merge "qpid: honor iterconsume timeout" 2014-12-10 13:04:50 +00:00
Jenkins
afed2e8579 Merge "rabbit: more precise iterconsume timeout" 2014-12-10 12:59:34 +00:00
James Page
cd71c47d32 Add functional and unit 0mq driver tests
Basic functional and unit tests for zmq driver.

Note as the zmq driver is directly dependent on eventlet, this
change also updates the notify logger tests to remove the
direct dependency on threading which was being monkey patched,
causing test failures.

As the zmq driver has a direct dependency on eventlet, tests are
skipped under py3.

Co-Authored-By: Kapil Thangavelu <kapil.thangavelu@canonical.com>
Co-Authored-By: Edward Hope-Morley <edward.hope-morley@canonical.com>

Change-Id: I93b8b2e92d0f2a353d3357a5e61f6d472ec84944
Partial-bug: #1302941
2014-12-09 15:02:31 +00:00
Jenkins
836f16f3fe Merge "Doc: 'wait' releases driver connection, not 'stop'" 2014-12-09 11:59:05 +00:00
Mehdi Abaakouk
15aa5cbda8 The executor doesn't need to set the timeout
It's up to the driver to set a suitable timeout for polling the broker,
this one can be different that the one requested by the driver
caller as long as the caller timeout is respected.

This change also adds a new driver listener API, to be able
to stop it cleanly, specially in case of timeout=None.

Closes bug: #1400268
Closes bug: #1399257
Change-Id: I674c0def1efb420c293897d49683593a0b10e291
2014-12-08 12:59:33 +01:00
Mehdi Abaakouk
43a9dc1de5 qpid: honor iterconsume timeout
The qpid driver must always honor the timeout passed the iterconsume
method, this change fixes that.

Related bug: #1400268
Related bug: #1399257

Change-Id: I8f267fc8b5a7abc852f0caf84d1e7c2c342ba951
2014-12-08 12:08:12 +01:00
Mehdi Abaakouk
023b7f44e2 rabbit: more precise iterconsume timeout
The iterconsume always set the timeout of kombu to 1 second
even the requested timeout more precise or < 1 second.

This change fixes that.

Related bug: #1400268
Related bug: #1399257

Change-Id: I157dab80cdb4afcf9a5f26fa900f96f0696db502
2014-12-08 12:08:01 +01:00
Jenkins
f4bb707bc3 Merge "Workflow documentation is now in infra-manual" 2014-12-05 15:35:22 +00:00
Jenkins
a7f3ecb360 Merge "Touch up grammar in warning messages" 2014-12-05 09:58:33 +00:00
Jeremy Stanley
737afde2e1 Workflow documentation is now in infra-manual
Replace URLs for workflow documentation to appropriate parts of the
OpenStack Project Infrastructure Manual.

Change-Id: I1ba19377ed279ccb9f8d698b15678c528cbeade3
2014-12-05 03:30:39 +00:00
Jenkins
d2105f61f8 Merge "Add more TLS protocols to rabbit impl" 2014-12-04 22:18:09 +00:00
Jenkins
1834167b4f Merge "Warn user if needed when the process is forked" 2014-12-04 21:47:03 +00:00
Doug Hellmann
66db2b310d Touch up grammar in warning messages
Change-Id: I556e6e646417be3732a7c31987ec964f9808f079
2014-12-04 16:04:37 -05:00
Jenkins
bf9fd263f9 Merge "Fix reconnect race condition with RabbitMQ cluster" 2014-12-04 14:52:28 +00:00
Mehdi Abaakouk
712f6e3c5e Reintroduces fake_rabbit config option
This change reintroduces the fake_rabbit only for backward compatibility,
but mark it as deprecated.

Now, to use the kombu in-memory driver (that is not thread safe) we must
set the transport_url config option to 'kombu+memory:////" or the
rpc_backend to kombu+memory.

Or we can use the fake driver of oslo.messaging by setting the
transport_url to 'fake:///' or the rpc_backend to 'fake'

This is effectively reverting commit bcb3b23b8f6e7d01e38fdc031982558711bb7586.

Closes-bug: #1399085

Change-Id: I7b6fb3811fc6f695f75ecd350e04e69afd26c428
1.5.1
2014-12-04 11:54:58 +00:00
Nikola Dipanov
4e6dabb698 Make the RPCVersionCapError message clearer
It is confusing to report that the version cap is too low, rather we
should report that the message version is too high.

Change-Id: Ic37eabb6f211fb68ca567ed4c400a1314e25cc68
2014-12-04 12:13:59 +01:00
Mehdi Abaakouk
254405d105 Doc: 'wait' releases driver connection, not 'stop'
This change documents that MessageHandlingServer.wait
the released driver resources associated to this
MessageHandlingServer instance.

Like closing network connections to the broker.

Closes bug: #1397459

Change-Id: I3b0710faeb32ca8e9ee09b14aa1f79290c6061f5
2014-12-03 18:23:19 +01:00