The key, value pair returned by items() wasn't used here,
so rewrite the logic to just iterate over the keys, filtered
by the type.
Change-Id: I7512ea93ac794d161a4cd9944546d6ca035a12cf
openstack-dev was decomissioned this night in https://review.openstack.org/621258
Update openstack-dev to openstack-discuss
Change-Id: I7d889d3f9a6c95e707ed57dbf5a9cffb1d41ddf5
This patch switches the kafka python client from kafka-python to
confluent-kafka due to documented threading issues with the
kafka-python consumer and the recommendation to use multiplrocessing.
The confluent-kafka client leverages the high performance librdkafka
C client and is safe for multiple thread use.
This patch:
* switches to confluent-kafka library
* revises consumer and producer message operations
* utilizes event.tpool method for confluent-kafka blocking calls
* updates unit tests
* adds kafka specific timeouts for functional tests
* adds release note
Depends-On: Ice374dca539b8ed1b1965b75379bad5140121483
Change-Id: Idfb9fe3700d882c8285c6dc56b0620951178eba2
A change to the global-requirements has limited use of monotonic
library to Python versions earlier than 3.3 (later versions have
built-in support for a monotonic clock), so limit it in
requirements.txt.
Note: this patch updates kafka driver (due to deprecated exception
in library) in order to pass unit tests
Change-Id: Id6b0814e05a0e548a8c2a5359daf1a6878cf6859
This change https://review.openstack.org/#/c/599912/ accidentally
removed setting the virtual host to '/' if none were provided in the
transport_url configuration option.
Closes-Bug: #1798241
Change-Id: I2dbcec3f77eb7cc513350b00ea020cc8faaecec1
Developers run all sorts of different tools within Git repositories,
any of which can leave their own special trashfiles all over the
place. We can't every hope to catalog them all, so better to
recommend developers simply configure a global core.excludesfile to
filter the irrelevant files which tend to get created by their
personal choice of tools.
To this end, remove the long-standing sections for "Mr Developer"
and "Editors" since their mere existence here sends the signal that
we welcome (and have time to review) additions for any old tool
someone ever might happen to try. Also add a comment block
explaining this, for clarity.
We can, and should of course, continue to list files created by the
tools recommended by our workflow (test frameworks called from tox,
documentation and packaging builds, et cetera).
This change is a port of I1b41efac219fca44e2548fc36633724d0ecfc0cb
from the openstack-dev/oslo-cookiecutter repository.
Change-Id: I4078179f3d55847ea23f8790572ba911e52fce53
Change d3f6ca0b47e2a5a3413b27617d9655f02b191c6a have broken
oslo.messaging defaults, no more transport are selected by default and
oslo.messaging just crash:
Traceback (most recent call last):
File "/home/sileht/workspace/openstack/oslo.messaging/.tox/py27/lib/python2.7/site-packages/mock/mock.py", line 1305, in patched
return func(*args, **keywargs)
File "oslo_messaging/tests/test_transport.py", line 111, in test_get_transport
transport_ = oslo_messaging.get_transport(self.conf, **kwargs)
File "/home/sileht/workspace/openstack/oslo.messaging/.tox/py27/lib/python2.7/site-packages/debtcollector/removals.py", line 242, in wrapper
return f(*args, **kwargs)
File "oslo_messaging/transport.py", line 247, in get_transport
transport_cls=RPCTransport)
File "oslo_messaging/transport.py", line 205, in _get_transport
url.transport.split('+')[0],
AttributeError: 'NoneType' object has no attribute 'split'
This change restores rabbit:// as default.
Change-Id: I945a2aca60347dad672cc406cd33e80e93c588a7
Lots of exchanges create problems during failover under high
load. Please see bug report for details.
This is step 1 in the process: only using default exchange
when publishing. Consumers will still consume on separate
exchanges (and on default exchange by default) so this
should be (and tested to be) a non-breaking and
upgrade-friendly change.
Step 2 is to update consumers to only listen on default exchange,
to happen in T release.
Change-Id: Id3603f4b7e1274b616d76e1c0c009d2ab7f6efb6
Closes-Bug: #1789177
GetTransportSadPathTestCase did an awful lot of mocking for things that
were no longer called. Since we only have one callable now, make use of
self.assertRaises.
Change-Id: Ie93ff74de84ff4d6cc75a3c89dd9a03fdcba5d35
Since we have removed a large amount of deprecated options, add a
release note documenting which options have been removed.
Depends-On: https://review.openstack.org/580910
Change-Id: Idb45f691dab77e5bfae841ea45fa167c224c3322
Now that most projects have transitioned from using
ConfFixture.transport_driver, we can remove it and rpc_backend as a
whole. rpc_backend was first deprecated in 5.10.0, released during
Ocata.
Closes-Bug: #1712399
Change-Id: I193cc0e613459a6dbbfd54ed0901a54ded78d712
Remove the deprecated options rabbit_host, rabbit_port, rabbit_hosts,
rabbit_userid, rabbit_password, rabbit_virtual_host and
rabbit_max_retries which were deprecated in 5.10.0, released during
Ocata.
Change-Id: I39dec568e5de0b653e5af1f196537e09ef126a36
Closes-Bug: #1712394
Use openstack-tox-cover template, this runs the cover job as
non-voting in the check queue only.
Use openstack-lower-constraints-jobs template
Remove jobs that are part of the templates.
Sort list of templates, move templates first in project stanza as is
common practice.
Change-Id: Idb976b160479efcf9f3726c1716bf9d2c39ab6cc
The amqp1 options allow_insecure_options, username and password are all
deprecated, remove them. allow_insecure_options was deprecated during
Ocata, and the other two were deprecated in 5.22.0, released during
Pike.
Change-Id: I321266c3dba83a38fe6ebd775db2e74c14cc96cd
The rabbit_durable_queues option has been deprecated since amqp code was
moved from olso-incubator to this project, so it's high time it was
removed.
Change-Id: If2450696a43c05c32d35bff26d3dc38423f4330e
The Kafka driver deprecated the kafka_default_host and
kafka_default_port options in 5.10.0, released in Ocata. Remove them.
Change-Id: I206e68ec1624bb6d5d6ba320572530352bbd4378
Users of the oslo.messaging RPC communications service must use
the rabbit ("rabbit://...") or AMQP 1.0 ("amqp://...") drivers.
Change-Id: If3474142f1fe99d41d7b4466061ed0e23ca38549
Closes-Bug: 1789259
This is a mechanically generated patch to add a functional test job
running under Python 3 as part of the python3-first goal.
See the python3-first goal document for details:
https://governance.openstack.org/tc/goals/stein/python3-first.html
Change-Id: Ib99a323861c0fdb548287446ab25e0516a7c182e
Story: #2002586
Task: #24322
This is a mechanically generated patch to complete step 1 of moving
the zuul job settings out of project-config and into each project
repository.
Because there will be a separate patch on each branch, the branch
specifiers for branch-specific jobs have been removed.
See the python3-first goal document for details:
https://governance.openstack.org/tc/goals/stein/python3-first.html
Change-Id: I0401a53945ad87e1dc046904054b12e2b106a3e8
Story: #2003250
This defaults to 0 anyway, and is being removed as the devstack
excercises are being removed. see https://review.openstack.org/#/c/581377/
Change-Id: Ifb147f9fb2071724a9eaf306273276db65125cf7
Due to the bug below we want to have py-amqp>=2.3.0 so that connecting
to rabbit endpoints don't timeout when relying on /etc/hosts entries.
Closes-Bug: 1780992
Change-Id: Ia2c1114cb0f8d480695197714f7c6293751430dd
The patch for https://review.openstack.org/#/c/436958/ fixed a
threading problem by moving the ack back to the polling
thread. However the RPC server expects to catch any failures of the
ACK and abort the request. This patch adds the ACK error handling
back to the polling thread.
This patch is based heavily off the original work done by Mehdi
Abaakouk (sileht).
Change-Id: I708c3d6676b974d8daac6817c15f596cdf35817b
Closes-Bug: #1695746
