In case the acknowledgement or requeue of a message fail,
the kombu transport can be disconnected
In this case, we must redeclare our consumers.
This changes fixes that.
This have no tests because the kombu memory transport we use in our tests
cannot be in disconnected state.
Closes-bug: #1448650
Change-Id: I5991a4cf827411bc27c857561d97461212a17f40
We at least need these versions of amqp and kombu to have
a working heartbeat support.
Related-bug: #1436788
Closes-bug: #1436769
Closes-bug: #1408830
Change-Id: I61440c5ccf2b540fe9a1e868bdcae9f5d2cf8422
This removes a TODO, that was not possible before the consumer code
refactoring.
Now, we can just catch the right exception instead of catching
everything and pray.
Change-Id: Id6203d79d4b2f027e5c6cd952c99fcd0967ecb3c
When a consumer is declared after we have started to consume
amqp, its queue is never consumed.
This fixes that.
Closes bug: #1450342
Change-Id: I9f2e7d83283504dfe762ac88384efde0f7b52d47
The consumer code is over engineered, it allows to override
everything, but the override is always done with functools.partial.
None of the child Class have the same signature, sometimes
the constructor use the parameter name as the parent class but for
a different purpose, that makes the code hard to read.
It's was never clear which options is passed to the queue and the
exchange at this end to kombu.
This changes removes all of that stuffs, and only use the kombu
terminology for consumer parameters.
Alse we don't hardcode anymore the tag and the channel in the consumer
class, to allow to change them without recreating a consumer object
in the futur.
Change-Id: Ie341f0c973adbda9a342cb836867345aa42652d1
The publisher code is over engineered, it allows to override
everything, but this is never used.
None of the child Class have the same signature, sometimes
the constructor use the parameter name as the parent class but for
a different purpose, that make the code hard to read.
It's was never clear which options is passed to the queue and the
exchange at this end to kombu.
This changes removes all of that stuffs, and only use the kombu
terminology for publisher parameters.
Change-Id: I3cebf3ed1647a3121dcf33e2160cf315486f5204
This serializer available (with some differences) in ceilometer,
cinder, designate, heat, ironic, magnum, manila, neutron, nova, trove.
So we can move it to the common code and re-use (or inherit from it) in
OpenStack projects
Change-Id: I0d68b1d98c2214a5d45b65146ac2d19e5f6f5953
The consumer loop is over engineered, it returns unused return,
iterconsume creates an iterator directly consumed by 'consume' without
special handling, and in some case kombu error callback are called when
the iterator is stopped and log useless error.
And in reality the consumer is always called when limit=1.
This change simplifies that, by removing the loop and removes all
returns stuffs.
Closes bug: #1450336
Change-Id: Ia2cb52c8577b29e74d4d2b0ed0b535102f2d55c7
To avoid creating a new ZMQ connection for every message sent
to a remote broker, implement pooling and re-use of ZmqClient
objects and associated ZMQ context.
A pool is created for each remote endpoint (keyed by address);
the size of each pool is configured using rpc_conn_pool_size.
All outbound message client connections are pooled.
Closes-Bug: 1384113
Change-Id: Ia55d5c310a56e51df5e2f5d39e561a4da3fe4d83
Bump eventlet to 0.17.3, the first release fully supporting Python 3
with monkey-patching.
Add aioeventlet and trollius dependencies for the aioeventlet
executor on Python 3.
This change enables tests of eventlet and aioeventlet executors on
Python 3.
Add futures to Python 3 dependencies even if it's not needed, it's
required to workaround a bug in tox.
Depends-on: I73e3056b5e8b9ce710c9c2d59fc5be8e03e28d2a
Change-Id: I0efae1c91c5d830156b867d7d21b5c0065094665
JsonPayloadSerializer exists in a several OpenStack projects such as
cinder, ironic, magnum, nova, trove so there is a sense to keep it in
oslo.messaging to avoid of code duplication.
Change-Id: I77a6e5e3e717b0afcf17b6200d5b8ff5db6e3262
redis.smembers(str) returns a list of byte strings.
I missed test failures when I submited my patch to enable redis on
Python 3. I didn't notice that redis tests are skipped when no local
redis server is running.
Change-Id: Ib9ec4e05eb9abd51613f32c93118a1c76649798a
Due to some discovered issues since heartbeat is enabled by default.
Specially #1436788, that needs to fix the underlying library, too.
So, according to the discution here:
https://bugs.launchpad.net/oslo.messaging/+bug/1436769/comments/10
We decide to mark the implementation as experimental and disable it by default.
Related-bug: #1436788
Related-bug: #1436769
Change-Id: Ib7c55977f976bdbbc8df4ad5915e0433cbf84a17
The mock module has been added to Python 3.3 as unittest.mock.
The third party mock module doesn't seem to be maintained anymore: the
last commit was in April 2013.
unittest.mock is more recent, has less bugs and is compatible with
Python 3.4. There are bugs on Python 3 in the third party mock module,
examples:
* https://code.google.com/p/mock/issues/detail?id=225
* https://code.google.com/p/mock/issues/detail?id=234
Oslo Messaging hits these issues when running tests on Python 3.4.
Import oslotest to setup six.moves for mock.
Change-Id: Ic160101695cea67eb9bbbfcaddb8d3dac64e6804
Different OpenStack processes log that line when idle, but it doesn't
offer actionable information to developers or users. Ideally process
logs should be silent when idle, even in debug mode.
Here's a sample:
http://paste.openstack.org/show/201371/
Change-Id: Ib4f63d590a6f5ed295fae12dac12897007b12879
The retry variable can be None which causes this exception to be
formatted incorrectly. Switching from %(retry)d to %(retry)s
should handle the case where retry is None more gracefully.
Change-Id: I592ea3e44506afb4a676d8dbe1e659a0e649424e
Closes-bug: #1440755
To make sure notify.logger always play well with messaging(v2) driver.
Achieve this by seting up a logger with target logging handler, doing real
logging, finally check notifications that receive from message broker.
Change-Id: I234457974ca48689b9dfc9f7c72b4ea37a57a40b
