The consumer loop is over engineered, it returns unused return,
iterconsume creates an iterator directly consumed by 'consume' without
special handling, and in some case kombu error callback are called when
the iterator is stopped and log useless error.
And in reality the consumer is always called when limit=1.
This change simplifies that, by removing the loop and removes all
returns stuffs.
Closes bug: #1450336
Change-Id: Ia2cb52c8577b29e74d4d2b0ed0b535102f2d55c7
Bump eventlet to 0.17.3, the first release fully supporting Python 3
with monkey-patching.
Add aioeventlet and trollius dependencies for the aioeventlet
executor on Python 3.
This change enables tests of eventlet and aioeventlet executors on
Python 3.
Add futures to Python 3 dependencies even if it's not needed, it's
required to workaround a bug in tox.
Depends-on: I73e3056b5e8b9ce710c9c2d59fc5be8e03e28d2a
Change-Id: I0efae1c91c5d830156b867d7d21b5c0065094665
JsonPayloadSerializer exists in a several OpenStack projects such as
cinder, ironic, magnum, nova, trove so there is a sense to keep it in
oslo.messaging to avoid of code duplication.
Change-Id: I77a6e5e3e717b0afcf17b6200d5b8ff5db6e3262
redis.smembers(str) returns a list of byte strings.
I missed test failures when I submited my patch to enable redis on
Python 3. I didn't notice that redis tests are skipped when no local
redis server is running.
Change-Id: Ib9ec4e05eb9abd51613f32c93118a1c76649798a
Due to some discovered issues since heartbeat is enabled by default.
Specially #1436788, that needs to fix the underlying library, too.
So, according to the discution here:
https://bugs.launchpad.net/oslo.messaging/+bug/1436769/comments/10
We decide to mark the implementation as experimental and disable it by default.
Related-bug: #1436788
Related-bug: #1436769
Change-Id: Ib7c55977f976bdbbc8df4ad5915e0433cbf84a17
The mock module has been added to Python 3.3 as unittest.mock.
The third party mock module doesn't seem to be maintained anymore: the
last commit was in April 2013.
unittest.mock is more recent, has less bugs and is compatible with
Python 3.4. There are bugs on Python 3 in the third party mock module,
examples:
* https://code.google.com/p/mock/issues/detail?id=225
* https://code.google.com/p/mock/issues/detail?id=234
Oslo Messaging hits these issues when running tests on Python 3.4.
Import oslotest to setup six.moves for mock.
Change-Id: Ic160101695cea67eb9bbbfcaddb8d3dac64e6804
Different OpenStack processes log that line when idle, but it doesn't
offer actionable information to developers or users. Ideally process
logs should be silent when idle, even in debug mode.
Here's a sample:
http://paste.openstack.org/show/201371/
Change-Id: Ib4f63d590a6f5ed295fae12dac12897007b12879
The retry variable can be None which causes this exception to be
formatted incorrectly. Switching from %(retry)d to %(retry)s
should handle the case where retry is None more gracefully.
Change-Id: I592ea3e44506afb4a676d8dbe1e659a0e649424e
Closes-bug: #1440755
To make sure notify.logger always play well with messaging(v2) driver.
Achieve this by seting up a logger with target logging handler, doing real
logging, finally check notifications that receive from message broker.
Change-Id: I234457974ca48689b9dfc9f7c72b4ea37a57a40b
When publish_errors is True, and using `messaging` notify driver,
produces a infinite loop that report sending notification error.
The reason is we always passing None to the content argument in
logger handlers (LoggingNotificationHandler, LoggingErrorNotificationHandler),
when pack the context object which expected as a dict, raise TypeError
exception, so result in infinite retry looping.
To match what document said, passing a empty dict rather than None. Also
modify unittests to make sure context is a empty dict.
Change-Id: Ic2c4c43f5bbafa8107ea370ba959da16cfa4a24c
Closes-bug: #1346466
The decaying timer can now just use the functionality
of the oslo_utils stop watch to avoid having to maintain
similar information itself; now it just becomes a thin
layer ontop of that object that provides its functionality.
Change-Id: I1b014b821a6b980590ca5b4d850a515d55c42208
Different OpenStack processes log that line when idle, but it doesn't
offer actionable information to developers or users. Ideally process
logs should be silent when idle, even in debug mode.
Closes-Bug: #1434727
Change-Id: I6f9f2977358d86ada7178c09b04ff6b290a6a8ad
Url constructed for kombu cannot contain ipv6 address without
brackets. The url.hostname returns hosts without brackets so
we have to readd them.
Change-Id: Ifb1d358a67655af99a84b77ca813fc2dd87d87dc
