Now that python-qpid-proton has taken an approach similar to zmq's, it's
possible to install it in boxes where the C libraries are not present in
the system. This patch takes advantage of that to enable amqp protocol's
tests everywhere.
Change-Id: Ibce4c791aafadf45fa876d6a4f5373fde94769ff
This adds a setup script for each tox functional target to start a
rabbitmq-server, qpidd or redis daemon dedicated for the functional
testing.
This script is responsible to spawn a preconfigured daemon needed for
the functional tests.
This also changes the gate script to just install the required packages
instead of setup a devstack.
This also fixes the zmq config options loading in tests
Closes-bug: #1442612
Change-Id: I27eb2c1d3d0ca67aa361c83e41372138e03d9bdd
versionutils.py is no longer in oslo-incubator. So we can
either use versionutils from oslo_log or debtcollector instead.
However, oslo.messaging does not use oslo.log currently and we
should not be adding yet another library as a dependency here,
so we should just use the base python warnings library for
our limited use of deprecated() method.
Change-Id: Ib8a487051c894fa4828da65d4890b7a4f57f1d12
oslotest 1.7.0 breakes oslo.messaging unittests, because it doesn't add
mox to six.moves anymore - see change Ic59c73abb9b09cb594bf7df4173d7f99f81d526c
This patch fixes imports on test run.
Change-Id: Ia40b7733bd2e74b1a1703f2e1a5245f01debbd36
When the broker will block the connection for a server-side issue
like disk full, it notifies the client.
This change adds the callback methods when this occurs to inform
the deployer about the reason of this blocking.
Change-Id: I5164b9e1b720f022b45a5718258df036ba8808ed
Closes-bug: #1454449
This change causes the message sender to block until the messaging
infrastructure (e.g. the broker) assumes ownership of the message (or
fails to accept it). If the message is accepted, then the sender will
either pend for a response (in the case of RPC), or simply return (in
the case of notification). If the message is rejected by the
messaging infrastructure a MessagingException will be raised at the
sender.
Change-Id: I3f4a1ed1c17e18f6d629f16e6b5c99de45b083d6
Closes-Bug: #1377228
Connection class contains `magic` attribute conf, which contains (or at
least should contain) all config options. Set these config options as
class attributes to make the code more clear
Change-Id: Ib67f148e2ecf3def37e57d6e3359bced932fbc90
There was still a reference to the oslo.config namespace package
in _drivers/base.py. This converts it to the new package name.
Change-Id: I9c3878094bcf8015c30d87f693f51e0d48b31a33
The rabbit driver was using the rpc_response_timeout configuration
option as a reconnect timeout value, even though the option was defined
only in oslo_messaging.client and was not always being registered before
being accessed. An earlier patch fixed this by registering the option
here in the driver, too, but that breaks several levels of
abstraction. This changes the driver to define a new option with the
same default value, so that the driver is only using options it defines
itself. It also removes the old hacky fix.
Closes-bug: #1461182
Change-Id: Ia96c815d157219e12a10d94b87b0156503369a6b
Tests with `fanout_target` scenarios were skipped because of issue [1].
This issue already fixed, so we can enable these tests.
[1] https://github.com/celery/kombu/issues/195
Change-Id: I6600c6b9089e6093cbad2b0b96f2682ac9d25c69
Use stevedore.sphinxext to populate a new page listing all available
drivers.
Add docstrings to the driver classes, including references to more
extensive documentation if it is available.
Depends-on: I1a24f9326b4e54174d9dc0ae366315fe29c3ac1b
Depends-on: Ie715f98fe0d3cba8b2f4f6235e7c2b6f79be7ea0
Change-Id: Ief0aa05e6deba0126d63faf13497d0fe0539e08d
The response code in the rabbit driver doesn't use a Client object, so
the option is not being registered in servers that don't instantiate
Client instances (ironic-conductor, for example).
Change-Id: I7def5e6d4960938a17344db024585a0492d6969d
Partial-bug: #1461182
The current condition logic in _publish_and_retry_on_missing_exchange()
replaces passed `timeout` value with `rpc_response_timeout` config value.
This patch fix it.
Change-Id: I451cd2b5da78a3d7011466dfb14669aa1dcf1d5c
We are checking time of thread run in test_impl_rabbit.py and sometimes
it can be a bit longer, because of server load.
Set places=0 instead of 1 to make tests less restrictive.
Change-Id: I2ef6f1474047e1da64402e93696cb73b4d3318e8
Added a new configuration option `send_single_reply` which allows to
send a single AMQP reply instead of two. This will reduce amount of RPC
calls and increase transport productivity.
The new behaviour is not compatible with the old logic, so isn't
backward compatible and disabled by default.
DocImpact
A new configuration option added.
Blueprint: remove-double-reply
Change-Id: Idab118b22163e734aca010f325cddfaec26bfa0f
Current implementation of RabbitMQ driver in in Connection.reset() change
the channel to use and create a new channel for it. This happens after the
each message send.
There no big need to create a new channel each time, so we can cancel all
consumer queues, instead of creating a channel in reset().
Test test_connection_reset_always_succeed() removed, because we are not
create channel on reset() anymore.
Co-Authored-By: Mehdi Abaakouk <sileht@redhat.com>
Change-Id: Ie164840e6c055b01525b13aabdb8b9c7f5d1b98b
During the vancouver summit, Michael Klishin from
pivotal proposed we should use publisher confirms
as the default setting to reduce messages being
dropped on the floor.
https://www.rabbitmq.com/confirms.htmlhttp://www.rabbitmq.com/blog/2011/02/10/introducing-publisher-confirms/
This setting is a lightweight way of keeping track of which messages
have been processed by the broker and which would need re-publishing
in case of broker shutdown or network failure.
Change-Id: I25bc955df130dad4725f5281211d37fd73e7ea63
When rpc_conn_pool_size have been moved from amqp.py to base.py:
87137e7af05f12a99bd04566036fbf71824f45cf
We loose the deprecated_group, this change reintroduces it.
Change-Id: I8cdea7f042afebcc162bafef881ebe61a1cac989
At the moment for each msg_id we receive two amqp message - first one
with the payload, a second one to ensure the other have finish to send
the payload. This was made, because a long time ago 'reply' allowed
generator as payload to send multiple messages on one 'rpc.call' - [1]
It's a bad idea - to double RPC messages for each call, so we are going
to remove this the second AMQP message sending. This patch allows
receiver side to proceed correctly old case - two AMQP messages (first
with data and second with 'ending' parameter) same as the new one (a
single message with data 'ending' parameter)
Blueprint: remove-double-reply
[1] - https://github.com/openstack/oslo-incubator/blob/stable/icehouse/openstack/common/rpc/amqp.py#L464
Change-Id: Ic09fe619694c300c4502acb7157d7ecdd47c5fd7
heartbeat_thread is not set for listeners. when closing connection,
it blindly checks heartbeat_thread and will throw an error causing
connection to remain open. this patch explicitly sets
heartbeat_thread to None.
Change-Id: Ief3bf02f952882ecadf742cdd0bac8edd7812473
Closes-Bug: #1458917
When we send a reply and the exchange is missing, they
no need to wait more that the timeout set by the application.
Change-Id: I7eb19346d72cb0a4813c964df1435d7f4c79e218
impl_rabbit set timeout into message's header with {'ttl': (timeout * 1000)},
this mean doesn't work in real, messages still stays in queue after the ttl.
As RabbitMQ document said (http://www.rabbitmq.com/ttl.html#per-message-ttl),
we should passing "expiration" into message's property rather than header to
make it work.
Change-Id: I5d6ae72e69f856c56fb83fb939ed35246716e04d
Closes-bug: #1444854
