openstack/project-config
Code Issues Proposed changes

Remove superfluous quoting on commit trailer

Browse Source 
The nested quoting in playbooks/proposal/propose_update.sh is ends
up causing the shell to escape the inner quotes changing the way git
commit interprets the --trailer value. Since the string doesn't
contain any embedded whitespace, we can just drop those quotes.

Change-Id: I70adf049b01917d79839d3b4dd52248acc6d0494
This commit is contained in:
Jeremy Stanley
2025-07-05 14:27:07 +00:00
parent 4f63e6fbed
commit 53d254bc73
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
playbooks/proposal/propose_update.sh
View File

@@ -176,7 +176,7 @@ for PROJECT in $PROJECTS; do
pushd $PROJECT_DIR
if ! git diff --stat --exit-code HEAD ; then
# Commit and review
git_args="-a -F- -s --trailer='Generated-By:openstack/project-config:playbooks/proposal/propose_update.sh'"
git_args="-a -F- -s --trailer=Generated-By:openstack/project-config:playbooks/proposal/propose_update.sh"
git commit $git_args <<EOF
$COMMIT_MSG
EOF