openstack/puppet-barbican
Code Issues Proposed changes

Use common format for service description

Browse Source 
Use the "OpenStack * Service" format which is more commonly used in our
modules. Also 'Key Manager' is the word actually described in Barbican
documentation, instead of 'Key Management'.

Change-Id: I745a9ee6b05b471ab6f95186b7d5c3f52d0d5a87
This commit is contained in:
Takashi Kajinami
2024-09-16 01:50:19 +09:00
parent 2f64e99597
commit aeda2af39f
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
manifests/keystone/auth.pp
View File

@@ -57,7 +57,7 @@
#
# [*service_description*]
# (Optional) Description of the service.
# Default to 'Key management Service'
# Default to 'OpenStack Key Manager Service'
#
# [*public_url*]
# (Optional) The endpoint's public url.
@@ -85,7 +85,7 @@ class barbican::keystone::auth (
Boolean $configure_endpoint = true,
Boolean $configure_user = true,
Boolean $configure_user_role = true,
String[1] $service_description = 'Key management Service',
String[1] $service_description = 'OpenStack Key Manager Service',
String[1] $service_name = 'barbican',
String[1] $service_type = 'key-manager',
String[1] $region = 'RegionOne',

6
spec/classes/barbican_keystone_auth_spec.rb
View File

@@ -17,7 +17,7 @@ describe 'barbican::keystone::auth' do
:configure_endpoint => true,
:service_name => 'barbican',
:service_type => 'key-manager',
:service_description => 'Key management Service',
:service_description => 'OpenStack Key Manager Service',
:region => 'RegionOne',
:auth_name => 'barbican',
:password => 'barbican_password',
@@ -44,7 +44,7 @@ describe 'barbican::keystone::auth' do
:configure_endpoint => false,
:configure_user => false,
:configure_user_role => false,
:service_description => 'Alternative Key management Service',
:service_description => 'Alternative OpenStack Key Manager Service',
:service_name => 'alt_service',
:service_type => 'alt_key-manager',
:region => 'RegionTwo',
@@ -59,7 +59,7 @@ describe 'barbican::keystone::auth' do
:configure_endpoint => false,
:service_name => 'alt_service',
:service_type => 'alt_key-manager',
:service_description => 'Alternative Key management Service',
:service_description => 'Alternative OpenStack Key Manager Service',
:region => 'RegionTwo',
:auth_name => 'alt_barbican',
:password => 'barbican_password',