Prepare for new lint plugins

This fixes a few lint warnings/errors detected by the following plugins
we aim to enable soon.
 - puppet-lint-file_ensure-check
 - puppet-lint-trailing_comma-check
 - puppet-lint-topscope-variable-check

Change-Id: I94315cab24a78b2b7aab570d782ef0f72c652f53
Signed-off-by: Takashi Kajinami <kajinamit@oss.nttdata.com>

manifests/init.pp

@@ -174,7 +174,7 @@ class ceph (
 
   package { $ceph::params::packages :
     ensure => $ensure,
-    tag    => 'ceph'
+    tag    => 'ceph',
   }
 
   if $ensure !~ /(absent|purged)/ {

manifests/mds.pp

@@ -84,7 +84,7 @@ class ceph::mds (
   service { $mds_service_name:
     ensure => $mds_ensure,
     enable => $mds_enable,
-    tag    => ['ceph-mds']
+    tag    => ['ceph-mds'],
   }
 
   package { $pkg_mds:

manifests/mirror.pp

@@ -50,7 +50,7 @@ define ceph::mirror (
     ensure => $rbd_mirror_ensure,
     enable => $rbd_mirror_enable,
     name   => $service_name,
-    tag    => ['ceph-rbd-mirror']
+    tag    => ['ceph-rbd-mirror'],
   }
 
   Ceph_config<||> ~> Service<| tag == 'ceph-rbd-mirror' |>

manifests/profile/client.pp

@@ -28,7 +28,7 @@ class ceph::profile::client {
   if ! defined(Class['ceph::keys']) {
     if !empty($ceph::profile::params::client_keys) {
       class { 'ceph::keys':
-        args => $ceph::profile::params::client_keys
+        args => $ceph::profile::params::client_keys,
       }
     }
   }

manifests/profile/mds.pp

@@ -35,7 +35,7 @@ class ceph::profile::mds {
       keyring_path => "/var/lib/ceph/mds/ceph-${facts['networking']['hostname']}/keyring",
       secret       => $ceph::profile::params::mds_key,
       user         => 'ceph',
-      group        => 'ceph'
+      group        => 'ceph',
     } -> Service<| tag == 'ceph-mds' |>
   }
 }

manifests/profile/mon.pp

@@ -39,7 +39,7 @@ class ceph::profile::mon {
   if !empty($ceph::profile::params::client_keys) {
     class { 'ceph::keys':
       args     => $ceph::profile::params::client_keys,
-      defaults => $defaults
+      defaults => $defaults,
     }
   }
 }

manifests/rgw.pp

@@ -180,7 +180,7 @@ define ceph::rgw (
 
   # Log file for radosgw (ownership)
   file { $log_file:
-    ensure                  => present,
+    ensure                  => file,
     owner                   => $user_real,
     mode                    => '0640',
     selinux_ignore_defaults => true,
@@ -194,7 +194,7 @@ define ceph::rgw (
     ensure => $rgw_ensure,
     enable => $rgw_enable,
     name   => "ceph-radosgw@${name}",
-    tag    => ['ceph-radosgw']
+    tag    => ['ceph-radosgw'],
   }
 
   Ceph_config<||> ~> Service<| tag == 'ceph-radosgw' |>