Add service role by default

This is the role created to be used by service users. At this moment
several services/functionalities still need the admin role so is kept.

Change-Id: I6c1ce9b9a507ce656a4eeb3b6e5119f35f5d674b
Signed-off-by: Takashi Kajinami <kajinamit@oss.nttdata.com>

manifests/keystone/auth.pp

@@ -53,7 +53,7 @@
 #
 # [*roles*]
 #   (Optional) List of roles assigned to glance user.
-#   Defaults to ['admin']
+#   Defaults to ['admin', 'service']
 #
 # [*system_scope*]
 #   (Optional) Scope for system operations.
@@ -99,7 +99,7 @@ class glance::keystone::auth (
   String[1] $service_type                 = 'image',
   String[1] $region                       = 'RegionOne',
   String[1] $tenant                       = 'services',
-  Array[String[1]] $roles                 = ['admin'],
+  Array[String[1]] $roles                 = ['admin', 'service'],
   String[1] $system_scope                 = 'all',
   Array[String[1]] $system_roles          = [],
   String[1] $service_description          = 'OpenStack Image Service',

releasenotes/notes/service-role-4723ba9dcdfe9682.yaml

@@ -0,0 +1,5 @@
+---
+features:
+  - |
+    The ``glance::keystone::auth`` class now adds the ``service`` role by
+    default. Set the ``roles`` parameter not to add the role.

spec/classes/glance_keystone_auth_spec.rb

@@ -24,7 +24,7 @@ describe 'glance::keystone::auth' do
         :password            => 'glance_password',
         :email               => 'glance@localhost',
         :tenant              => 'services',
-        :roles               => ['admin'],
+        :roles               => ['admin', 'service'],
         :system_scope        => 'all',
         :system_roles        => [],
         :public_url          => 'http://127.0.0.1:9292',
@@ -39,7 +39,7 @@ describe 'glance::keystone::auth' do
           :auth_name           => 'alt_glance',
           :email               => 'alt_glance@alt_localhost',
           :tenant              => 'alt_service',
-          :roles               => ['admin', 'service'],
+          :roles               => ['admin'],
           :system_scope        => 'alt_all',
           :system_roles        => ['admin', 'member', 'reader'],
           :configure_endpoint  => false,
@@ -68,7 +68,7 @@ describe 'glance::keystone::auth' do
         :password            => 'glance_password',
         :email               => 'alt_glance@alt_localhost',
         :tenant              => 'alt_service',
-        :roles               => ['admin', 'service'],
+        :roles               => ['admin'],
         :system_scope        => 'alt_all',
         :system_roles        => ['admin', 'member', 'reader'],
         :public_url          => 'https://10.10.10.10:80',