openstack/puppet-ironic
Code Issues Proposed changes

Use new openstackclient tag

Browse Source 
The new openstackclient tag was added so that we can get all resources
about openstack CLI more easily. Add this tag to
ironic-inspector-client because the package provides some sub-commands.

Also, ironic-inspector-client is not required by ironic services and
ironic-inspector services, so support-package tag can be removed.

Change-Id: I07b99c2e82d59562fe5ecb883791310ca8ffb102
Signed-off-by: Takashi Kajinami <kajinamit@oss.nttdata.com>
This commit is contained in:
Takashi Kajinami
2025-09-07 13:26:01 +09:00
parent 0441f9c7e0
commit b7dca0abe6
2 changed files with 2 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/inspector/client.pp
View File

@@ -17,7 +17,7 @@ class ironic::inspector::client (
package { 'python-ironic-inspector-client':
ensure => $package_ensure,
name => $ironic::params::inspector_client_package,
tag => ['openstack', 'ironic-support-package'],
tag => ['openstack', 'openstackclient'],
}
include openstacklib::openstackclient

15
spec/classes/ironic_inspector_client_spec.rb
View File

@@ -15,20 +15,7 @@
require 'spec_helper'
describe 'ironic::inspector::client' do
let :params do
{}
end
let :default_params do
{ :package_ensure => 'present' }
end
shared_examples_for 'inspector client' do
let :p do
default_params.merge(params)
end
it { is_expected.to contain_class('ironic::deps') }
it { is_expected.to contain_class('ironic::params') }
@@ -36,7 +23,7 @@ describe 'ironic::inspector::client' do
is_expected.to contain_package('python-ironic-inspector-client').with(
:ensure => 'present',
:name => platform_params[:inspector_client_package],
:tag => ['openstack', 'ironic-support-package'],
:tag => ['openstack', 'openstackclient'],
)
end